[jira] [Updated] (OFBIZ-9812) [FB] Package org.apache.ofbiz.content.layout

[Nicolas Malin (Jira)]

     [ https://issues.apache.org/jira/browse/OFBIZ-9812?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Leichert updated OFBIZ-9812:
-----------------------------------
    Attachment: OFBIZ-9812_org.apache.ofbiz.content.layout_bugfixes.patch

class LayoutEvents
- line 80 : "" to '' in indexOf (better performance)
- line 423, 491 : changed null object to LinkedList to prevent npe
 

> [FB] Package org.apache.ofbiz.content.layout
> --------------------------------------------
>
>                 Key: OFBIZ-9812
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9812
>             Project: OFBiz
>          Issue Type: Sub-task
>          Components: ALL APPLICATIONS, ALL COMPONENTS
>            Reporter: Julian Leichert
>            Priority: Minor
>         Attachments: OFBIZ-9812_org.apache.ofbiz.content.layout_bugfixes.patch
>
>
> LayoutEvents.java:434, NP_LOAD_OF_KNOWN_NULL_VALUE
> - NP: Load of known null value in org.apache.ofbiz.content.layout.LayoutEvents.createLayoutSubContent(HttpServletRequest, HttpServletResponse)
> The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null).
> LayoutEvents.java:503, NP_LOAD_OF_KNOWN_NULL_VALUE
> - NP: Load of known null value in org.apache.ofbiz.content.layout.LayoutEvents.updateLayoutSubContent(HttpServletRequest, HttpServletResponse)
> The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null).
> LayoutWorker.java:97, NP_LOAD_OF_KNOWN_NULL_VALUE
> - NP: Load of known null value in org.apache.ofbiz.content.layout.LayoutWorker.uploadImageAndParameters(HttpServletRequest, String)
> The variable referenced at this point is known to be null due to an earlier check against null. Although this is valid, it might be a mistake (perhaps you intended to refer to a different variable, or perhaps the earlier check to see if the variable is null should have been a check to see if it was non-null).

--
This message was sent by Atlassian JIRA
(v6.4.14#64029)