[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[jira] [Updated] (OFBIZ-9836) General refactoring and code improvements

Nicolas Malin (Jira)

     [ https://issues.apache.org/jira/browse/OFBIZ-9836?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Julian Leichert updated OFBIZ-9836:
-----------------------------------
    Attachment:     (was: OFBIZ-No_org.apache.ofbiz.product.product.ProductSearchSession.patch)

> General refactoring and code improvements
> -----------------------------------------
>
>                 Key: OFBIZ-9836
>                 URL: https://issues.apache.org/jira/browse/OFBIZ-9836
>             Project: OFBiz
>          Issue Type: Improvement
>          Components: ALL COMPONENTS
>    Affects Versions: Trunk
>            Reporter: Dennis Balkir
>            Assignee: Michael Brohl
>            Priority: Minor
>
> - Diamond Operators (removing unnecessary parameters)
> - unnecessary else (removing unnecessary else-phrase, e.g. when the if-phrase always ends in a return)
> - multi catches (using multi catches instead of multiple single ones, if possible)
> - enhance for-loops:
> for (int zahl : zahlen) {
>   System.out.print(zahl + " ");
> }
> - remove exceptions which aren't thrown (some methods claim to throw exceptions, which aren't actually thrown, they will be removed)
> - remove old commented unnecessary code
> - put {} around every if and else (this is to make the code more even, because some coders use it and some don't)
> there will be separate patches for each class of the package for easier reviewing and patching purposes



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)