missing transactionTimeout attribute causes application to break

[valery chenzo]

Hi Guys,

 

A recent change to the base code might have introduced a bug to the system causing my application to break. The transactionTimeout attribute seems to have been introduced for events and looking at the site-conf.xsd this attribute is not mandatory but the parser treats it as one. The fix is simple and has been attached (would have created a Jira issue but don’t think I have permission).

 

Bug stacktrace below:

 

java.lang.NumberFormatException: For input string: ""

        java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)

        java.lang.Integer.parseInt(Integer.java:592)

        java.lang.Integer.valueOf(Integer.java:766)

        org.apache.ofbiz.webapp.control.ConfigXMLReader$Event.<init>(ConfigXMLReader.java:514)

        org.apache.ofbiz.webapp.control.ConfigXMLReader$RequestMap.<init>(ConfigXMLReader.java:573)

        org.apache.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.loadRequestMap(ConfigXMLReader.java:487)

        org.apache.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.<init>(ConfigXMLReader.java:203)

        org.apache.ofbiz.webapp.control.ConfigXMLReader.getControllerConfig(ConfigXMLReader.java:144)

        org.apache.ofbiz.webapp.control.RequestHandler.<init>(RequestHandler.java:91)

        org.apache.ofbiz.webapp.control.RequestHandler.getRequestHandler(RequestHandler.java:81)

        org.apache.ofbiz.webapp.control.ControlServlet.getRequestHandler(ControlServlet.java:326)

        org.apache.ofbiz.webapp.control.ControlServlet.init(ControlServlet.java:77)

        org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)

        org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)

        org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616)

        org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:528)

        org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1100)

        org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:687)

        org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520)

        org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1476)

        java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)

        java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)

        org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)

        java.lang.Thread.run(Thread.java:745)

 

 

--Chenzo

[valery chenzo]

Sorry wrong patch

 

From: Valery Ngah <[hidden email]>
Date: Sunday, October 2, 2016 at 21:39
To: <[hidden email]>
Subject: missing transactionTimeout attribute causes application to break

 

Hi Guys,

 

A recent change to the base code might have introduced a bug to the system causing my application to break. The transactionTimeout attribute seems to have been introduced for events and looking at the site-conf.xsd this attribute is not mandatory but the parser treats it as one. The fix is simple and has been attached (would have created a Jira issue but don’t think I have permission).

 

Bug stacktrace below:

 

java.lang.NumberFormatException: For input string: ""

        java.lang.NumberFormatException.forInputString(NumberFormatException.java:65)

        java.lang.Integer.parseInt(Integer.java:592)

        java.lang.Integer.valueOf(Integer.java:766)

        org.apache.ofbiz.webapp.control.ConfigXMLReader$Event.<init>(ConfigXMLReader.java:514)

        org.apache.ofbiz.webapp.control.ConfigXMLReader$RequestMap.<init>(ConfigXMLReader.java:573)

        org.apache.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.loadRequestMap(ConfigXMLReader.java:487)

        org.apache.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.<init>(ConfigXMLReader.java:203)

        org.apache.ofbiz.webapp.control.ConfigXMLReader.getControllerConfig(ConfigXMLReader.java:144)

        org.apache.ofbiz.webapp.control.RequestHandler.<init>(RequestHandler.java:91)

        org.apache.ofbiz.webapp.control.RequestHandler.getRequestHandler(RequestHandler.java:81)

        org.apache.ofbiz.webapp.control.ControlServlet.getRequestHandler(ControlServlet.java:326)

        org.apache.ofbiz.webapp.control.ControlServlet.init(ControlServlet.java:77)

        org.apache.catalina.authenticator.AuthenticatorBase.invoke(AuthenticatorBase.java:502)

        org.apache.catalina.valves.ErrorReportValve.invoke(ErrorReportValve.java:79)

        org.apache.catalina.valves.AbstractAccessLogValve.invoke(AbstractAccessLogValve.java:616)

        org.apache.catalina.connector.CoyoteAdapter.service(CoyoteAdapter.java:528)

        org.apache.coyote.http11.AbstractHttp11Processor.process(AbstractHttp11Processor.java:1100)

        org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.process(AbstractProtocol.java:687)

        org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.doRun(NioEndpoint.java:1520)

        org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.run(NioEndpoint.java:1476)

        java.util.concurrent.ThreadPoolExecutor.runWorker(ThreadPoolExecutor.java:1142)

        java.util.concurrent.ThreadPoolExecutor$Worker.run(ThreadPoolExecutor.java:617)

        org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(TaskThread.java:61)

        java.lang.Thread.run(Thread.java:745)

 

 

--Chenzo

[Jacopo Cappellato-5]

Hi Chenzo,

thanks for the report and the patch! Unfortunately this mailing list
removes all attachments and so we couldn't get your patch.
You should be able to file a ticket in Jira once you create an account
there.
Please let us know if you face any issues.

Thanks,

Jacopo

On Mon, Oct 3, 2016 at 10:22 AM, Valery Ngah <[hidden email]> wrote:

> Sorry wrong patch
>
>
>
> *From: *Valery Ngah <[hidden email]>
> *Date: *Sunday, October 2, 2016 at 21:39
> *To: *<[hidden email]>
> *Subject: *missing transactionTimeout attribute causes application to
> break
>
>
>
> Hi Guys,
>
>
>
> A recent change to the base code might have introduced a bug to the system
> causing my application to break. The *transactionTimeout *attribute seems
> to have been introduced for events and looking at the site-conf.xsd this
> attribute is not mandatory but the parser treats it as one. The fix is
> simple and has been attached (would have created a Jira issue but don’t
> think I have permission).
>
>
>
> Bug stacktrace below:
>
>
>
> java.lang.NumberFormatException: For input string: ""
>
>         java.lang.NumberFormatException.forInputString(
> NumberFormatException.java:65)
>
>         java.lang.Integer.parseInt(Integer.java:592)
>
>         java.lang.Integer.valueOf(Integer.java:766)
>
>         org.apache.ofbiz.webapp.control.ConfigXMLReader$Event.
> <init>(ConfigXMLReader.java:514)
>
>         org.apache.ofbiz.webapp.control.ConfigXMLReader$RequestMap.<init>(
> ConfigXMLReader.java:573)
>
>         org.apache.ofbiz.webapp.control.ConfigXMLReader$ControllerConfig.
> loadRequestMap(ConfigXMLReader.java:487)
>
>         org.apache.ofbiz.webapp.control.ConfigXMLReader$
> ControllerConfig.<init>(ConfigXMLReader.java:203)
>
>         org.apache.ofbiz.webapp.control.ConfigXMLReader.
> getControllerConfig(ConfigXMLReader.java:144)
>
>         org.apache.ofbiz.webapp.control.RequestHandler.<init>(
> RequestHandler.java:91)
>
>         org.apache.ofbiz.webapp.control.RequestHandler.getRequestHandler(
> RequestHandler.java:81)
>
>         org.apache.ofbiz.webapp.control.ControlServlet.getRequestHandler(
> ControlServlet.java:326)
>
>         org.apache.ofbiz.webapp.control.ControlServlet.init(
> ControlServlet.java:77)
>
>         org.apache.catalina.authenticator.AuthenticatorBase.invoke(
> AuthenticatorBase.java:502)
>
>         org.apache.catalina.valves.ErrorReportValve.invoke(
> ErrorReportValve.java:79)
>
>         org.apache.catalina.valves.AbstractAccessLogValve.invoke(
> AbstractAccessLogValve.java:616)
>
>         org.apache.catalina.connector.CoyoteAdapter.service(
> CoyoteAdapter.java:528)
>
>         org.apache.coyote.http11.AbstractHttp11Processor.process(
> AbstractHttp11Processor.java:1100)
>
>         org.apache.coyote.AbstractProtocol$AbstractConnectionHandler.
> process(AbstractProtocol.java:687)
>
>         org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.
> doRun(NioEndpoint.java:1520)
>
>         org.apache.tomcat.util.net.NioEndpoint$SocketProcessor.
> run(NioEndpoint.java:1476)
>
>         java.util.concurrent.ThreadPoolExecutor.runWorker(
> ThreadPoolExecutor.java:1142)
>
>         java.util.concurrent.ThreadPoolExecutor$Worker.run(
> ThreadPoolExecutor.java:617)
>
>         org.apache.tomcat.util.threads.TaskThread$WrappingRunnable.run(
> TaskThread.java:61)
>
>         java.lang.Thread.run(Thread.java:745)
>
>
>
>
>
> --Chenzo
>