ofbiz 12.04 build broken

[taher]

Hi All,

I was trying to build branch 12.04 today which failed. I believe it is from commit r1646971. The fix is simply by importing the right libraries as shown below. Is this normal though? I thought stable branches are not supposed to crash while building.

Index: framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
===================================================================
--- framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (revision 1647061)
+++ framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (working copy)
@@ -20,6 +20,8 @@

import java.io.IOException;
import java.io.StringWriter;
+import java.util.ArrayList;
+import java.util.Collections;
import java.util.HashMap;
import java.util.Iterator;
import java.util.List;


Taher Alkhateeb

[Adrian Crum-3]

The R13 branch is broken too.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 12/20/2014 10:59 PM, Taher Alkhateeb wrote:

> Hi All,
>
> I was trying to build branch 12.04 today which failed. I believe it is from commit r1646971. The fix is simply by importing the right libraries as shown below. Is this normal though? I thought stable branches are not supposed to crash while building.
>
> Index: framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
> ===================================================================
> --- framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (revision 1647061)
> +++ framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (working copy)
> @@ -20,6 +20,8 @@
>
> import java.io.IOException;
> import java.io.StringWriter;
> +import java.util.ArrayList;
> +import java.util.Collections;
> import java.util.HashMap;
> import java.util.Iterator;
> import java.util.List;
>
>
> Taher Alkhateeb
>

[Jacopo Cappellato-4]

Taher, Adrian,

you are indeed right, thanks for the report and thanks to Taher for spotting the issue and providing the fix: I have committed it in the two branches.

Jacopo

On Dec 21, 2014, at 12:13 AM, Adrian Crum <[hidden email]> wrote:

> The R13 branch is broken too.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 12/20/2014 10:59 PM, Taher Alkhateeb wrote:
>> Hi All,
>>
>> I was trying to build branch 12.04 today which failed. I believe it is from commit r1646971. The fix is simply by importing the right libraries as shown below. Is this normal though? I thought stable branches are not supposed to crash while building.
>>
>> Index: framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
>> ===================================================================
>> --- framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (revision 1647061)
>> +++ framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (working copy)
>> @@ -20,6 +20,8 @@
>>
>> import java.io.IOException;
>> import java.io.StringWriter;
>> +import java.util.ArrayList;
>> +import java.util.Collections;
>> import java.util.HashMap;
>> import java.util.Iterator;
>> import java.util.List;
>>
>>
>> Taher Alkhateeb
>>

[Ashish Vijaywargiya]

Thanks Jacopo.

PS: Adrian, Taher thanks for reporting the issue and please accept my
sincere apologies. This has happened due to hand merging the trunk related
changes to R13.07 and R12.04 and somehow I missed to add import statement.
I will be extra careful from next time.

--
Regards,
Ashish

On Sun, Dec 21, 2014 at 11:17 AM, Jacopo Cappellato <
[hidden email]> wrote:

> Taher, Adrian,
>
> you are indeed right, thanks for the report and thanks to Taher for
> spotting the issue and providing the fix: I have committed it in the two
> branches.
>
> Jacopo
>
> On Dec 21, 2014, at 12:13 AM, Adrian Crum <
> [hidden email]> wrote:
>
> > The R13 branch is broken too.
> >
> > Adrian Crum
> > Sandglass Software
> > www.sandglass-software.com
> >
> > On 12/20/2014 10:59 PM, Taher Alkhateeb wrote:
> >> Hi All,
> >>
> >> I was trying to build branch 12.04 today which failed. I believe it is
> from commit r1646971. The fix is simply by importing the right libraries as
> shown below. Is this normal though? I thought stable branches are not
> supposed to crash while building.
> >>
> >> Index: framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
> >> ===================================================================
> >> --- framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (revision
> 1647061)
> >> +++ framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (working
> copy)
> >> @@ -20,6 +20,8 @@
> >>
> >> import java.io.IOException;
> >> import java.io.StringWriter;
> >> +import java.util.ArrayList;
> >> +import java.util.Collections;
> >> import java.util.HashMap;
> >> import java.util.Iterator;
> >> import java.util.List;
> >>
> >>
> >> Taher Alkhateeb
> >>
>
>

[Adrian Crum-3]

Before you commit:

ant clean-all load-demo run-tests

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 12/21/2014 6:23 AM, Ashish Vijaywargiya wrote:

> Thanks Jacopo.
>
> PS: Adrian, Taher thanks for reporting the issue and please accept my
> sincere apologies. This has happened due to hand merging the trunk related
> changes to R13.07 and R12.04 and somehow I missed to add import statement.
> I will be extra careful from next time.
>
> --
> Regards,
> Ashish
>
> On Sun, Dec 21, 2014 at 11:17 AM, Jacopo Cappellato <
> [hidden email]> wrote:
>
>> Taher, Adrian,
>>
>> you are indeed right, thanks for the report and thanks to Taher for
>> spotting the issue and providing the fix: I have committed it in the two
>> branches.
>>
>> Jacopo
>>
>> On Dec 21, 2014, at 12:13 AM, Adrian Crum <
>> [hidden email]> wrote:
>>
>>> The R13 branch is broken too.
>>>
>>> Adrian Crum
>>> Sandglass Software
>>> www.sandglass-software.com
>>>
>>> On 12/20/2014 10:59 PM, Taher Alkhateeb wrote:
>>>> Hi All,
>>>>
>>>> I was trying to build branch 12.04 today which failed. I believe it is
>> from commit r1646971. The fix is simply by importing the right libraries as
>> shown below. Is this normal though? I thought stable branches are not
>> supposed to crash while building.
>>>>
>>>> Index: framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
>>>> ===================================================================
>>>> --- framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (revision
>> 1647061)
>>>> +++ framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (working
>> copy)
>>>> @@ -20,6 +20,8 @@
>>>>
>>>> import java.io.IOException;
>>>> import java.io.StringWriter;
>>>> +import java.util.ArrayList;
>>>> +import java.util.Collections;
>>>> import java.util.HashMap;
>>>> import java.util.Iterator;
>>>> import java.util.List;
>>>>
>>>>
>>>> Taher Alkhateeb
>>>>
>>
>>
>

[Jacques Le Roux]

Or at least check Buildbot thereafter (though too late when you commit a lot, since it also handles other projects...)

Jacques

Le 21/12/2014 07:50, Adrian Crum a écrit :

> Before you commit:
>
> ant clean-all load-demo run-tests
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>
> On 12/21/2014 6:23 AM, Ashish Vijaywargiya wrote:
>> Thanks Jacopo.
>>
>> PS: Adrian, Taher thanks for reporting the issue and please accept my
>> sincere apologies. This has happened due to hand merging the trunk related
>> changes to R13.07 and R12.04 and somehow I missed to add import statement.
>> I will be extra careful from next time.
>>
>> --
>> Regards,
>> Ashish
>>
>> On Sun, Dec 21, 2014 at 11:17 AM, Jacopo Cappellato <
>> [hidden email]> wrote:
>>
>>> Taher, Adrian,
>>>
>>> you are indeed right, thanks for the report and thanks to Taher for
>>> spotting the issue and providing the fix: I have committed it in the two
>>> branches.
>>>
>>> Jacopo
>>>
>>> On Dec 21, 2014, at 12:13 AM, Adrian Crum <
>>> [hidden email]> wrote:
>>>
>>>> The R13 branch is broken too.
>>>>
>>>> Adrian Crum
>>>> Sandglass Software
>>>> www.sandglass-software.com
>>>>
>>>> On 12/20/2014 10:59 PM, Taher Alkhateeb wrote:
>>>>> Hi All,
>>>>>
>>>>> I was trying to build branch 12.04 today which failed. I believe it is
>>> from commit r1646971. The fix is simply by importing the right libraries as
>>> shown below. Is this normal though? I thought stable branches are not
>>> supposed to crash while building.
>>>>>
>>>>> Index: framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
>>>>> ===================================================================
>>>>> --- framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (revision
>>> 1647061)
>>>>> +++ framework/widget/src/org/ofbiz/widget/tree/ModelTree.java (working
>>> copy)
>>>>> @@ -20,6 +20,8 @@
>>>>>
>>>>> import java.io.IOException;
>>>>> import java.io.StringWriter;
>>>>> +import java.util.ArrayList;
>>>>> +import java.util.Collections;
>>>>> import java.util.HashMap;
>>>>> import java.util.Iterator;
>>>>> import java.util.List;
>>>>>
>>>>>
>>>>> Taher Alkhateeb
>>>>>
>>>
>>>
>>
>

[Adrian Crum-3]

By then it is too late - you have already announced to the world that
you are a lazy committer.

Adrian Crum
Sandglass Software
www.sandglass-software.com

On 12/21/2014 7:30 AM, Jacques Le Roux wrote:

> Or at least check Buildbot thereafter (though too late when you commit a
> lot, since it also handles other projects...)
>
> Jacques
>
> Le 21/12/2014 07:50, Adrian Crum a écrit :
>> Before you commit:
>>
>> ant clean-all load-demo run-tests
>>
>> Adrian Crum
>> Sandglass Software
>> www.sandglass-software.com
>>
>> On 12/21/2014 6:23 AM, Ashish Vijaywargiya wrote:
>>> Thanks Jacopo.
>>>
>>> PS: Adrian, Taher thanks for reporting the issue and please accept my
>>> sincere apologies. This has happened due to hand merging the trunk
>>> related
>>> changes to R13.07 and R12.04 and somehow I missed to add import
>>> statement.
>>> I will be extra careful from next time.
>>>
>>> --
>>> Regards,
>>> Ashish
>>>
>>> On Sun, Dec 21, 2014 at 11:17 AM, Jacopo Cappellato <
>>> [hidden email]> wrote:
>>>
>>>> Taher, Adrian,
>>>>
>>>> you are indeed right, thanks for the report and thanks to Taher for
>>>> spotting the issue and providing the fix: I have committed it in the
>>>> two
>>>> branches.
>>>>
>>>> Jacopo
>>>>
>>>> On Dec 21, 2014, at 12:13 AM, Adrian Crum <
>>>> [hidden email]> wrote:
>>>>
>>>>> The R13 branch is broken too.
>>>>>
>>>>> Adrian Crum
>>>>> Sandglass Software
>>>>> www.sandglass-software.com
>>>>>
>>>>> On 12/20/2014 10:59 PM, Taher Alkhateeb wrote:
>>>>>> Hi All,
>>>>>>
>>>>>> I was trying to build branch 12.04 today which failed. I believe
>>>>>> it is
>>>> from commit r1646971. The fix is simply by importing the right
>>>> libraries as
>>>> shown below. Is this normal though? I thought stable branches are not
>>>> supposed to crash while building.
>>>>>>
>>>>>> Index: framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
>>>>>> ===================================================================
>>>>>> --- framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
>>>>>> (revision
>>>> 1647061)
>>>>>> +++ framework/widget/src/org/ofbiz/widget/tree/ModelTree.java
>>>>>> (working
>>>> copy)
>>>>>> @@ -20,6 +20,8 @@
>>>>>>
>>>>>> import java.io.IOException;
>>>>>> import java.io.StringWriter;
>>>>>> +import java.util.ArrayList;
>>>>>> +import java.util.Collections;
>>>>>> import java.util.HashMap;
>>>>>> import java.util.Iterator;
>>>>>> import java.util.List;
>>>>>>
>>>>>>
>>>>>> Taher Alkhateeb
>>>>>>
>>>>
>>>>
>>>
>>

[Nicolas Malin-2]

Lazy and IT engineer aren't synonym ?

At the beginning, it's the reason that I has been chosen this jobs !
We would have lied to me !

PS : it's a joke :)

Le 21/12/2014 09:30, Adrian Crum a écrit :
> By then it is too late - you have already announced to the world that
> you are a lazy committer.
>
> Adrian Crum
> Sandglass Software
> www.sandglass-software.com
>