[ofbiz-framework] branch release17.12 updated: Fixed: Failed to update work effort child (OFBIZ-12250)

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch release17.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/release17.12 by this push:
     new 3742e03  Fixed: Failed to update work effort child (OFBIZ-12250)
3742e03 is described below

commit 3742e034a7540b2e328ac73025247b61be5e1990
Author: Jacques Le Roux <[hidden email]>
AuthorDate: Sat Jun 5 18:05:35 2021 +0200

    Fixed: Failed to update work effort child (OFBIZ-12250)
   
    When trying to update child work effort, a SQL error is reported:
    Column 'WORK_EFFORT_ID' cannot accept a NULL value.
   
    Steps to reproduce:
   
    1. Open : workeffort/control/ChildWorkEfforts?workEffortId=TASK01&trail=TASK01
    2. Select a child work effort
    3. Modify the name and click "Save"
   
    related to OFBIZ-753, workEffortId is also duplicated in edit form, If I
    comment out workEffortId field of EditWorkEffortAndAssoc, it works properly.
   
    Thanks: Xin Wang for report and Scott for initial workaround in OFBIZ-753
---
 applications/workeffort/widget/WorkEffortForms.xml | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/applications/workeffort/widget/WorkEffortForms.xml b/applications/workeffort/widget/WorkEffortForms.xml
index dd30ced..64c47ea 100644
--- a/applications/workeffort/widget/WorkEffortForms.xml
+++ b/applications/workeffort/widget/WorkEffortForms.xml
@@ -378,7 +378,10 @@ under the License.
                 </sub-hyperlink>
             </display-entity>
         </field>
-        <field name="workEffortId"><hidden/></field>
+        <!-- Commenting this field for now as the form widget cannot override useWhen fields from
+             the form it is extending (results in two workEffortId fields in the form)
+         <field name="workEffortId"><hidden value=""/></field>
+        -->
         <field name="workEffortAssocTypeId" map-name="workEffortAssoc">
             <display-entity entity-name="WorkEffortAssocType"/>
         </field>
@@ -1458,7 +1461,7 @@ under the License.
         <field name="facilityId"><ignored/></field>
         <field name="mustRsvp"><ignored/></field>
     </form>
-
+
     <form name="ListIcalendars" list-name="listIt" type="list"
         odd-row-style="alternate-row" header-row-style="header-row-2" default-table-style="basic-table hover-bar">
         <actions>