[ofbiz-framework] branch release17.12 updated: Fixed: pre push failures due to absence of checkstyle plugin (OFBIZ-11304) We have added a Gradle plugin com.github.jakemarsden.git-hooks which install pre push hook on developer machine, but due to limitations of checkstyle plugin with the Gradle version of release 17.12 these changes cannot be backported. Once the hook is installed it is difficult to remove the hook when branch changes. With the absence of checkstyle plugin, the hook fails when pushing code. To avoid such failures added [...]

[adityasharma]

This is an automated email from the ASF dual-hosted git repository.

adityasharma pushed a commit to branch release17.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/release17.12 by this push:
     new bf0c628  Fixed: pre push failures due to absence of checkstyle plugin (OFBIZ-11304) We have added a Gradle plugin com.github.jakemarsden.git-hooks which install pre push hook on developer machine, but due to limitations of checkstyle plugin with the Gradle version of release 17.12 these changes cannot be backported. Once the hook is installed it is difficult to remove the hook when branch changes. With the absence of checkstyle plugin, the hook fails when pushing code. To avoid s [...]
bf0c628 is described below

commit bf0c628dfb8a9bcc11e0450117f984dac8727098
Author: Aditya Sharma <[hidden email]>
AuthorDate: Wed Jul 22 19:02:10 2020 +0530

    Fixed: pre push failures due to absence of checkstyle plugin (OFBIZ-11304)
    We have added a Gradle plugin com.github.jakemarsden.git-hooks which install pre push hook on developer machine, but due to limitations of checkstyle plugin with the Gradle version of release 17.12 these changes cannot be backported. Once the hook is installed it is difficult to remove the hook when branch changes. With the absence of checkstyle plugin, the hook fails when pushing code. To avoid such failures added a dummy task with the same name.
---
 build.gradle | 15 ++++++++++++++-
 1 file changed, 14 insertions(+), 1 deletion(-)

diff --git a/build.gradle b/build.gradle
index 48b36b3..3878842 100644
--- a/build.gradle
+++ b/build.gradle
@@ -542,7 +542,7 @@ task generateReadmeFiles(group: docsGroup, type: AsciidoctorTask) {
     sourceDir "${rootDir}"
     sources {
         include 'README.adoc', 'CHANGELOG.adoc', 'CONTRIBUTING.adoc'
-      }    
+      }
     outputDir file("${buildDir}/asciidoc/readme/")
 }
 
@@ -983,6 +983,19 @@ def cleanTasks = getTasksMatchingRegex(/^clean.+/)
 task cleanAll(group: cleanupGroup, dependsOn: [cleanTasks, clean]) {
     description 'Execute all cleaning tasks.'
 }
+/*
+ * With OFBIZ-11304, Checkstyle pre-push hook is installed using the
+ * com.github.jakemarsden.git-hooks Gradle plugin
+ * As the checkstyle plugin has some limitations
+ * with Gradle 3.2 we are not able to backport.
+ * See https://issues.apache.org/jira/browse/OFBIZ-11251
+ * https://issues.apache.org/jira/browse/OFBIZ-11304
+ * Hook once added cannot be removed when branch is
+ * switched, adding dummy task to avoid push failures
+ * due to absence of checkstyle plugin in R17.12
+ */
+task checkstyleMain {}
+
 
 /* ========================================================
  * Rules-based OFBiz server commands