[ofbiz-framework] branch release18.12 updated: Improved: ‘EntityOperator#getId()’ is not used in the framework (OFBIZ-10607)

[mbrohl]

This is an automated email from the ASF dual-hosted git repository.

mbrohl pushed a commit to branch release18.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/release18.12 by this push:
     new 5570986  Improved: ‘EntityOperator#getId()’ is not used in the framework (OFBIZ-10607)
5570986 is described below

commit 5570986d6dddb05ac385712b8149b1a28b4e5693
Author: Michael Brohl <[hidden email]>
AuthorDate: Thu Jan 30 20:58:15 2020 +0100

    Improved: ‘EntityOperator#getId()’ is not used in the framework
    (OFBIZ-10607)
   
    Thanks Mathieu Lirzin for reporting and providing the patch.
---
 .../main/java/org/apache/ofbiz/entity/condition/EntityOperator.java | 6 ------
 1 file changed, 6 deletions(-)

diff --git a/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java b/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java
index 5008352..680c8e9 100644
--- a/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java
+++ b/framework/entity/src/main/java/org/apache/ofbiz/entity/condition/EntityOperator.java
@@ -25,7 +25,6 @@ import java.util.Iterator;
 import java.util.List;
 import java.util.Locale;
 import java.util.Map;
-import java.util.concurrent.atomic.AtomicInteger;
 
 import org.apache.ofbiz.base.util.UtilGenerics;
 import org.apache.ofbiz.entity.Delegator;
@@ -57,7 +56,6 @@ public abstract class EntityOperator<L, R, T> extends EntityConditionBase {
     public static final int ID_NOT_IN = 13;
     public static final int ID_NOT_LIKE = 14;
 
-    private static final AtomicInteger dynamicId = new AtomicInteger();
     private static HashMap<String, EntityOperator<?,?,?>> registry = new HashMap<>();
 
     private static <L,R,T> void registerCase(String name, EntityOperator<L,R,T> operator) {
@@ -91,10 +89,6 @@ public abstract class EntityOperator<L, R, T> extends EntityConditionBase {
         return UtilGenerics.cast(operator);
     }
 
-    public static int requestId() {
-        return dynamicId.get();
-    }
-
     public static final EntityComparisonOperator<?,?> EQUALS = new ComparableEntityComparisonOperator<Object>(ID_EQUALS, "=") {
         @Override
         public boolean compare(Comparable<Object> lhs, Object rhs) { return EntityComparisonOperator.compareEqual(lhs, rhs); }