[ofbiz-framework] branch trunk updated: Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new f1b88bd  Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
f1b88bd is described below

commit f1b88bd84bd43a419eb0425bcfe3ac87bf803ee2
Author: Jacques Le Roux <[hidden email]>
AuthorDate: Mon Sep 21 10:45:03 2020 +0200

    Improved: Checkstyle: Variable name must match pattern (OFBIZ-11926)
   
    Better use Debug.logVerbose in place where I replaced missing expression with
    another varation of Debug.log. We mainly don't need these information, it's only
    for Checkstyle.
   
    I thought did not replace cases where using another variation makes sense
---
 .../apache/ofbiz/accounting/thirdparty/verisign/PayflowPro.java   | 2 +-
 .../org/apache/ofbiz/order/shoppingcart/CartEventListener.java    | 8 ++++----
 .../org/apache/ofbiz/product/product/ProductSearchSession.java    | 2 +-
 .../apache/ofbiz/workeffort/workeffort/ICalRecurConverter.java    | 2 +-
 .../java/org/apache/ofbiz/webapp/control/LoginEventListener.java  | 2 +-
 .../org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java | 2 +-
 6 files changed, 9 insertions(+), 9 deletions(-)

diff --git a/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/verisign/PayflowPro.java b/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
index 63c6547..52f08b5 100644
--- a/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
+++ b/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
@@ -881,7 +881,7 @@ public class PayflowPro {
             Object valueObj = context.get(name);
 
             if (valueObj == null || (valueObj instanceof String) && ((String) valueObj).isEmpty()) {
-                Debug.logError("not valid; do nothing", MODULE);
+                Debug.logVerbose("not valid; do nothing", MODULE);
             } else {
                 String value = valueObj.toString();
 
diff --git a/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CartEventListener.java b/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CartEventListener.java
index e3f5e44..a1a8f7a 100644
--- a/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CartEventListener.java
+++ b/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CartEventListener.java
@@ -42,7 +42,7 @@ public class CartEventListener implements HttpSessionListener {
 
     @Override
     public void sessionCreated(HttpSessionEvent event) {
-        Debug.logInfo("Do nothing when the session is created.", MODULE);
+        Debug.logVerbose("Do nothing when the session is created.", MODULE);
     }
 
     @Override
@@ -50,7 +50,7 @@ public class CartEventListener implements HttpSessionListener {
         HttpSession session = event.getSession();
         ShoppingCart cart = (ShoppingCart) session.getAttribute("shoppingCart");
         if (cart == null) {
-            Debug.logInfo("No cart to save, doing nothing.", MODULE);
+            Debug.logVerbose("No cart to save, doing nothing.", MODULE);
             return;
         }
 
@@ -70,11 +70,11 @@ public class CartEventListener implements HttpSessionListener {
 
             GenericValue visit = VisitHandler.getVisit(session);
             if (visit == null) {
-                Debug.logInfo("Could not get the current visit, not saving abandoned cart info.", MODULE);
+                Debug.logVerbose("Could not get the current visit, not saving abandoned cart info.", MODULE);
                 return;
             }
 
-            Debug.logInfo("Saving abandoned cart", MODULE);
+            Debug.logVerbose("Saving abandoned cart", MODULE);
             int seqId = 1;
             for (ShoppingCartItem cartItem : cart) {
                 GenericValue cartAbandonedLine = delegator.makeValue("CartAbandonedLine");
diff --git a/applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearchSession.java b/applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearchSession.java
index b8d7688..57c3b21 100644
--- a/applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearchSession.java
+++ b/applications/product/src/main/java/org/apache/ofbiz/product/product/ProductSearchSession.java
@@ -477,7 +477,7 @@ public class ProductSearchSession {
                             } else if ("KOTT_OFBURL".equals(targetTypeEnumId)) {
                                 target = rh.makeLink(request, response, target, false, false, false);
                             } else if ("KOTT_AURL".equals(targetTypeEnumId)) {
-                                Debug.log("Do nothing, is absolute URL", MODULE);
+                                Debug.logVerbose("Do nothing, is absolute URL", MODULE);
                             } else {
                                 Debug.logError("The targetTypeEnumId[] is not recognized, not doing keyword override", MODULE);
                                 // might as well see if there are any others...
diff --git a/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalRecurConverter.java b/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalRecurConverter.java
index 04b5d24..12803c8 100644
--- a/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalRecurConverter.java
+++ b/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalRecurConverter.java
@@ -212,7 +212,7 @@ public class ICalRecurConverter implements TemporalExpressionVisitor {
 
     @Override
     public void visit(Substitution expr) {
-        Debug.log("iCalendar format does not support substitutions. Do nothing for now", MODULE);
+        Debug.logVerbose("iCalendar format does not support substitutions. Do nothing for now", MODULE);
     }
 
     @Override
diff --git a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginEventListener.java b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginEventListener.java
index 82f7481..91f878a 100644
--- a/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginEventListener.java
+++ b/framework/webapp/src/main/java/org/apache/ofbiz/webapp/control/LoginEventListener.java
@@ -38,7 +38,7 @@ public class LoginEventListener implements HttpSessionListener {
     public void sessionCreated(HttpSessionEvent event) {
         //for this one do nothing when the session is created...
         //HttpSession session = event.getSession();
-        Debug.log("do nothing, it's an ignored field; could add a comment or something if we wanted to", MODULE);
+        Debug.logVerbose("do nothing, it's an ignored field; could add a comment or something if we wanted to", MODULE);
 
     }
 
diff --git a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
index a6af891..00e359e 100644
--- a/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
+++ b/framework/widget/src/main/java/org/apache/ofbiz/widget/renderer/macro/MacroFormRenderer.java
@@ -1328,7 +1328,7 @@ public final class MacroFormRenderer implements FormStringRenderer {
     @Override
     public void renderIgnoredField(Appendable writer, Map<String, Object> context, IgnoredField ignoredField) {
         // do nothing, it's an ignored field; could add a comment or something if we wanted to
-        Debug.logError("do nothing, it's an ignored field; could add a comment or something if we wanted to", MODULE);
+        Debug.logVerbose("do nothing, it's an ignored field; could add a comment or something if we wanted to", MODULE);
 
     }