[ofbiz-framework] branch trunk updated: Improved: Enforce noninstantiability to ExpressionUiHelper Class. (#173)

[surajk]

This is an automated email from the ASF dual-hosted git repository.

surajk pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 9423bfd  Improved: Enforce noninstantiability to ExpressionUiHelper Class. (#173)
9423bfd is described below

commit 9423bfdcc58a253b2678a045826720118df465cf
Author: Suraj Khurana <[hidden email]>
AuthorDate: Wed Jun 3 16:05:30 2020 +0530

    Improved: Enforce noninstantiability to ExpressionUiHelper Class. (#173)
   
    (OFBIZ-11748)
   
    Made class as final, added private constructor and corrected private data member naming convention.
---
 .../org/apache/ofbiz/service/calendar/ExpressionUiHelper.java     | 8 +++++---
 1 file changed, 5 insertions(+), 3 deletions(-)

diff --git a/framework/service/src/main/java/org/apache/ofbiz/service/calendar/ExpressionUiHelper.java b/framework/service/src/main/java/org/apache/ofbiz/service/calendar/ExpressionUiHelper.java
index 2d0f96a..11ec925 100644
--- a/framework/service/src/main/java/org/apache/ofbiz/service/calendar/ExpressionUiHelper.java
+++ b/framework/service/src/main/java/org/apache/ofbiz/service/calendar/ExpressionUiHelper.java
@@ -36,16 +36,18 @@ import org.apache.ofbiz.entity.util.EntityQuery;
 import com.ibm.icu.util.Calendar;
 
 /** TemporalExpression UI artifacts worker. */
-public class ExpressionUiHelper {
+public final class ExpressionUiHelper {
 
     /** An array of valid DayInMonth occurrence values. */
-    private static final int Occurrence[] = {1, 2, 3, 4, 5, -1, -2, -3, -4 -5};
+    private static final int OCCURRENCE[] = {1, 2, 3, 4, 5, -1, -2, -3, -4 -5};
+
+    protected ExpressionUiHelper() { }
 
     /** Returns a List of valid DayInMonth occurrence int values.
      * @return returns a List of valid DayInMonth occurrence int values
      */
     public static List<?> getOccurrenceList() {
-        return Arrays.asList(Occurrence);
+        return Arrays.asList(OCCURRENCE);
     }
 
     /** Returns a List of Maps containing day of the week values.