[ofbiz-framework] branch trunk updated: Improved: Improved: Changed lineSplit value to 150. (OFBIZ-11737) Earlier it was 120, as per discussion over ML we decided to make it 150 instead.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ofbiz-framework] branch trunk updated: Improved: Improved: Changed lineSplit value to 150. (OFBIZ-11737) Earlier it was 120, as per discussion over ML we decided to make it 150 instead.

surajk
This is an automated email from the ASF dual-hosted git repository.

surajk pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new d6ebef6  Improved: Improved: Changed lineSplit value to 150. (OFBIZ-11737) Earlier it was 120, as per discussion over ML we decided to make it 150 instead.
d6ebef6 is described below

commit d6ebef619349f809062641d1b558cacdec3da208
Author: Suraj Khurana <[hidden email]>
AuthorDate: Mon May 25 17:24:30 2020 +0530

    Improved: Improved: Changed lineSplit value to 150.
    (OFBIZ-11737)
    Earlier it was 120, as per discussion over ML we decided to make it 150 instead.
---
 build.gradle                     | 2 +-
 config/checkstyle/checkstyle.xml | 8 ++++----
 2 files changed, 5 insertions(+), 5 deletions(-)

diff --git a/build.gradle b/build.gradle
index e6ef484..759327c 100644
--- a/build.gradle
+++ b/build.gradle
@@ -286,7 +286,7 @@ checkstyle {
     // the sum of errors found last time it was changed after using the
     // ‘checkstyle’ tool present in the framework and in the official
     // plugins.
-    tasks.checkstyleMain.maxErrors = 37101
+    tasks.checkstyleMain.maxErrors = 27599
     // Currently there are a lot of errors so we need to temporarily
     // hide them to avoid polluting the terminal output.
     showViolations = false
diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index 527945a..af7b1dc 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -22,7 +22,7 @@ under the License.
           "-//Checkstyle//DTD Checkstyle Configuration 1.3//EN"
           "https://checkstyle.org/dtds/configuration_1_3.dtd">
 <!-- This configuration corresponds to the OFBiz coding conventions
-     which are simply “Sun Coding Standards” + “120 characters line length” -->
+     which are simply “Sun Coding Standards” + “150 characters line length” -->
 <module name="Checker">
     <module name="BeforeExecutionExclusionFileFilter">
         <property name="fileNamePattern" value="module\-info\.java$"/>
@@ -40,9 +40,9 @@ under the License.
        <property name="maximum" value="0"/>
        <property name="message" value="Line has trailing spaces."/>
     </module>
-        <module name="LineLength">
-            <property name="max" value="120"/>
-        </module>
+    <module name="LineLength">
+        <property name="max" value="150"/>
+    </module>
 
     <module name="TreeWalker">
         <!-- Naming conventions -->