[ofbiz-framework] branch trunk updated: Improved: MethodLength checkstyle rule, earlier it was set as default to 150, as per discussion over ML changed it to 500 and also set countEmpty propety as false. (OFBIZ-11915) Thanks: Jacques for your thoughts and suggestions.

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ofbiz-framework] branch trunk updated: Improved: MethodLength checkstyle rule, earlier it was set as default to 150, as per discussion over ML changed it to 500 and also set countEmpty propety as false. (OFBIZ-11915) Thanks: Jacques for your thoughts and suggestions.

surajk
This is an automated email from the ASF dual-hosted git repository.

surajk pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 8f02800  Improved: MethodLength checkstyle rule, earlier it was set as default to 150, as per discussion over ML changed it to 500 and also set countEmpty propety as false. (OFBIZ-11915) Thanks: Jacques for your thoughts and suggestions.
8f02800 is described below

commit 8f02800414d758387c8a44e385c07c4b331ba03c
Author: Suraj Khurana <[hidden email]>
AuthorDate: Thu Aug 6 19:18:31 2020 +0530

    Improved: MethodLength checkstyle rule, earlier it was set as default to 150, as per discussion over ML changed it to 500 and also set countEmpty propety as false.
    (OFBIZ-11915)
    Thanks: Jacques for your thoughts and suggestions.
---
 config/checkstyle/checkstyle.xml | 6 +++++-
 1 file changed, 5 insertions(+), 1 deletion(-)

diff --git a/config/checkstyle/checkstyle.xml b/config/checkstyle/checkstyle.xml
index dd3bdb8..26d362e 100644
--- a/config/checkstyle/checkstyle.xml
+++ b/config/checkstyle/checkstyle.xml
@@ -65,7 +65,11 @@ under the License.
         </module>
 
         <!-- Checks for Size Violations -->
-        <module name="MethodLength"/>
+        <module name="MethodLength">
+            <property name="tokens" value="METHOD_DEF"/>
+            <property name="max" value="500"/>
+            <property name="countEmpty" value="false"/>
+        </module>
         <module name="ParameterNumber"/>
 
         <!-- Checks for whitespace -->