[ofbiz-framework] branch trunk updated: Improved: Remove createTopic service (unused) (OFBIZ-11376)

This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new d003807  Improved: Remove createTopic service (unused) (OFBIZ-11376)
d003807 is described below

commit d003807154442d5b40edbec88520a1df05760a91
Author: Jacques Le Roux <[hidden email]>
AuthorDate: Wed Feb 26 10:00:33 2020 +0100

    Improved: Remove createTopic service (unused)
    (OFBIZ-11376)
   
    I could not find any references for this service in the code base, i.e. this
    service has not been used anywhere, do we still want to keep it?
   
    Thanks: Devanshu Vyas for report, Priya Sharma for the proposition and the fix
---
 applications/content/minilang/content/ContentServices.xml | 14 --------------
 applications/content/servicedef/services.xml              | 11 -----------
 applications/content/widget/cms/CMSForms.xml              | 13 -------------
 3 files changed, 38 deletions(-)

diff --git a/applications/content/minilang/content/ContentServices.xml b/applications/content/minilang/content/ContentServices.xml
index 19f6628..a68324f 100644
--- a/applications/content/minilang/content/ContentServices.xml
+++ b/applications/content/minilang/content/ContentServices.xml
@@ -334,20 +334,6 @@
             <call-service service-name="updateElectronicText" in-map-name="updateSimpleText"/>
         </if-not-empty>
     </simple-method>
-    <simple-method method-name="createTopic" short-description="Create TOPIC type Content">
-        <make-value entity-name="Content" value-field="content"/>
-        <set from-field="parameters.newTopicId" field="content.contentId"/>
-        <set from-field="parameters.newTopicId" field="content.contentName"/>
-        <set from-field="parameters.newTopicDescription" field="content.description"/>
-        <set value="TOPIC" field="content.contentTypeId"/>
-
-        <now-timestamp field="content.lastModifiedDate"/>
-        <now-timestamp field="content.createdDate"/>
-        <set from-field="parameters.userLogin.userLoginId" field="content.lastModifiedByUserLogin"/>
-        <set from-field="parameters.userLogin.userLoginId" field="content.createdByUserLogin"/>
-
-        <create-value value-field="content"/>
-    </simple-method>
 
     <!-- This method will create a skeleton content record from a data resource -->
     <simple-method method-name="createContentFromDataResource" short-description="Create Content from DataResource Object">
diff --git a/applications/content/servicedef/services.xml b/applications/content/servicedef/services.xml
index 7b4392e..ccc8129 100644
--- a/applications/content/servicedef/services.xml
+++ b/applications/content/servicedef/services.xml
@@ -554,17 +554,6 @@
         <attribute mode="IN" name="subContentDataResourceView" optional="true" type="org.apache.ofbiz.entity.GenericValue"/>
         <attribute mode="OUT" name="textData" optional="true" type="String"/>
     </service>
-    <service name="createTopic"
-        auth="true" engine="simple" invoke="createTopic"
-        location="component://content/minilang/content/ContentServices.xml" >
-        <description>Create a TOPIC type Content </description>
-        <attribute mode="IN" name="newTopicId" optional="false" type="String">
-            <type-validate>
-                <fail-property resource="ContentErrorUiLabels" property="ContentRequiredFieldMissingNewTopicId"/>
-            </type-validate>
-        </attribute>
-        <attribute mode="IN" name="newTopicDescription" optional="true" type="String"/>
-    </service>
 
     <service name="updateSiteRoles" auth="true" engine="java"
             location="org.apache.ofbiz.content.ContentManagementServices" invoke="updateSiteRoles">
diff --git a/applications/content/widget/cms/CMSForms.xml b/applications/content/widget/cms/CMSForms.xml
index b667134..3ad6d89 100644
--- a/applications/content/widget/cms/CMSForms.xml
+++ b/applications/content/widget/cms/CMSForms.xml
@@ -126,19 +126,6 @@ under the License.
                 <list-options list-name="topicList" key-name="contentId"/>
             </drop-down>
         </field>
-        <!--
-        <field name="newTopicId" position="2">
-            <text size="12"/>
-        </field>
-        <field name="newTopicDescription" title="Description"  position="3">
-            <text size="24"/>
-        </field>
-        <field name="createTopic" title=" "  position="4">
-            <hyperlink also-hidden="false" target="createTopic${pageName}" description="Create Topic">
-                <parameter param-name="mode" value="restore"/>
-            </hyperlink>
-        </field>
-        -->
         <field name="submitButton" title="${uiLabelMap.CommonUpload}" widget-style="smallSubmit">
             <submit button-type="button"/>
         </field>