[ofbiz-framework] branch trunk updated: Improved: Resolve: TODO: Convert this to a <set-calendar> operation

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ofbiz-framework] branch trunk updated: Improved: Resolve: TODO: Convert this to a <set-calendar> operation

jleroux@apache.org
This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 4ac9ae0  Improved: Resolve: TODO: Convert this to a <set-calendar> operation
4ac9ae0 is described below

commit 4ac9ae097eebbbe9d894eb3f0d2959ec739999de
Author: Jacques Le Roux <[hidden email]>
AuthorDate: Sat Nov 30 09:02:17 2019 +0100

    Improved: Resolve: TODO: Convert this to a <set-calendar> operation
   
    (OFBIZ-11295)
   
    Because we want to migrate from Minilang to Groovy, rather than using
    <set-calendar> removes the TODO
   
    Thanks: Pawan for report
---
 .../product/minilang/product/inventory/InventoryReserveServices.xml    | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/applications/product/minilang/product/inventory/InventoryReserveServices.xml b/applications/product/minilang/product/inventory/InventoryReserveServices.xml
index 1f3a222..c111e38 100644
--- a/applications/product/minilang/product/inventory/InventoryReserveServices.xml
+++ b/applications/product/minilang/product/inventory/InventoryReserveServices.xml
@@ -193,7 +193,6 @@ under the License.
                                     </else>
                                 </if-not-empty>
                             </if-empty>
-                            <!-- TODO: Convert this to a <set-calendar> operation -->
                             <script>groovy:
                             java.sql.Timestamp orderDate = orderHeader.getTimestamp("orderDate")
                             com.ibm.icu.util.Calendar cal = com.ibm.icu.util.Calendar.getInstance()
@@ -261,7 +260,6 @@ under the License.
                                     </else>
                                 </if-not-empty>
                             </if-empty>
-                            <!-- TODO: Convert this to a <set-calendar> operation -->
                             <script>groovy:
                             java.sql.Timestamp orderDate = orderHeader.getTimestamp("orderDate")
                             com.ibm.icu.util.Calendar cal = com.ibm.icu.util.Calendar.getInstance()
@@ -503,7 +501,6 @@ under the License.
         <if-empty field="daysToShip">
             <set field="daysToShip" value="30" type="Long"/>
         </if-empty>
-        <!-- TODO: Convert this to a <set-calendar> operation -->
         <script>groovy:
         java.sql.Timestamp orderDate = orderHeader.getTimestamp("orderDate")
         com.ibm.icu.util.Calendar cal = com.ibm.icu.util.Calendar.getInstance()