[ofbiz-framework] branch trunk updated: Improved: View entity definition for MarketingCampaignAndVisit and made relational optional as false. (OFBIZ-9909)

[surajk]

This is an automated email from the ASF dual-hosted git repository.

surajk pushed a commit to branch trunk
in repository https://gitbox.apache.org/repos/asf/ofbiz-framework.git


The following commit(s) were added to refs/heads/trunk by this push:
     new 13ea2ba  Improved: View entity definition for MarketingCampaignAndVisit and made relational optional as false. (OFBIZ-9909)
13ea2ba is described below

commit 13ea2ba7269f840b8c12243e78d1e997afc3425e
Author: Suraj Khurana <[hidden email]>
AuthorDate: Sun Apr 26 20:10:08 2020 +0530

    Improved: View entity definition for MarketingCampaignAndVisit and made relational optional as false.
    (OFBIZ-9909)
   
    This will generate the report with positive visits only in both the cases (with/without date filter) while running marketing campaign reports.
   
    Thanks Rubia for reporting and Ankit Joshi for providing the patch.
---
 applications/datamodel/entitydef/marketing-entitymodel.xml | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/applications/datamodel/entitydef/marketing-entitymodel.xml b/applications/datamodel/entitydef/marketing-entitymodel.xml
index 976f7ee..3b3f798 100644
--- a/applications/datamodel/entitydef/marketing-entitymodel.xml
+++ b/applications/datamodel/entitydef/marketing-entitymodel.xml
@@ -632,7 +632,7 @@ under the License.
         <alias entity-alias="TC" name="marketingCampaignId" group-by="true"/>
         <alias entity-alias="TCV" name="visitId" function="count"/>
         <alias entity-alias="TCV" name="fromDate" group-by="false"/>
-        <view-link entity-alias="TC" rel-entity-alias="TCV" rel-optional="true">
+        <view-link entity-alias="TC" rel-entity-alias="TCV" rel-optional="false">
             <key-map field-name="trackingCodeId"/>
         </view-link>
     </view-entity>