[ofbiz-plugins] branch release17.12 updated: Fixed: processorder is submitted as GET instead of POST

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ofbiz-plugins] branch release17.12 updated: Fixed: processorder is submitted as GET instead of POST

James Yong-2
This is an automated email from the ASF dual-hosted git repository.

jamesyong pushed a commit to branch release17.12
in repository https://gitbox.apache.org/repos/asf/ofbiz-plugins.git


The following commit(s) were added to refs/heads/release17.12 by this push:
     new a183733  Fixed: processorder is submitted as GET instead of POST
a183733 is described below

commit a183733775b82b2f853b16420328d87847d37744
Author: James Yong <[hidden email]>
AuthorDate: Mon Jan 13 22:31:10 2020 +0800

    Fixed: processorder is submitted as GET instead of POST
   
    (OFBIZ-11319)
   
    During checkout of shopping cart, it is observed that the processorder of the form action is submitted as GET which is incorrect.
   
    Thanks: Jacques for the review
---
 ecommerce/template/order/CheckoutReview.ftl          | 2 +-
 ecommerce/template/order/QuickAnonCheckoutReview.ftl | 2 +-
 2 files changed, 2 insertions(+), 2 deletions(-)

diff --git a/ecommerce/template/order/CheckoutReview.ftl b/ecommerce/template/order/CheckoutReview.ftl
index fef8f83..b0334dd 100644
--- a/ecommerce/template/order/CheckoutReview.ftl
+++ b/ecommerce/template/order/CheckoutReview.ftl
@@ -45,7 +45,7 @@ under the License.
   ${screens.render("component://ecommerce/widget/OrderScreens.xml#orderitems")}
   <div class="row">
     <div class="col-auto ml-auto">
-      <form type="post" action="<@ofbizUrl>processorder</@ofbizUrl>" name="${parameters.formNameValue}">
+      <form method="post" action="<@ofbizUrl>processorder</@ofbizUrl>" name="${parameters.formNameValue}">
         <#if (requestParameters.checkoutpage)?has_content>
           <input type="hidden" name="checkoutpage" value="${requestParameters.checkoutpage}"/>
         </#if>
diff --git a/ecommerce/template/order/QuickAnonCheckoutReview.ftl b/ecommerce/template/order/QuickAnonCheckoutReview.ftl
index ffa36e2..18aba7e 100644
--- a/ecommerce/template/order/QuickAnonCheckoutReview.ftl
+++ b/ecommerce/template/order/QuickAnonCheckoutReview.ftl
@@ -53,7 +53,7 @@ under the License.
   ${screens.render("component://ecommerce/widget/OrderScreens.xml#quickAnonOrderHeader")}
   <br />
   <div id="orderItemsSection">${screens.render("component://ecommerce/widget/OrderScreens.xml#orderitems")}</div>
-<form type="post" action="<@ofbizUrl>processorder</@ofbizUrl>" name="${parameters.formNameValue}">
+<form method="post" action="<@ofbizUrl>processorder</@ofbizUrl>" name="${parameters.formNameValue}">
   <table border="0" cellpadding="1" width="100%">
    <tr>
       <td colspan="4">