[ofbiz-tools] branch master updated: Improved: no functional change

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

[ofbiz-tools] branch master updated: Improved: no functional change

jleroux@apache.org
This is an automated email from the ASF dual-hosted git repository.

jleroux pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/ofbiz-tools.git


The following commit(s) were added to refs/heads/master by this push:
     new ec39899  Improved: no functional change
ec39899 is described below

commit ec39899b051dad8f199105fed1d9efc1e2ba2a2c
Author: Jacques Le Roux <[hidden email]>
AuthorDate: Sun Nov 10 14:46:18 2019 +0100

    Improved: no functional change
   
    Adds new Rat detected issues which are not
   
    .sonarcloud.properties is used to run sonar, see OFBIZ-10917
   
    As discussed previously with Mathieu on dev ML change the location of  meta-data
    files that are maintained manually. They are distributed inside the JAR to allow
    the  â€˜ServiceLoader’ API [1] to find the classes implementing a particular
    interface (corresponding to the file name) efficiently.
    [1]https://docs.oracle.com/javase/8/docs/api/java/util/ServiceLoader.html
   
    I spotted this with RAT, for base.util.test.UtilObjectTests$TestFactoryIntf
    The other same files have ASL2 headers, I decided to not change that.
   
    I wonder if my previous commit about
    **/framework/base/src/main/resources/META-INF/**
    was right. I was unable to test then because Buildbot was unavailable.
    I replace it by
    **/framework/base/src/test/resources/META-INF/**
---
 rat-excludes.txt | 3 ++-
 1 file changed, 2 insertions(+), 1 deletion(-)

diff --git a/rat-excludes.txt b/rat-excludes.txt
index 537327a..c7b318b 100644
--- a/rat-excludes.txt
+++ b/rat-excludes.txt
@@ -39,6 +39,7 @@ VERSION
 
 .*gitignore
 .*hgignore
+.sonarcloud.properties
 **/*.md
 **/*.adoc
 **/robots.txt
@@ -64,6 +65,6 @@ VERSION
 **/themes/rainbowstone/webapp/rainbowstone/*.less
 **/less.min.js
 **/SamplePricatTemplate_V1.1.xlsx
-**/framework/base/src/main/resources/META-INF/**
+**/framework/base/src/test/resources/META-INF/**
 **/.gradle/**
 **/gradle/wrapper/**