ofbizUrl not transform "&" correctly
Locked
ofbizUrl not transform "&" correctly
 
|
Re: ofbizUrl not transform "&" correctly
|
|
Hi Deepak,
I'm not seeing any issues on my end, here's a sample url: // edit eft account form.action="/ordermgr/control/updateCheckoutOptions/editeftaccount?DONE_PAGE=quickcheckout&partyId=DemoCustomer&paymentMethodId="+value+""; form.submit(); Regards Scott HotWax Media http://www.hotwaxmedia.com On 13/07/2010, at 6:17 PM, Deepak Dixit wrote: > > Hello All, > > ofbizUrl is failed to parse xml character & correctly, i.e. If we pass &partyId in <@ofbizUrl>...</@ofbizUrl>, then it can't parse correctly and it will available in parameters in following form : amp;partyId that is not correct, and it will break the process. > for reference : order/webapp/ordermgr/entry/checkoutoptions.ftl > > quickfinalizeOrder process is broken if we are going for add new address, it will show error on console due to specified problem. > > Regards > -- > Deepak Dixit > HotWax Media Pvt. Ltd. > Website :- www.hotwaxmedia.com > Contact :- +91-98267-54548 > Skype Id :- deepakdixit > |
smime.p7s (3K)
Re: ofbizUrl not transform "&" correctly
|
|
Re: ofbizUrl not transform "&" correctly
|
|
Okay I see what you mean. It looks like the url strings shouldn't have any encoding because they are being used inside javascript and xhtml. Simply changing & characters to & seems to solve the problem.
Regards Scott On 13/07/2010, at 9:51 PM, Deepak Dixit wrote: > Hello Scott, > > Have you saw console for error log, I have done some debugging, > Here are steps to regenerate issue : > - Go to ordermgr. > - Select "Order Entry" Tab. > - Click on continue, again click on continue for "Enter Order Currency, Agreements, and Ship Dates" screen. > - Add any product. > - Select "Quick finalize Order", It will redirect to "Quick Finalize Order" page. > - On "Quick Finalize Order" page select new address button for "Where shall we ship it?" section. > > It will redirect to "Create New Contact Information", but at the same time see console for error message, here is the error : > > > Expression partyId is undefined on line 24, column 52 in component://party/webapp/partymgr/party/editcontactmech.ftl. > The problematic instruction: > ---------- > ==> ${partyId} [on line 24, column 50 in component://party/webapp/partymgr/party/editcontactmech.ftl] > ---------- > > Java backtrace for programmers: > ---------- > freemarker.core.InvalidReferenceException: Expression partyId is undefined on line 24, column 52 in component://party/webapp/partymgr/party/editcontactmech.ftl. > at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) > at freemarker.core.Expression.getStringValue(Expression.java:118) > at freemarker.core.Expression.getStringValue(Expression.java:93) > at freemarker.core.DollarVariable.accept(DollarVariable.java:76) > at freemarker.core.Environment.visit(Environment.java:209) > at freemarker.core.MixedContent.accept(MixedContent.java:92) > > > > This is occured because partyId is null, partyId set from "EditContactMech.groovy" and here parameters.partyId is null. > I have print the parametes map on EditContactMech.groovy and here is the log for that : > > > > =========parameters===================[DONE_PAGE:quickcheckout, order_additional_emails:, checkoutpage:quick, shipping_instructions:, may_split:false, *amp;partyId:*admin, is_gift:false, shipping_method:Default,* amp;preContactMechTypeId:*POSTAL_ADDRESS, BACK_PAGE:quickcheckout, *amp;contactMechPurposeTypeId:*SHIPPING_LOCATION, shipToCustomerPartyId:admin, gift_message:, localDispatcherName:order, org.apache.catalina.WELCOME_FILES:[index.jsp, index.html, index.htm], javax.servlet.context.tempdir:/home/deepak/ofbiz_dev/plain-ofbiz/runtime/catalina/work/default-server/0.0.0.0/ > > > > The parameters that we passed via ofbizUrl is not in correct form. > > > Thanks & Regards > -- > Deepak Dixit > > > Scott Gray wrote: >> Hi Deepak, >> >> I'm not seeing any issues on my end, here's a sample url: >> // edit eft account >> form.action="/ordermgr/control/updateCheckoutOptions/editeftaccount?DONE_PAGE=quickcheckout&partyId=DemoCustomer&paymentMethodId="+value+""; >> form.submit(); >> >> Regards >> Scott >> >> HotWax Media >> http://www.hotwaxmedia.com >> >> On 13/07/2010, at 6:17 PM, Deepak Dixit wrote: >> >> >>> Hello All, >>> >>> ofbizUrl is failed to parse xml character & correctly, i.e. If we pass &partyId in <@ofbizUrl>...</@ofbizUrl>, then it can't parse correctly and it will available in parameters in following form : amp;partyId that is not correct, and it will break the process. >>> for reference : order/webapp/ordermgr/entry/checkoutoptions.ftl >>> >>> quickfinalizeOrder process is broken if we are going for add new address, it will show error on console due to specified problem. >>> >>> Regards >>> -- >>> Deepak Dixit >>> HotWax Media Pvt. Ltd. >>> Website :- www.hotwaxmedia.com >>> Contact :- +91-98267-54548 >>> Skype Id :- deepakdixit >>> >>> >> >> > > |
Re: ofbizUrl not transform "&" correctly
|
|
I meant: being used inside javascript and *not* xhtml. sigh.
Regards Scott On 13/07/2010, at 10:02 PM, Scott Gray wrote: > Okay I see what you mean. It looks like the url strings shouldn't have any encoding because they are being used inside javascript and xhtml. Simply changing & characters to & seems to solve the problem. > > Regards > Scott > > On 13/07/2010, at 9:51 PM, Deepak Dixit wrote: > >> Hello Scott, >> >> Have you saw console for error log, I have done some debugging, >> Here are steps to regenerate issue : >> - Go to ordermgr. >> - Select "Order Entry" Tab. >> - Click on continue, again click on continue for "Enter Order Currency, Agreements, and Ship Dates" screen. >> - Add any product. >> - Select "Quick finalize Order", It will redirect to "Quick Finalize Order" page. >> - On "Quick Finalize Order" page select new address button for "Where shall we ship it?" section. >> >> It will redirect to "Create New Contact Information", but at the same time see console for error message, here is the error : >> >> >> Expression partyId is undefined on line 24, column 52 in component://party/webapp/partymgr/party/editcontactmech.ftl. >> The problematic instruction: >> ---------- >> ==> ${partyId} [on line 24, column 50 in component://party/webapp/partymgr/party/editcontactmech.ftl] >> ---------- >> >> Java backtrace for programmers: >> ---------- >> freemarker.core.InvalidReferenceException: Expression partyId is undefined on line 24, column 52 in component://party/webapp/partymgr/party/editcontactmech.ftl. >> at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) >> at freemarker.core.Expression.getStringValue(Expression.java:118) >> at freemarker.core.Expression.getStringValue(Expression.java:93) >> at freemarker.core.DollarVariable.accept(DollarVariable.java:76) >> at freemarker.core.Environment.visit(Environment.java:209) >> at freemarker.core.MixedContent.accept(MixedContent.java:92) >> >> >> >> This is occured because partyId is null, partyId set from "EditContactMech.groovy" and here parameters.partyId is null. >> I have print the parametes map on EditContactMech.groovy and here is the log for that : >> >> >> >> =========parameters===================[DONE_PAGE:quickcheckout, order_additional_emails:, checkoutpage:quick, shipping_instructions:, may_split:false, *amp;partyId:*admin, is_gift:false, shipping_method:Default,* amp;preContactMechTypeId:*POSTAL_ADDRESS, BACK_PAGE:quickcheckout, *amp;contactMechPurposeTypeId:*SHIPPING_LOCATION, shipToCustomerPartyId:admin, gift_message:, localDispatcherName:order, org.apache.catalina.WELCOME_FILES:[index.jsp, index.html, index.htm], javax.servlet.context.tempdir:/home/deepak/ofbiz_dev/plain-ofbiz/runtime/catalina/work/default-server/0.0.0.0/ >> >> >> >> The parameters that we passed via ofbizUrl is not in correct form. >> >> >> Thanks & Regards >> -- >> Deepak Dixit >> >> >> Scott Gray wrote: >>> Hi Deepak, >>> >>> I'm not seeing any issues on my end, here's a sample url: >>> // edit eft account >>> form.action="/ordermgr/control/updateCheckoutOptions/editeftaccount?DONE_PAGE=quickcheckout&partyId=DemoCustomer&paymentMethodId="+value+""; >>> form.submit(); >>> >>> Regards >>> Scott >>> >>> HotWax Media >>> http://www.hotwaxmedia.com >>> >>> On 13/07/2010, at 6:17 PM, Deepak Dixit wrote: >>> >>> >>>> Hello All, >>>> >>>> ofbizUrl is failed to parse xml character & correctly, i.e. If we pass &partyId in <@ofbizUrl>...</@ofbizUrl>, then it can't parse correctly and it will available in parameters in following form : amp;partyId that is not correct, and it will break the process. >>>> for reference : order/webapp/ordermgr/entry/checkoutoptions.ftl >>>> >>>> quickfinalizeOrder process is broken if we are going for add new address, it will show error on console due to specified problem. >>>> >>>> Regards >>>> -- >>>> Deepak Dixit >>>> HotWax Media Pvt. Ltd. >>>> Website :- www.hotwaxmedia.com >>>> Contact :- +91-98267-54548 >>>> Skype Id :- deepakdixit >>>> >>>> >>> >>> >> >> > |
Re: ofbizUrl not transform "&" correctly
|
|
Re: ofbizUrl not transform "&" correctly
|
|
Just wrap the javascript using the CDATA thing and it should pass validation just fine.
Regards Scott On 13/07/2010, at 10:28 PM, Deepak Dixit wrote: > > But does this passes the XHTML validation ? I don't think so. > > Currently functionality is broken so can I provide a patch for these changes and I think that changes does not passes the XHTML validation. > > > > Thanks & Regards > -- > Deepak Dixit > > > Scott Gray wrote: >> I meant: being used inside javascript and *not* xhtml. sigh. >> >> Regards >> Scott >> >> On 13/07/2010, at 10:02 PM, Scott Gray wrote: >> >> >>> Okay I see what you mean. It looks like the url strings shouldn't have any encoding because they are being used inside javascript and xhtml. Simply changing & characters to & seems to solve the problem. >>> >>> Regards >>> Scott >>> >>> On 13/07/2010, at 9:51 PM, Deepak Dixit wrote: >>> >>> >>>> Hello Scott, >>>> >>>> Have you saw console for error log, I have done some debugging, >>>> Here are steps to regenerate issue : >>>> - Go to ordermgr. >>>> - Select "Order Entry" Tab. >>>> - Click on continue, again click on continue for "Enter Order Currency, Agreements, and Ship Dates" screen. >>>> - Add any product. >>>> - Select "Quick finalize Order", It will redirect to "Quick Finalize Order" page. >>>> - On "Quick Finalize Order" page select new address button for "Where shall we ship it?" section. >>>> >>>> It will redirect to "Create New Contact Information", but at the same time see console for error message, here is the error : >>>> >>>> >>>> Expression partyId is undefined on line 24, column 52 in component://party/webapp/partymgr/party/editcontactmech.ftl. >>>> The problematic instruction: >>>> ---------- >>>> ==> ${partyId} [on line 24, column 50 in component://party/webapp/partymgr/party/editcontactmech.ftl] >>>> ---------- >>>> >>>> Java backtrace for programmers: >>>> ---------- >>>> freemarker.core.InvalidReferenceException: Expression partyId is undefined on line 24, column 52 in component://party/webapp/partymgr/party/editcontactmech.ftl. >>>> at freemarker.core.TemplateObject.assertNonNull(TemplateObject.java:124) >>>> at freemarker.core.Expression.getStringValue(Expression.java:118) >>>> at freemarker.core.Expression.getStringValue(Expression.java:93) >>>> at freemarker.core.DollarVariable.accept(DollarVariable.java:76) >>>> at freemarker.core.Environment.visit(Environment.java:209) >>>> at freemarker.core.MixedContent.accept(MixedContent.java:92) >>>> >>>> >>>> >>>> This is occured because partyId is null, partyId set from "EditContactMech.groovy" and here parameters.partyId is null. >>>> I have print the parametes map on EditContactMech.groovy and here is the log for that : >>>> >>>> >>>> >>>> =========parameters===================[DONE_PAGE:quickcheckout, order_additional_emails:, checkoutpage:quick, shipping_instructions:, may_split:false, *amp;partyId:*admin, is_gift:false, shipping_method:Default,* amp;preContactMechTypeId:*POSTAL_ADDRESS, BACK_PAGE:quickcheckout, *amp;contactMechPurposeTypeId:*SHIPPING_LOCATION, shipToCustomerPartyId:admin, gift_message:, localDispatcherName:order, org.apache.catalina.WELCOME_FILES:[index.jsp, index.html, index.htm], javax.servlet.context.tempdir:/home/deepak/ofbiz_dev/plain-ofbiz/runtime/catalina/work/default-server/0.0.0.0/ >>>> >>>> >>>> >>>> The parameters that we passed via ofbizUrl is not in correct form. >>>> >>>> >>>> Thanks & Regards >>>> -- >>>> Deepak Dixit >>>> >>>> >>>> Scott Gray wrote: >>>> >>>>> Hi Deepak, >>>>> >>>>> I'm not seeing any issues on my end, here's a sample url: >>>>> // edit eft account >>>>> form.action="/ordermgr/control/updateCheckoutOptions/editeftaccount?DONE_PAGE=quickcheckout&partyId=DemoCustomer&paymentMethodId="+value+""; >>>>> form.submit(); >>>>> >>>>> Regards >>>>> Scott >>>>> >>>>> HotWax Media >>>>> http://www.hotwaxmedia.com >>>>> >>>>> On 13/07/2010, at 6:17 PM, Deepak Dixit wrote: >>>>> >>>>> >>>>> >>>>>> Hello All, >>>>>> >>>>>> ofbizUrl is failed to parse xml character & correctly, i.e. If we pass &partyId in <@ofbizUrl>...</@ofbizUrl>, then it can't parse correctly and it will available in parameters in following form : amp;partyId that is not correct, and it will break the process. >>>>>> for reference : order/webapp/ordermgr/entry/checkoutoptions.ftl >>>>>> >>>>>> quickfinalizeOrder process is broken if we are going for add new address, it will show error on console due to specified problem. >>>>>> >>>>>> Regards >>>>>> -- >>>>>> Deepak Dixit >>>>>> HotWax Media Pvt. Ltd. >>>>>> Website :- www.hotwaxmedia.com >>>>>> Contact :- +91-98267-54548 >>>>>> Skype Id :- deepakdixit >>>>>> >>>>>> >>>>>> >>>>> >>>> >> >> > |
Re: ofbizUrl not transform "&" correctly
|
|
| Free forum by Nabble | Edit this page |