payment/invoice demo data file in accounting component

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
9 messages Options
Reply | Threaded
Open this post in threaded view
|

payment/invoice demo data file in accounting component

Jacopo Cappellato
Do we really need this demo data file?

http://svn.apache.org/repos/asf/ofbiz/trunk/applications/accounting/data/PaymentsInvoices.xml

It contains demo data for payments and invoices and I'm not sure how
this data should be used; most of all, there are a few errors in the
data (missing InvoiceItem.productId, wrong InvoiceItem.invoiceItemTypeId
and wrong value for the InvoiceItem.uomId field).

What if we just remove this file?

Jacopo
Reply | Threaded
Open this post in threaded view
|

Re: payment/invoice demo data file in accounting component

hans_bakker
The reason it is in, to have some data in the files and not start empty
and show the application feature.

The invoice.uomId and ItemTypeId was changed after the creation, and the
productId can be empty.

Perhaps update the demo data?

Regards,
Hans

On Sat, 2007-10-13 at 08:10 +0200, Jacopo Cappellato wrote:

> Do we really need this demo data file?
>
> http://svn.apache.org/repos/asf/ofbiz/trunk/applications/accounting/data/PaymentsInvoices.xml
>
> It contains demo data for payments and invoices and I'm not sure how
> this data should be used; most of all, there are a few errors in the
> data (missing InvoiceItem.productId, wrong InvoiceItem.invoiceItemTypeId
> and wrong value for the InvoiceItem.uomId field).
>
> What if we just remove this file?
>
> Jacopo
>
--
http://Antwebsystems.com : OFBiz Quality support for competitive rates.



Reply | Threaded
Open this post in threaded view
|

Re: payment/invoice demo data file in accounting component

Jacopo Cappellato
Hans Bakker wrote:
> The reason it is in, to have some data in the files and not start empty
> and show the application feature.
>

If you create an order and quick ship it you'll get a much better result
(with a few clicks).

> The invoice.uomId and ItemTypeId was changed after the creation, and the
> productId can be empty.
>
> Perhaps update the demo data?
>

In my opinion, this is the real problem: no one is maintaining this demo
data (the changes you refer to probably happened a few months ago) and
so, in my opinion, if they are there just to save a few mouse clicks
before (or during) a demo, we should remove them.

Jacopo

> Regards,
> Hans
>
> On Sat, 2007-10-13 at 08:10 +0200, Jacopo Cappellato wrote:
>> Do we really need this demo data file?
>>
>> http://svn.apache.org/repos/asf/ofbiz/trunk/applications/accounting/data/PaymentsInvoices.xml
>>
>> It contains demo data for payments and invoices and I'm not sure how
>> this data should be used; most of all, there are a few errors in the
>> data (missing InvoiceItem.productId, wrong InvoiceItem.invoiceItemTypeId
>> and wrong value for the InvoiceItem.uomId field).
>>
>> What if we just remove this file?
>>
>> Jacopo
>>

Reply | Threaded
Open this post in threaded view
|

Re: payment/invoice demo data file in accounting component

hans_bakker
But on a demo system where you can not update?
Now you can see an invoice, you show a pdf etc....

On Sat, 2007-10-13 at 09:16 +0200, Jacopo Cappellato wrote:

> Hans Bakker wrote:
> > The reason it is in, to have some data in the files and not start empty
> > and show the application feature.
> >
>
> If you create an order and quick ship it you'll get a much better result
> (with a few clicks).
>
> > The invoice.uomId and ItemTypeId was changed after the creation, and the
> > productId can be empty.
> >
> > Perhaps update the demo data?
> >
>
> In my opinion, this is the real problem: no one is maintaining this demo
> data (the changes you refer to probably happened a few months ago) and
> so, in my opinion, if they are there just to save a few mouse clicks
> before (or during) a demo, we should remove them.
>
> Jacopo
>
> > Regards,
> > Hans
> >
> > On Sat, 2007-10-13 at 08:10 +0200, Jacopo Cappellato wrote:
> >> Do we really need this demo data file?
> >>
> >> http://svn.apache.org/repos/asf/ofbiz/trunk/applications/accounting/data/PaymentsInvoices.xml
> >>
> >> It contains demo data for payments and invoices and I'm not sure how
> >> this data should be used; most of all, there are a few errors in the
> >> data (missing InvoiceItem.productId, wrong InvoiceItem.invoiceItemTypeId
> >> and wrong value for the InvoiceItem.uomId field).
> >>
> >> What if we just remove this file?
> >>
> >> Jacopo
> >>
>
>
--
http://Antwebsystems.com : OFBiz Quality support for competitive rates.



Reply | Threaded
Open this post in threaded view
|

Re: payment/invoice demo data file in accounting component

David E Jones

What would be nice here is a little automated unit test to do this,  
and it should be pretty easy.

We have a number of nice tools to do service level testing. There are  
some complicated examples in the service engine that are written java  
because we needed more exception and transaction control (they test  
funky stuff...), but in most cases using simple-methods and what what  
is easier.

With this you could run the test for a specific component to get the  
data in quickly, or even have tests that generate the PDFs or  
whatever and dump it to a file so you can test/review even more quickly.

Better than maintaining data that the system normally generates  
manually (which isn't working so well...), and better than manually  
running stuff to generate the data.

-David


On Oct 13, 2007, at 4:17 AM, Hans Bakker wrote:

> But on a demo system where you can not update?
> Now you can see an invoice, you show a pdf etc....
>
> On Sat, 2007-10-13 at 09:16 +0200, Jacopo Cappellato wrote:
>> Hans Bakker wrote:
>>> The reason it is in, to have some data in the files and not start  
>>> empty
>>> and show the application feature.
>>>
>>
>> If you create an order and quick ship it you'll get a much better  
>> result
>> (with a few clicks).
>>
>>> The invoice.uomId and ItemTypeId was changed after the creation,  
>>> and the
>>> productId can be empty.
>>>
>>> Perhaps update the demo data?
>>>
>>
>> In my opinion, this is the real problem: no one is maintaining  
>> this demo
>> data (the changes you refer to probably happened a few months ago)  
>> and
>> so, in my opinion, if they are there just to save a few mouse clicks
>> before (or during) a demo, we should remove them.
>>
>> Jacopo
>>
>>> Regards,
>>> Hans
>>>
>>> On Sat, 2007-10-13 at 08:10 +0200, Jacopo Cappellato wrote:
>>>> Do we really need this demo data file?
>>>>
>>>> http://svn.apache.org/repos/asf/ofbiz/trunk/applications/ 
>>>> accounting/data/PaymentsInvoices.xml
>>>>
>>>> It contains demo data for payments and invoices and I'm not sure  
>>>> how
>>>> this data should be used; most of all, there are a few errors in  
>>>> the
>>>> data (missing InvoiceItem.productId, wrong  
>>>> InvoiceItem.invoiceItemTypeId
>>>> and wrong value for the InvoiceItem.uomId field).
>>>>
>>>> What if we just remove this file?
>>>>
>>>> Jacopo
>>>>
>>
>>
> --
> http://Antwebsystems.com : OFBiz Quality support for competitive  
> rates.
>
>
>


smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: payment/invoice demo data file in accounting component

Christian Geisert
In reply to this post by Jacopo Cappellato
Jacopo Cappellato schrieb:
> Hans Bakker wrote:

>> Perhaps update the demo data?
>>
> In my opinion, this is the real problem: no one is maintaining this demo
> data (the changes you refer to probably happened a few months ago) and
> so, in my opinion, if they are there just to save a few mouse clicks
> before (or during) a demo, we should remove them.

I think the demo data is a good help for learning OFBiz.
I'll try to help here to correct/update the data.

--
Christian
Reply | Threaded
Open this post in threaded view
|

Re: payment/invoice demo data file in accounting component

Jacques Le Roux
Administrator
Yes, I agree. Demo data really help when you want to understand a point. Even when a bit outdated...

+1

Jacques

De : "Christian Geisert" <[hidden email]>


> Jacopo Cappellato schrieb:
> > Hans Bakker wrote:
>
> >> Perhaps update the demo data?
> >>
> > In my opinion, this is the real problem: no one is maintaining this demo
> > data (the changes you refer to probably happened a few months ago) and
> > so, in my opinion, if they are there just to save a few mouse clicks
> > before (or during) a demo, we should remove them.
>
> I think the demo data is a good help for learning OFBiz.
> I'll try to help here to correct/update the data.
>
> --
> Christian
>
Reply | Threaded
Open this post in threaded view
|

Re: payment/invoice demo data file in accounting component

David E Jones

True, but readable test cases are even more useful, IMO.

-David


On Oct 15, 2007, at 1:29 PM, Jacques Le Roux wrote:

> Yes, I agree. Demo data really help when you want to understand a  
> point. Even when a bit outdated...
>
> +1
>
> Jacques
>
> De : "Christian Geisert" <[hidden email]>
>
>
>> Jacopo Cappellato schrieb:
>>> Hans Bakker wrote:
>>
>>>> Perhaps update the demo data?
>>>>
>>> In my opinion, this is the real problem: no one is maintaining  
>>> this demo
>>> data (the changes you refer to probably happened a few months  
>>> ago) and
>>> so, in my opinion, if they are there just to save a few mouse clicks
>>> before (or during) a demo, we should remove them.
>>
>> I think the demo data is a good help for learning OFBiz.
>> I'll try to help here to correct/update the data.
>>
>> --
>> Christian
>>


smime.p7s (3K) Download Attachment
Reply | Threaded
Open this post in threaded view
|

Re: payment/invoice demo data file in accounting component

Jacques Le Roux
Administrator
Yes sure, if somebody has the time would be better. Maybe a Jira issue could be created to keep the idea and related elements ...

Jacques

De : "David E Jones" <[hidden email]>


>
> True, but readable test cases are even more useful, IMO.
>
> -David
>
>
> On Oct 15, 2007, at 1:29 PM, Jacques Le Roux wrote:
>
> > Yes, I agree. Demo data really help when you want to understand a  
> > point. Even when a bit outdated...
> >
> > +1
> >
> > Jacques
> >
> > De : "Christian Geisert" <[hidden email]>
> >
> >
> >> Jacopo Cappellato schrieb:
> >>> Hans Bakker wrote:
> >>
> >>>> Perhaps update the demo data?
> >>>>
> >>> In my opinion, this is the real problem: no one is maintaining  
> >>> this demo
> >>> data (the changes you refer to probably happened a few months  
> >>> ago) and
> >>> so, in my opinion, if they are there just to save a few mouse clicks
> >>> before (or during) a demo, we should remove them.
> >>
> >> I think the demo data is a good help for learning OFBiz.
> >> I'll try to help here to correct/update the data.
> >>
> >> --
> >> Christian
> >>
>
>