paypalevents.java logic bug getPaymentGatewayConfigValue()

[BJ Freeman]

for those that have not installed the entity paymentGateway and still
use the payment.properties

the logic to select which one needs an new statement in the method
getPaymentGatewayConfigValue()
from
        if (UtilValidate.isNotEmpty(paymentGatewayConfigId)) {

to
        if (UtilValidate.isNotEmpty(paymentGatewayConfigId)&&(resource
!="payment.properties")) {

I am still preparing a patch this would be included in, that will not be
submitted for a few weeks.

this is just a heads up if you having problems.



--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.

[Scott Gray-2]

Looks to me as though it will work fine so long as your  
ProductStorePaymentSetting for EXT_PAYPAL doesn't have a  
paymentGatewayConfigId set.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 18/06/2009, at 8:39 AM, BJ Freeman wrote:

> for those that have not installed the entity paymentGateway and still
> use the payment.properties
>
> the logic to select which one needs an new statement in the method
> getPaymentGatewayConfigValue()
> from
>        if (UtilValidate.isNotEmpty(paymentGatewayConfigId)) {
>
> to
>        if (UtilValidate.isNotEmpty(paymentGatewayConfigId)&&(resource
> !="payment.properties")) {
>
> I am still preparing a patch this would be included in, that will  
> not be
> submitted for a few weeks.
>
> this is just a heads up if you having problems.
>
>
>
> --
> BJ Freeman
> http://www.businessesnetwork.com/automation
> http://bjfreeman.elance.com
> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
> Systems Integrator.
>

[BJ Freeman]

 I have not dug into this but here is what happens
       if (paymentConfig != null) {
            paymentGatewayConfigId =
paymentConfig.getString("paymentGatewayConfigId");
            configString = paymentConfig.getString("paymentPropertiesPath");
            Debug.logInfo("using paymentConfig", module);
        }

paymentGatewayConfigId !=null
configString = null

so
       if (configString == null) {
            configString = "payment.properties";
            Debug.logInfo("using payment.properties", module);
       }

sets the configString =="using payment.properties"

so when you get to getPaymentGatewayConfigValue()
it will try to read the db config instead of the payment properties.


Scott Gray sent the following on 6/17/2009 3:52 PM:

> Looks to me as though it will work fine so long as your
> ProductStorePaymentSetting for EXT_PAYPAL doesn't have a
> paymentGatewayConfigId set.
>
> Regards
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 18/06/2009, at 8:39 AM, BJ Freeman wrote:
>
>> for those that have not installed the entity paymentGateway and still
>> use the payment.properties
>>
>> the logic to select which one needs an new statement in the method
>> getPaymentGatewayConfigValue()
>> from
>>        if (UtilValidate.isNotEmpty(paymentGatewayConfigId)) {
>>
>> to
>>        if (UtilValidate.isNotEmpty(paymentGatewayConfigId)&&(resource
>> !="payment.properties")) {
>>
>> I am still preparing a patch this would be included in, that will not be
>> submitted for a few weeks.
>>
>> this is just a heads up if you having problems.
>>
>>
>>
>> --
>> BJ Freeman
>> http://www.businessesnetwork.com/automation
>> http://bjfreeman.elance.com
>> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
>>
>> Systems Integrator.
>>
>

--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.

[Scott Gray-2]

The PaymentGatewayConfig takes precedence over payment.properties so  
if a paymentGatewayConfigId is set on your ProductStorePaymentSetting  
then that is what will be used regardless of the value of the  
paymentPropertiesPath.

Like I said in my last email if you want payment/properties to be used  
then set the paymentGatewayConfigId to null.

Regards
Scott

HotWax Media
http://www.hotwaxmedia.com

On 18/06/2009, at 9:17 AM, BJ Freeman wrote:

> I have not dug into this but here is what happens
>       if (paymentConfig != null) {
>            paymentGatewayConfigId =
> paymentConfig.getString("paymentGatewayConfigId");
>            configString =  
> paymentConfig.getString("paymentPropertiesPath");
>            Debug.logInfo("using paymentConfig", module);
>        }
>
> paymentGatewayConfigId !=null
> configString = null
>
> so
>       if (configString == null) {
>            configString = "payment.properties";
>            Debug.logInfo("using payment.properties", module);
>       }
>
> sets the configString =="using payment.properties"
>
> so when you get to getPaymentGatewayConfigValue()
> it will try to read the db config instead of the payment properties.
>
>
> Scott Gray sent the following on 6/17/2009 3:52 PM:
>> Looks to me as though it will work fine so long as your
>> ProductStorePaymentSetting for EXT_PAYPAL doesn't have a
>> paymentGatewayConfigId set.
>>
>> Regards
>> Scott
>>
>> HotWax Media
>> http://www.hotwaxmedia.com
>>
>> On 18/06/2009, at 8:39 AM, BJ Freeman wrote:
>>
>>> for those that have not installed the entity paymentGateway and  
>>> still
>>> use the payment.properties
>>>
>>> the logic to select which one needs an new statement in the method
>>> getPaymentGatewayConfigValue()
>>> from
>>>       if (UtilValidate.isNotEmpty(paymentGatewayConfigId)) {
>>>
>>> to
>>>       if (UtilValidate.isNotEmpty(paymentGatewayConfigId)&&(resource
>>> !="payment.properties")) {
>>>
>>> I am still preparing a patch this would be included in, that will  
>>> not be
>>> submitted for a few weeks.
>>>
>>> this is just a heads up if you having problems.
>>>
>>>
>>>
>>> --
>>> BJ Freeman
>>> http://www.businessesnetwork.com/automation
>>> http://bjfreeman.elance.com
>>> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
>>>
>>> Systems Integrator.
>>>
>>
>
> --
> BJ Freeman
> http://www.businessesnetwork.com/automation
> http://bjfreeman.elance.com
> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
> Systems Integrator.
>

[BJ Freeman]

gotcha.
put in a loginfo to that effect if paymentGatewayConfigId !=null and
paymentPropertiesPath==null


Scott Gray sent the following on 6/17/2009 4:24 PM:

> The PaymentGatewayConfig takes precedence over payment.properties so if
> a paymentGatewayConfigId is set on your ProductStorePaymentSetting then
> that is what will be used regardless of the value of the
> paymentPropertiesPath.
>
> Like I said in my last email if you want payment/properties to be used
> then set the paymentGatewayConfigId to null.
>
> Regards
> Scott
>
> HotWax Media
> http://www.hotwaxmedia.com
>
> On 18/06/2009, at 9:17 AM, BJ Freeman wrote:
>
>> I have not dug into this but here is what happens
>>       if (paymentConfig != null) {
>>            paymentGatewayConfigId =
>> paymentConfig.getString("paymentGatewayConfigId");
>>            configString =
>> paymentConfig.getString("paymentPropertiesPath");
>>            Debug.logInfo("using paymentConfig", module);
>>        }
>>
>> paymentGatewayConfigId !=null
>> configString = null
>>
>> so
>>       if (configString == null) {
>>            configString = "payment.properties";
>>            Debug.logInfo("using payment.properties", module);
>>       }
>>
>> sets the configString =="using payment.properties"
>>
>> so when you get to getPaymentGatewayConfigValue()
>> it will try to read the db config instead of the payment properties.
>>
>>
>> Scott Gray sent the following on 6/17/2009 3:52 PM:
>>> Looks to me as though it will work fine so long as your
>>> ProductStorePaymentSetting for EXT_PAYPAL doesn't have a
>>> paymentGatewayConfigId set.
>>>
>>> Regards
>>> Scott
>>>
>>> HotWax Media
>>> http://www.hotwaxmedia.com
>>>
>>> On 18/06/2009, at 8:39 AM, BJ Freeman wrote:
>>>
>>>> for those that have not installed the entity paymentGateway and still
>>>> use the payment.properties
>>>>
>>>> the logic to select which one needs an new statement in the method
>>>> getPaymentGatewayConfigValue()
>>>> from
>>>>       if (UtilValidate.isNotEmpty(paymentGatewayConfigId)) {
>>>>
>>>> to
>>>>       if (UtilValidate.isNotEmpty(paymentGatewayConfigId)&&(resource
>>>> !="payment.properties")) {
>>>>
>>>> I am still preparing a patch this would be included in, that will
>>>> not be
>>>> submitted for a few weeks.
>>>>
>>>> this is just a heads up if you having problems.
>>>>
>>>>
>>>>
>>>> --
>>>> BJ Freeman
>>>> http://www.businessesnetwork.com/automation
>>>> http://bjfreeman.elance.com
>>>> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
>>>>
>>>>
>>>> Systems Integrator.
>>>>
>>>
>>
>> --
>> BJ Freeman
>> http://www.businessesnetwork.com/automation
>> http://bjfreeman.elance.com
>> http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
>>
>> Systems Integrator.
>>
>

--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.

[Rees Watkins]

Hi

I am unable to get ofbiz to send an email on customer registration on my ecommerce site. I get the error below. It does not seem to be able to find the email template; even though it is in the location specified. I have set the store emails up using the demo site as a guide. I have tried to register as a customer on the ofbiz demo ecommerce site, but I do not get a registration confirmation email either. Any help will be gratefully received.

Kind regards
Rees

Problem getting the template URL: component://party/widget/partymgr/EmailPartyScreens.xml#CreatePartyNotification not found
prepareNotification failed: Problem finding template; see logs
Invalid email body; null is not allowed
Error in Service [sendGenericNotificationEmail]: Invalid email body; null is not allowed

[BJ Freeman]

do you have the emails defined in the productstore>emails


Rees Watkins sent the following on 6/18/2009 2:38 AM:

> Hi
>
> I am unable to get ofbiz to send an email on customer registration on my ecommerce site. I get the error below. It does not seem to be able to find the email template; even though it is in the location specified. I have set the store emails up using the demo site as a guide. I have tried to register as a customer on the ofbiz demo ecommerce site, but I do not get a registration confirmation email either. Any help will be gratefully received.
>
> Kind regards
> Rees
>
> Problem getting the template URL: component://party/widget/partymgr/EmailPartyScreens.xml#CreatePartyNotification not found
> prepareNotification failed: Problem finding template; see logs
> Invalid email body; null is not allowed
> Error in Service [sendGenericNotificationEmail]: Invalid email body; null is not allowed
>
>
>      

--
BJ Freeman
http://www.businessesnetwork.com/automation
http://bjfreeman.elance.com
http://www.linkedin.com/profile?viewProfile=&key=1237480&locale=en_US&trk=tab_pro
Systems Integrator.