Can we expect any results on this?
OBIZ-1644 Screens to manage Calendar in SFA webapp Anil K Patel 14/Feb/08 OFBIZ-1645 Screens to manage Forecast in SFA webapp Anil K Patel 15/Feb/08 OFBIZ-2364 Competitors & Partners - Sales Force Automation component Vikas Mayur 27/Apr/09 OFBIZ-2363 Improvements in Sales Force Automation component Vikas Mayur 27/Apr/09 OFBIZ-2363 Improvements in "Contact" Screens Ashish Vijaywargiya 27/Apr/09 OFBIZ-2363 Improvements in "Lead" Screens Ashish Vijaywargiya 27/Apr/09 OFBIZ-2427 Cases - Sales Force Automation component Ashish Vijaywargiya 06/May/09 Some systems only got successful having CRM/SFA as one of the major components...... -- http://www.antwebsystems.com : Quality OFBiz support for competitive rates.... |
Agreed, the SFA system definitely needs a lot of love and hopefully
with additional discussion going on in the community we can get some more traction on that. At this point, we are using it internally, but haven't had enough time to spend on enhancing this application to the fullest. First of all, company based attacks will not be tolerated my friend - please stop it, it makes you look bad and continues to erode faith. This is me coming after you for your carelessness, has nothing to do with my company, so feel free to remember that before you slop this up here. But if you'd like to talk about contributions and what _we've_ been doing, here you go. Instead of working on SFA, which btw hasn't seemed to be a have a huge push from the community, we've been spending our time and money working on rebranding the applications, enhancing the accounting application, cleaning up all of the amazingly outdated HTML in the system, adding additional tests to enhance stability, adding and cleaning up lots of integrations, and adding features to the eCommerce application where they were lacking. Would you like me to list all of those and the commit messages to go along with them or can we agree that they would dwarf the garbage you've thrown out below? The other thing we spend a lot of time on is cleaning up your code and ensuring that your flippant commits don't hurt the system. This slight of hand to look at the grossly neglected SFA system is a cute distraction, but remember the point - you are not following the best practices laid down by the community - not our company - and if you continue you to - I can't imagine why you'd be able to be given the power to keep doing it. Do your work, help the community, follow the guidelines, or stop wasting everyone's time. Cheers, Ruppert On Oct 21, 2009, at 8:16 AM, Hans Bakker wrote: > Can we expect any results on this? > > OBIZ-1644 Screens to manage Calendar in SFA webapp > Anil K Patel 14/Feb/08 > > OFBIZ-1645 Screens to manage Forecast in SFA webapp > Anil K Patel 15/Feb/08 > > OFBIZ-2364 Competitors & Partners - Sales Force Automation component > Vikas Mayur 27/Apr/09 > > OFBIZ-2363 Improvements in Sales Force Automation component > Vikas Mayur 27/Apr/09 > > OFBIZ-2363 Improvements in "Contact" Screens > Ashish Vijaywargiya 27/Apr/09 > > OFBIZ-2363 Improvements in "Lead" Screens > Ashish Vijaywargiya 27/Apr/09 > > OFBIZ-2427 Cases - Sales Force Automation component > Ashish Vijaywargiya 06/May/09 > > Some systems only got successful having CRM/SFA as one of the major > components...... > > -- > http://www.antwebsystems.com : > Quality OFBiz support for competitive rates.... > smime.p7s (3K) Download Attachment |
Tim,
Let me first say that i appreciate the things you and your people have done to OFbiz but is that a reason to write such a flame message? Yes i know you contributed a lot similar to what we (I and my people) have done. However it sure looks like we have a different focus supporting OFBiz, I am most interested filling the functional gaps that exist in the system, you seem to have most interest in improving existing functions and presentation and html/css. Doesn't that fit together well? Most (all?) of the comments of you and your people i have implemented. So lets stop this flame, i can already tell you that if you find a wrongly named variable or a few styles in some ftl code, you sure can mention them to me and we will try to correct it and we are not offended if you correct it yourself.... lets work together, regards, Hans On Wed, 2009-10-21 at 08:43 -0600, Tim Ruppert wrote: > Agreed, the SFA system definitely needs a lot of love and hopefully > with additional discussion going on in the community we can get some > more traction on that. At this point, we are using it internally, but > haven't had enough time to spend on enhancing this application to the > fullest. > > First of all, company based attacks will not be tolerated my friend - > please stop it, it makes you look bad and continues to erode faith. > This is me coming after you for your carelessness, has nothing to do > with my company, so feel free to remember that before you slop this up > here. But if you'd like to talk about contributions and what _we've_ > been doing, here you go. > > Instead of working on SFA, which btw hasn't seemed to be a have a huge > push from the community, we've been spending our time and money > working on rebranding the applications, enhancing the accounting > application, cleaning up all of the amazingly outdated HTML in the > system, adding additional tests to enhance stability, adding and > cleaning up lots of integrations, and adding features to the eCommerce > application where they were lacking. Would you like me to list all of > those and the commit messages to go along with them or can we agree > that they would dwarf the garbage you've thrown out below? > > The other thing we spend a lot of time on is cleaning up your code and > ensuring that your flippant commits don't hurt the system. This slight > of hand to look at the grossly neglected SFA system is a cute > distraction, but remember the point - you are not following the best > practices laid down by the community - not our company - and if you > continue you to - I can't imagine why you'd be able to be given the > power to keep doing it. > > Do your work, help the community, follow the guidelines, or stop > wasting everyone's time. > > Cheers, > Ruppert > > On Oct 21, 2009, at 8:16 AM, Hans Bakker wrote: > > > Can we expect any results on this? > > > > OBIZ-1644 Screens to manage Calendar in SFA webapp > > Anil K Patel 14/Feb/08 > > > > OFBIZ-1645 Screens to manage Forecast in SFA webapp > > Anil K Patel 15/Feb/08 > > > > OFBIZ-2364 Competitors & Partners - Sales Force Automation component > > Vikas Mayur 27/Apr/09 > > > > OFBIZ-2363 Improvements in Sales Force Automation component > > Vikas Mayur 27/Apr/09 > > > > OFBIZ-2363 Improvements in "Contact" Screens > > Ashish Vijaywargiya 27/Apr/09 > > > > OFBIZ-2363 Improvements in "Lead" Screens > > Ashish Vijaywargiya 27/Apr/09 > > > > OFBIZ-2427 Cases - Sales Force Automation component > > Ashish Vijaywargiya 06/May/09 > > > > Some systems only got successful having CRM/SFA as one of the major > > components...... > > > > -- > > http://www.antwebsystems.com : > > Quality OFBiz support for competitive rates.... > > > Antwebsystems.com: Quality OFBiz services for competitive rates |
Hans, Thank you for a mature and polite response to an immature and impolite message from Tim. I am saddened by the tone of some recent messages to you from Tim and certain others at Hotwax, and I'm glad you are stepping up and responding well and being a peacemaker to help hold together the community that drives this project. I've been meaning to respond to this all day and trying to think of the best way to do so. Thanks again there, because I'd much rather praise a good example than criticize a bad one. -David On Oct 21, 2009, at 7:14 PM, Hans Bakker wrote: > Tim, > > Let me first say that i appreciate the things you and your people have > done to OFbiz but is that a reason to write such a flame message? > Yes i > know you contributed a lot similar to what we (I and my people) have > done. > > However it sure looks like we have a different focus supporting > OFBiz, I > am most interested filling the functional gaps that exist in the > system, > you seem to have most interest in improving existing functions and > presentation and html/css. > > Doesn't that fit together well? > > Most (all?) of the comments of you and your people i have implemented. > > So lets stop this flame, i can already tell you that if you find a > wrongly named variable or a few styles in some ftl code, you sure can > mention them to me and we will try to correct it and we are not > offended > if you correct it yourself.... > > lets work together, > > regards, > Hans > > > > On Wed, 2009-10-21 at 08:43 -0600, Tim Ruppert wrote: >> Agreed, the SFA system definitely needs a lot of love and hopefully >> with additional discussion going on in the community we can get some >> more traction on that. At this point, we are using it internally, >> but >> haven't had enough time to spend on enhancing this application to the >> fullest. >> >> First of all, company based attacks will not be tolerated my friend - >> please stop it, it makes you look bad and continues to erode faith. >> This is me coming after you for your carelessness, has nothing to do >> with my company, so feel free to remember that before you slop this >> up >> here. But if you'd like to talk about contributions and what _we've_ >> been doing, here you go. >> >> Instead of working on SFA, which btw hasn't seemed to be a have a >> huge >> push from the community, we've been spending our time and money >> working on rebranding the applications, enhancing the accounting >> application, cleaning up all of the amazingly outdated HTML in the >> system, adding additional tests to enhance stability, adding and >> cleaning up lots of integrations, and adding features to the >> eCommerce >> application where they were lacking. Would you like me to list all >> of >> those and the commit messages to go along with them or can we agree >> that they would dwarf the garbage you've thrown out below? >> >> The other thing we spend a lot of time on is cleaning up your code >> and >> ensuring that your flippant commits don't hurt the system. This >> slight >> of hand to look at the grossly neglected SFA system is a cute >> distraction, but remember the point - you are not following the best >> practices laid down by the community - not our company - and if you >> continue you to - I can't imagine why you'd be able to be given the >> power to keep doing it. >> >> Do your work, help the community, follow the guidelines, or stop >> wasting everyone's time. >> >> Cheers, >> Ruppert >> >> On Oct 21, 2009, at 8:16 AM, Hans Bakker wrote: >> >>> Can we expect any results on this? >>> >>> OBIZ-1644 Screens to manage Calendar in SFA webapp >>> Anil K Patel 14/Feb/08 >>> >>> OFBIZ-1645 Screens to manage Forecast in SFA webapp >>> Anil K Patel 15/Feb/08 >>> >>> OFBIZ-2364 Competitors & Partners - Sales Force Automation component >>> Vikas Mayur 27/Apr/09 >>> >>> OFBIZ-2363 Improvements in Sales Force Automation component >>> Vikas Mayur 27/Apr/09 >>> >>> OFBIZ-2363 Improvements in "Contact" Screens >>> Ashish Vijaywargiya 27/Apr/09 >>> >>> OFBIZ-2363 Improvements in "Lead" Screens >>> Ashish Vijaywargiya 27/Apr/09 >>> >>> OFBIZ-2427 Cases - Sales Force Automation component >>> Ashish Vijaywargiya 06/May/09 >>> >>> Some systems only got successful having CRM/SFA as one of the major >>> components...... >>> >>> -- >>> http://www.antwebsystems.com : >>> Quality OFBiz support for competitive rates.... >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
In reply to this post by hans_bakker
Looking forward to working this out as a community Hans. I'll do this
for you -anything that you want me or my people to go back and look at because it doesn't follow the best practices of the project, I will fully endorse and will ensure get fixed. Please do the same on your end - and when you see it / please do your best not to repeat it. Lookong forward to a long and fruitful working relationship - not calling out companies - but instead pushing contributors to making higher quality contributions to the community. Thanks Hans and looking forward to seeing you at ApacheCon! Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Oct 21, 2009, at 6:14 PM, Hans Bakker <[hidden email]> wrote: > Tim, > > Let me first say that i appreciate the things you and your people have > done to OFbiz but is that a reason to write such a flame message? > Yes i > know you contributed a lot similar to what we (I and my people) have > done. > > However it sure looks like we have a different focus supporting > OFBiz, I > am most interested filling the functional gaps that exist in the > system, > you seem to have most interest in improving existing functions and > presentation and html/css. > > Doesn't that fit together well? > > Most (all?) of the comments of you and your people i have implemented. > > So lets stop this flame, i can already tell you that if you find a > wrongly named variable or a few styles in some ftl code, you sure can > mention them to me and we will try to correct it and we are not > offended > if you correct it yourself.... > > lets work together, > > regards, > Hans > > > > On Wed, 2009-10-21 at 08:43 -0600, Tim Ruppert wrote: >> Agreed, the SFA system definitely needs a lot of love and hopefully >> with additional discussion going on in the community we can get some >> more traction on that. At this point, we are using it internally, >> but >> haven't had enough time to spend on enhancing this application to the >> fullest. >> >> First of all, company based attacks will not be tolerated my friend - >> please stop it, it makes you look bad and continues to erode faith. >> This is me coming after you for your carelessness, has nothing to do >> with my company, so feel free to remember that before you slop this >> up >> here. But if you'd like to talk about contributions and what _we've_ >> been doing, here you go. >> >> Instead of working on SFA, which btw hasn't seemed to be a have a >> huge >> push from the community, we've been spending our time and money >> working on rebranding the applications, enhancing the accounting >> application, cleaning up all of the amazingly outdated HTML in the >> system, adding additional tests to enhance stability, adding and >> cleaning up lots of integrations, and adding features to the >> eCommerce >> application where they were lacking. Would you like me to list all >> of >> those and the commit messages to go along with them or can we agree >> that they would dwarf the garbage you've thrown out below? >> >> The other thing we spend a lot of time on is cleaning up your code >> and >> ensuring that your flippant commits don't hurt the system. This >> slight >> of hand to look at the grossly neglected SFA system is a cute >> distraction, but remember the point - you are not following the best >> practices laid down by the community - not our company - and if you >> continue you to - I can't imagine why you'd be able to be given the >> power to keep doing it. >> >> Do your work, help the community, follow the guidelines, or stop >> wasting everyone's time. >> >> Cheers, >> Ruppert >> >> On Oct 21, 2009, at 8:16 AM, Hans Bakker wrote: >> >>> Can we expect any results on this? >>> >>> OBIZ-1644 Screens to manage Calendar in SFA webapp >>> Anil K Patel 14/Feb/08 >>> >>> OFBIZ-1645 Screens to manage Forecast in SFA webapp >>> Anil K Patel 15/Feb/08 >>> >>> OFBIZ-2364 Competitors & Partners - Sales Force Automation component >>> Vikas Mayur 27/Apr/09 >>> >>> OFBIZ-2363 Improvements in Sales Force Automation component >>> Vikas Mayur 27/Apr/09 >>> >>> OFBIZ-2363 Improvements in "Contact" Screens >>> Ashish Vijaywargiya 27/Apr/09 >>> >>> OFBIZ-2363 Improvements in "Lead" Screens >>> Ashish Vijaywargiya 27/Apr/09 >>> >>> OFBIZ-2427 Cases - Sales Force Automation component >>> Ashish Vijaywargiya 06/May/09 >>> >>> Some systems only got successful having CRM/SFA as one of the major >>> components...... >>> >>> -- >>> http://www.antwebsystems.com : >>> Quality OFBiz support for competitive rates.... >>> >> > -- > Antwebsystems.com: Quality OFBiz services for competitive rates > |
Tim,
What are the most common bad practices that you see? It would help to know some specifics. -Al |
Hi Al,
It is probably easiest if you just review the commits that have received comments: http://markmail.org/search/list:org%2Eapache%2Eofbiz%2Edev+subject :"svn+commit:"+order:date-backward Regards Scott On 22/10/2009, at 3:53 PM, Al Byers wrote: > Tim, > > What are the most common bad practices that you see? It would help to > know some specifics. > > -Al smime.p7s (4K) Download Attachment |
In reply to this post by hans_bakker
Hans,
I share some of the frustration Tim expressed, but at the same time I really appreciate the valuable contributions your company has made to the project. All I would ask is that you spend a little more time reviewing code and testing it before committing it. -Adrian --- On Wed, 10/21/09, Hans Bakker <[hidden email]> wrote: > From: Hans Bakker <[hidden email]> > Subject: Working together. was: plans are nice, but what then? > To: [hidden email] > Date: Wednesday, October 21, 2009, 6:14 PM > Tim, > > Let me first say that i appreciate the things you and your > people have > done to OFbiz but is that a reason to write such a flame > message? Yes i > know you contributed a lot similar to what we (I and my > people) have > done. > > However it sure looks like we have a different focus > supporting OFBiz, I > am most interested filling the functional gaps that exist > in the system, > you seem to have most interest in improving existing > functions and > presentation and html/css. > > Doesn't that fit together well? > > Most (all?) of the comments of you and your people i have > implemented. > > So lets stop this flame, i can already tell you that if you > find a > wrongly named variable or a few styles in some ftl code, > you sure can > mention them to me and we will try to correct it and we are > not offended > if you correct it yourself.... > > lets work together, > > regards, > Hans > > > > On Wed, 2009-10-21 at 08:43 -0600, Tim Ruppert wrote: > > Agreed, the SFA system definitely needs a lot of love > and hopefully > > with additional discussion going on in the community > we can get some > > more traction on that. At this point, we are > using it internally, but > > haven't had enough time to spend on enhancing this > application to the > > fullest. > > > > First of all, company based attacks will not be > tolerated my friend - > > please stop it, it makes you look bad and continues to > erode faith.   > > This is me coming after you for your carelessness, has > nothing to do > > with my company, so feel free to remember that before > you slop this up > > here. But if you'd like to talk about > contributions and what _we've_ > > been doing, here you go. > > > > Instead of working on SFA, which btw hasn't seemed to > be a have a huge > > push from the community, we've been spending our time > and money > > working on rebranding the applications, enhancing the > accounting > > application, cleaning up all of the amazingly outdated > HTML in the > > system, adding additional tests to enhance stability, > adding and > > cleaning up lots of integrations, and adding features > to the eCommerce > > application where they were lacking. Would you > like me to list all of > > those and the commit messages to go along with them or > can we agree > > that they would dwarf the garbage you've thrown out > below? > > > > The other thing we spend a lot of time on is cleaning > up your code and > > ensuring that your flippant commits don't hurt the > system. This slight > > of hand to look at the grossly neglected SFA system is > a cute > > distraction, but remember the point - you are not > following the best > > practices laid down by the community - not our company > - and if you > > continue you to - I can't imagine why you'd be able to > be given the > > power to keep doing it. > > > > Do your work, help the community, follow the > guidelines, or stop > > wasting everyone's time. > > > > Cheers, > > Ruppert > > > > On Oct 21, 2009, at 8:16 AM, Hans Bakker wrote: > > > > > Can we expect any results on this? > > > > > > OBIZ-1644 Screens to manage Calendar in SFA > webapp > > > Anil K Patel 14/Feb/08 > > > > > > OFBIZ-1645 Screens to manage Forecast in SFA > webapp > > > Anil K Patel 15/Feb/08 > > > > > > OFBIZ-2364 Competitors & Partners - Sales > Force Automation component > > > Vikas Mayur 27/Apr/09 > > > > > > OFBIZ-2363 Improvements in Sales Force Automation > component > > > Vikas Mayur 27/Apr/09 > > > > > > OFBIZ-2363 Improvements in "Contact" Screens > > > Ashish Vijaywargiya 27/Apr/09 > > > > > > OFBIZ-2363 Improvements in "Lead" Screens > > > Ashish Vijaywargiya 27/Apr/09 > > > > > > OFBIZ-2427 Cases - Sales Force Automation > component > > > Ashish Vijaywargiya 06/May/09 > > > > > > Some systems only got successful having CRM/SFA > as one of the major > > > components...... > > > > > > -- > > > http://www.antwebsystems.com : > > > Quality OFBiz support for competitive rates.... > > > > > > -- > Antwebsystems.com: Quality OFBiz services for competitive > rates > > |
Agreed - thanks Adrian - and please everyone keep the comments coming
- it will make it better for all of us in the end. As Cheers, Ruppert On Oct 21, 2009, at 9:28 PM, Adrian Crum wrote: > Hans, > > I share some of the frustration Tim expressed, but at the same time > I really appreciate the valuable contributions your company has made > to the project. > > All I would ask is that you spend a little more time reviewing code > and testing it before committing it. > > -Adrian > > --- On Wed, 10/21/09, Hans Bakker <[hidden email]> > wrote: > >> From: Hans Bakker <[hidden email]> >> Subject: Working together. was: plans are nice, but what then? >> To: [hidden email] >> Date: Wednesday, October 21, 2009, 6:14 PM >> Tim, >> >> Let me first say that i appreciate the things you and your >> people have >> done to OFbiz but is that a reason to write such a flame >> message? Yes i >> know you contributed a lot similar to what we (I and my >> people) have >> done. >> >> However it sure looks like we have a different focus >> supporting OFBiz, I >> am most interested filling the functional gaps that exist >> in the system, >> you seem to have most interest in improving existing >> functions and >> presentation and html/css. >> >> Doesn't that fit together well? >> >> Most (all?) of the comments of you and your people i have >> implemented. >> >> So lets stop this flame, i can already tell you that if you >> find a >> wrongly named variable or a few styles in some ftl code, >> you sure can >> mention them to me and we will try to correct it and we are >> not offended >> if you correct it yourself.... >> >> lets work together, >> >> regards, >> Hans >> >> >> >> On Wed, 2009-10-21 at 08:43 -0600, Tim Ruppert wrote: >>> Agreed, the SFA system definitely needs a lot of love >> and hopefully >>> with additional discussion going on in the community >> we can get some >>> more traction on that. At this point, we are >> using it internally, but >>> haven't had enough time to spend on enhancing this >> application to the >>> fullest. >>> >>> First of all, company based attacks will not be >> tolerated my friend - >>> please stop it, it makes you look bad and continues to >> erode faith. >>> This is me coming after you for your carelessness, has >> nothing to do >>> with my company, so feel free to remember that before >> you slop this up >>> here. But if you'd like to talk about >> contributions and what _we've_ >>> been doing, here you go. >>> >>> Instead of working on SFA, which btw hasn't seemed to >> be a have a huge >>> push from the community, we've been spending our time >> and money >>> working on rebranding the applications, enhancing the >> accounting >>> application, cleaning up all of the amazingly outdated >> HTML in the >>> system, adding additional tests to enhance stability, >> adding and >>> cleaning up lots of integrations, and adding features >> to the eCommerce >>> application where they were lacking. Would you >> like me to list all of >>> those and the commit messages to go along with them or >> can we agree >>> that they would dwarf the garbage you've thrown out >> below? >>> >>> The other thing we spend a lot of time on is cleaning >> up your code and >>> ensuring that your flippant commits don't hurt the >> system. This slight >>> of hand to look at the grossly neglected SFA system is >> a cute >>> distraction, but remember the point - you are not >> following the best >>> practices laid down by the community - not our company >> - and if you >>> continue you to - I can't imagine why you'd be able to >> be given the >>> power to keep doing it. >>> >>> Do your work, help the community, follow the >> guidelines, or stop >>> wasting everyone's time. >>> >>> Cheers, >>> Ruppert >>> >>> On Oct 21, 2009, at 8:16 AM, Hans Bakker wrote: >>> >>>> Can we expect any results on this? >>>> >>>> OBIZ-1644 Screens to manage Calendar in SFA >> webapp >>>> Anil K Patel 14/Feb/08 >>>> >>>> OFBIZ-1645 Screens to manage Forecast in SFA >> webapp >>>> Anil K Patel 15/Feb/08 >>>> >>>> OFBIZ-2364 Competitors & Partners - Sales >> Force Automation component >>>> Vikas Mayur 27/Apr/09 >>>> >>>> OFBIZ-2363 Improvements in Sales Force Automation >> component >>>> Vikas Mayur 27/Apr/09 >>>> >>>> OFBIZ-2363 Improvements in "Contact" Screens >>>> Ashish Vijaywargiya 27/Apr/09 >>>> >>>> OFBIZ-2363 Improvements in "Lead" Screens >>>> Ashish Vijaywargiya 27/Apr/09 >>>> >>>> OFBIZ-2427 Cases - Sales Force Automation >> component >>>> Ashish Vijaywargiya 06/May/09 >>>> >>>> Some systems only got successful having CRM/SFA >> as one of the major >>>> components...... >>>> >>>> -- >>>> http://www.antwebsystems.com : >>>> Quality OFBiz support for competitive rates.... >>>> >>> >> -- >> Antwebsystems.com: Quality OFBiz services for competitive >> rates >> >> > > > smime.p7s (3K) Download Attachment |
In reply to this post by Adrian Crum-2
Adrian Crum wrote:
> I share some of the frustration Tim expressed, but at the same time I really appreciate the valuable contributions your company has made to the project. > > All I would ask is that you spend a little more time reviewing code and testing it before committing it. > Which brings up back to the value of the GIT-based pull-oriented workflow. In the Linux kernel when someone has a feature they say "people come checkout my repo for the cool thing I did" and people go examine the work. The code doesn't go into someone's tree until they already approve of it. If they have a complain they might say "fix X, Y and Z and I will merge in your code". This way, if someone finds a "sloppier" workflow productive... so be it. It may not get merged until they fix it up or someone works with them to fix it up and it finally meets approval. The value is, people who are not bothered by the sloppy workflow might work fast and loose to prototype up some new feature. |
In reply to this post by hans_bakker
Well played sir.
Hans Bakker wrote: > Let me first say that i appreciate the things you and your people have > done to OFbiz but is that a reason to write such a flame message? Yes i > know you contributed a lot similar to what we (I and my people) have > done. > > However it sure looks like we have a different focus supporting OFBiz, I > am most interested filling the functional gaps that exist in the system, > you seem to have most interest in improving existing functions and > presentation and html/css. > > Doesn't that fit together well? > > Most (all?) of the comments of you and your people i have implemented. > > So lets stop this flame, i can already tell you that if you find a > wrongly named variable or a few styles in some ftl code, you sure can > mention them to me and we will try to correct it and we are not offended > if you correct it yourself.... > |
In reply to this post by Ean Schuessler
That's a pretty interesting option and I'm sure one that you've put
forward many times by now. Is this something that can be supported by the ASF infrastructure or is that something we'd have to provide / do differently on top of the existing workflow to put into place? I have to admit to reading a bit here and there about GIT, but not knowing it as well as other workflows. Cheers, Ruppert -- Tim Ruppert HotWax Media http://www.hotwaxmedia.com o:801.649.6594 f:801.649.6595 On Oct 22, 2009, at 12:14 AM, Ean Schuessler wrote: > Adrian Crum wrote: >> I share some of the frustration Tim expressed, but at the same time >> I really appreciate the valuable contributions your company has >> made to the project. >> >> All I would ask is that you spend a little more time reviewing code >> and testing it before committing it. >> > Which brings up back to the value of the GIT-based pull-oriented > workflow. In the Linux kernel when someone has a feature they say > "people come checkout my repo for the cool thing I did" and people > go examine the work. The code doesn't go into someone's tree until > they already approve of it. If they have a complain they might say > "fix X, Y and Z and I will merge in your code". > > This way, if someone finds a "sloppier" workflow productive... so be > it. It may not get merged until they fix it up or someone works with > them to fix it up and it finally meets approval. The value is, > people who are not bothered by the sloppy workflow might work fast > and loose to prototype up some new feature. smime.p7s (3K) Download Attachment |
In reply to this post by Ean Schuessler
GIT is really a very good tool. I use it locally and for other
projects. However, it does change the work flow of development. My 2 cents Raul On Thu, 22 Oct 2009 01:14:57 -0500 Ean Schuessler <[hidden email]> wrote: > Adrian Crum wrote: > > I share some of the frustration Tim expressed, but at the same time > > I really appreciate the valuable contributions your company has > > made to the project. > > > > All I would ask is that you spend a little more time reviewing code > > and testing it before committing it. > Which brings up back to the value of the GIT-based pull-oriented > workflow. In the Linux kernel when someone has a feature they say > "people come checkout my repo for the cool thing I did" and people go > examine the work. The code doesn't go into someone's tree until they > already approve of it. If they have a complain they might say "fix X, > Y and Z and I will merge in your code". > > This way, if someone finds a "sloppier" workflow productive... so be > it. It may not get merged until they fix it up or someone works with > them to fix it up and it finally meets approval. The value is, people > who are not bothered by the sloppy workflow might work fast and loose > to prototype up some new feature. |
In reply to this post by Tim Ruppert
Tim Ruppert wrote:
> That's a pretty interesting option and I'm sure one that you've put > forward many times by now. Is this something that can be supported by > the ASF infrastructure or is that something we'd have to provide / do > differently on top of the existing workflow to put into place? I have > to admit to reading a bit here and there about GIT, but not knowing it > as well as other workflows. There is, in fact, an Apache service providing GIT mirrors of Apache projects, including OFBiz. It lives at: http://git.apache.org/ So there is clearly some GIT happening in Apache. I'm not sure about the policy for the "master" repository living in GIT. |
In reply to this post by Ean Schuessler
GIT is really a very good tool. I use it locally and for other
projects. However, it does change the work flow of development. My 2 cents Raul On Thu, 22 Oct 2009 01:14:57 -0500 Ean Schuessler <[hidden email]> wrote: > Adrian Crum wrote: > > I share some of the frustration Tim expressed, but at the same time > > I really appreciate the valuable contributions your company has > > made to the project. > > > > All I would ask is that you spend a little more time reviewing code > > and testing it before committing it. > Which brings up back to the value of the GIT-based pull-oriented > workflow. In the Linux kernel when someone has a feature they say > "people come checkout my repo for the cool thing I did" and people go > examine the work. The code doesn't go into someone's tree until they > already approve of it. If they have a complain they might say "fix X, > Y and Z and I will merge in your code". > > This way, if someone finds a "sloppier" workflow productive... so be > it. It may not get merged until they fix it up or someone works with > them to fix it up and it finally meets approval. The value is, people > who are not bothered by the sloppy workflow might work fast and loose > to prototype up some new feature. |
On Oct 22, 2009, at 11:49 AM, Raul Sieberath wrote: > GIT is really a very good tool. I use it locally and for other > projects. However, it does change the work flow of development. > > My 2 cents > > Raul > I agree - we use GIT internally for everything except OFBiz. Also, I would add a preemptive +1 for this approach if it is possible and seriously up for consideration. -Joe |
Administrator
|
In reply to this post by Raul Sieberath
Thanks for comment Raul,
How does it change the workflow, what does it changes ? Could you elaborate a bit more please ? I have read on Apache MLs that some persons are against using Git because, they say, it's not good for collaboration. Their arguments is to say that, contrary as Subversion general usage, with Git the tendency is to have bigger commit because people work more isolated and then commit whole blocks of changes Jacques From: "Raul Sieberath" <[hidden email]> > GIT is really a very good tool. I use it locally and for other > projects. However, it does change the work flow of development. > > My 2 cents > > Raul > > On Thu, 22 Oct 2009 01:14:57 -0500 > Ean Schuessler <[hidden email]> wrote: > >> Adrian Crum wrote: >> > I share some of the frustration Tim expressed, but at the same time >> > I really appreciate the valuable contributions your company has >> > made to the project. >> > >> > All I would ask is that you spend a little more time reviewing code >> > and testing it before committing it. >> Which brings up back to the value of the GIT-based pull-oriented >> workflow. In the Linux kernel when someone has a feature they say >> "people come checkout my repo for the cool thing I did" and people go >> examine the work. The code doesn't go into someone's tree until they >> already approve of it. If they have a complain they might say "fix X, >> Y and Z and I will merge in your code". >> >> This way, if someone finds a "sloppier" workflow productive... so be >> it. It may not get merged until they fix it up or someone works with >> them to fix it up and it finally meets approval. The value is, people >> who are not bothered by the sloppy workflow might work fast and loose >> to prototype up some new feature. > |
In reply to this post by Tim Ruppert
Tim Ruppert wrote:
> First of all, company based attacks will not be tolerated my friend - > please stop it, it makes you look bad and continues to erode faith. > This is me coming after you for your carelessness, has nothing to do > with my company, so feel free to remember that before you slop this up > here. But if you'd like to talk about contributions and what _we've_ > been doing, here you go. Huh? What? Come again? Whatcha talking about Willis? Hans did *NOTHING* wrong with his email. Absolutely *NOTHING*. I suggest you take your head of out your ass, and stop being a bitch. ps: If you think my response is inappropriate, it's just as inappropriate as yours was to Hans, with no basis at all. |
In reply to this post by David E. Jones-2
David E Jones wrote:
> I am saddened by the tone of some recent messages to you from Tim and > certain others at Hotwax, and I'm glad you are stepping up and > responding well and being a peacemaker to help hold together the > community that drives this project. I would almost go so far as to say Tim needs to actually apologize to Hans; Tim's email was *that* bad. |
Just so everyone is on the up and up, Hans and I are offline
reconciling _both_ "attacks" and will figure a way forward. Thanks for the help and the concern. Cheers, Ruppert On Oct 22, 2009, at 3:19 PM, Adam Heath wrote: > David E Jones wrote: >> I am saddened by the tone of some recent messages to you from Tim and >> certain others at Hotwax, and I'm glad you are stepping up and >> responding well and being a peacemaker to help hold together the >> community that drives this project. > > I would almost go so far as to say Tim needs to actually apologize to > Hans; Tim's email was *that* bad. > smime.p7s (3K) Download Attachment |
Free forum by Nabble | Edit this page |