Hi OFBiz developers.
There is currently a discrepancy between quote- and order terms and the data model resource book: they are all different. I already added some fields to quote term to at least remove that difference. The problem now is with the order and quote terms that it is not possible to add a term to a whole quote or order: itemSeqId cannot be null so it is not possible to add a term for the whole quote. This is solved in the order by filling _NA_ in the itemSeqId and create a dummy _NA_ item. According to me not a nice solution. So for quote i would not like to not follow this pattern and would rather allow null in the itemSeqId field in quoteterm to make the change as easy as possible. The datamodel book is also not inconsistent having termtype in quote term in the prim key and in orderterm not. itemSeqId in the book is for both entities not in the prim key. termId is the key here.... Any opinions? Regards, Hans -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
having null values in the index opposed too much problems,
Now we have followed the orderterm pattern and Committed in revision 1073587. Regards, Hans On Wed, 2011-02-09 at 09:03 +0700, Hans Bakker wrote: > Hi OFBiz developers. > > There is currently a discrepancy between quote- and order terms and the > data model resource book: they are all different. > > I already added some fields to quote term to at least remove that > difference. > > The problem now is with the order and quote terms that it is not > possible to add a term to a whole quote or order: itemSeqId cannot be > null so it is not possible to add a term for the whole quote. > > This is solved in the order by filling _NA_ in the itemSeqId and create > a dummy _NA_ item. According to me not a nice solution. So for quote i > would not like to not follow this pattern and would rather allow null in > the itemSeqId field in quoteterm to make the change as easy as possible. > > The datamodel book is also not inconsistent having termtype in quote > term in the prim key and in orderterm not. itemSeqId in the book is for > both entities not in the prim key. termId is the key here.... > > Any opinions? > > Regards, > Hans > -- Ofbiz on twitter: http://twitter.com/apache_ofbiz Myself on twitter: http://twitter.com/hansbak Antwebsystems.com: Quality services for competitive rates. |
sorry for the late response.
the _NA_ was for demo data and got get the entityviews to show and get relationships to return all recorders. if the business logic is done correct where Ecas make sure that all the relative records are filled in, then nulls are not necessary. using nulls ImHO, leads to incomplete data. just my 2 cents. ========================= BJ Freeman Strategic Power Office with Supplier Automation <http://www.businessesnetwork.com/automation/viewforum.php?f=52> Specialtymarket.com <http://www.specialtymarket.com/> Systems Integrator-- Glad to Assist Chat Y! messenger: bjfr33man Hans Bakker sent the following on 2/22/2011 7:59 PM: > having null values in the index opposed too much problems, > Now we have followed the orderterm pattern and Committed in revision > 1073587. > > Regards, > Hans > > On Wed, 2011-02-09 at 09:03 +0700, Hans Bakker wrote: >> Hi OFBiz developers. >> >> There is currently a discrepancy between quote- and order terms and the >> data model resource book: they are all different. >> >> I already added some fields to quote term to at least remove that >> difference. >> >> The problem now is with the order and quote terms that it is not >> possible to add a term to a whole quote or order: itemSeqId cannot be >> null so it is not possible to add a term for the whole quote. >> >> This is solved in the order by filling _NA_ in the itemSeqId and create >> a dummy _NA_ item. According to me not a nice solution. So for quote i >> would not like to not follow this pattern and would rather allow null in >> the itemSeqId field in quoteterm to make the change as easy as possible. >> >> The datamodel book is also not inconsistent having termtype in quote >> term in the prim key and in orderterm not. itemSeqId in the book is for >> both entities not in the prim key. termId is the key here.... >> >> Any opinions? >> >> Regards, >> Hans >> > |
Free forum by Nabble | Edit this page |