(sales) invoice item types missing

[Willem Janssen-2]

Hi,

When creating an item for a sales invoice, it looks like some item  
types are missing (trunk version).

A while ago I created a patch fot that (jira 3537), but because there  
is no response I'm doubting if this is an issue or a change in logic.
At our company we use the item type 'invoice sales tax' which is one  
of the item types that don't show anymore.

Can somebody please tell me if this is an issue?

Regards,

Willem Janssen

T: 073 532 74 11
F: 073 532 74 12
M: 06 27 888 464
E: [hidden email]
W: www.zchok.nl

[Jacques Le Roux]

Hi Willem,

I can't see any reasons why they should not be there, committers?

Willem, you don't need to watch a Jira issue when you are the reporter, it's automatically done ;o)

Without comments I will commit Willem's patch...

Jacques

Willem Janssen wrote:

> Hi,
>
> When creating an item for a sales invoice, it looks like some item
> types are missing (trunk version).
>
> A while ago I created a patch fot that (jira 3537), but because there
> is no response I'm doubting if this is an issue or a change in logic.
> At our company we use the item type 'invoice sales tax' which is one
> of the item types that don't show anymore.
>
> Can somebody please tell me if this is an issue?
>
> Regards,
>
> Willem Janssen
>
> T: 073 532 74 11
> F: 073 532 74 12
> M: 06 27 888 464
> E: [hidden email]
> W: www.zchok.nl

[Scott Gray-2]

I started to look at it a while ago but then ran out of time, I can however say that no type records are missing from the database some of them are just inconsistently named.

As to types missing from the drop-down, yes I agree that it is an issue.

Regards
Scott

On 7/06/2010, at 8:37 PM, Jacques Le Roux wrote:

> Hi Willem,
>
> I can't see any reasons why they should not be there, committers?
>
> Willem, you don't need to watch a Jira issue when you are the reporter, it's automatically done ;o)
>
> Without comments I will commit Willem's patch...
>
> Jacques
>
> Willem Janssen wrote:
>> Hi,
>> When creating an item for a sales invoice, it looks like some item
>> types are missing (trunk version).
>> A while ago I created a patch fot that (jira 3537), but because there
>> is no response I'm doubting if this is an issue or a change in logic.
>> At our company we use the item type 'invoice sales tax' which is one
>> of the item types that don't show anymore.
>> Can somebody please tell me if this is an issue?
>> Regards,
>> Willem Janssen
>> T: 073 532 74 11
>> F: 073 532 74 12
>> M: 06 27 888 464
>> E: [hidden email]
>> W: www.zchok.nl
>

[Willem Janssen-2]

Hi Scott, Jacques,

Thanks for looking into this and providing for a breakdown structure  
of the invoice item types. It helps to get an overview of the topic.

...unwatching future issues from now :)

Willem


Op 7 jun 2010, om 10:47 heeft Scott Gray het volgende geschreven:

> I started to look at it a while ago but then ran out of time, I can  
> however say that no type records are missing from the database some  
> of them are just inconsistently named.
>
> As to types missing from the drop-down, yes I agree that it is an  
> issue.
>
> Regards
> Scott
>
> On 7/06/2010, at 8:37 PM, Jacques Le Roux wrote:
>
>> Hi Willem,
>>
>> I can't see any reasons why they should not be there, committers?
>>
>> Willem, you don't need to watch a Jira issue when you are the  
>> reporter, it's automatically done ;o)
>>
>> Without comments I will commit Willem's patch...
>>
>> Jacques
>>
>> Willem Janssen wrote:
>>> Hi,
>>> When creating an item for a sales invoice, it looks like some item
>>> types are missing (trunk version).
>>> A while ago I created a patch fot that (jira 3537), but because  
>>> there
>>> is no response I'm doubting if this is an issue or a change in  
>>> logic.
>>> At our company we use the item type 'invoice sales tax' which is one
>>> of the item types that don't show anymore.
>>> Can somebody please tell me if this is an issue?
>>> Regards,
>>> Willem Janssen
>>> T: 073 532 74 11
>>> F: 073 532 74 12
>>> M: 06 27 888 464
>>> E: [hidden email]
>>> W: www.zchok.nl
>>
>

Met vriendelijke groet,

Willem Janssen

T: 073 532 74 11
F: 073 532 74 12
M: 06 27 888 464
E: [hidden email]
W: www.zchok.nl

[Willem Janssen-2]

Hi Scott, Jacques,

It's been a while ago since the we talked about the issue of certain  
invoice item types not showing when creating an invoice (jira 3537).

In a short while we want to upgrade our production environment of  
OFBiz and it would be nice if this issue is fixed. My question is if  
one of you (or somebody else?) can apply the patch provided in 3537?

Thanks a lot.

Willem



Op 7 jun 2010, om 19:25 heeft Willem Janssen het volgende geschreven:

> Hi Scott, Jacques,
>
> Thanks for looking into this and providing for a breakdown structure  
> of the invoice item types. It helps to get an overview of the topic.
>
> ...unwatching future issues from now :)
>
> Willem
>
>
> Op 7 jun 2010, om 10:47 heeft Scott Gray het volgende geschreven:
>
>> I started to look at it a while ago but then ran out of time, I can  
>> however say that no type records are missing from the database some  
>> of them are just inconsistently named.
>>
>> As to types missing from the drop-down, yes I agree that it is an  
>> issue.
>>
>> Regards
>> Scott
>>
>> On 7/06/2010, at 8:37 PM, Jacques Le Roux wrote:
>>
>>> Hi Willem,
>>>
>>> I can't see any reasons why they should not be there, committers?
>>>
>>> Willem, you don't need to watch a Jira issue when you are the  
>>> reporter, it's automatically done ;o)
>>>
>>> Without comments I will commit Willem's patch...
>>>
>>> Jacques
>>>
>>> Willem Janssen wrote:
>>>> Hi,
>>>> When creating an item for a sales invoice, it looks like some item
>>>> types are missing (trunk version).
>>>> A while ago I created a patch fot that (jira 3537), but because  
>>>> there
>>>> is no response I'm doubting if this is an issue or a change in  
>>>> logic.
>>>> At our company we use the item type 'invoice sales tax' which is  
>>>> one
>>>> of the item types that don't show anymore.
>>>> Can somebody please tell me if this is an issue?
>>>> Regards,
>>>> Willem Janssen
>>>> T: 073 532 74 11
>>>> F: 073 532 74 12
>>>> M: 06 27 888 464
>>>> E: [hidden email]
>>>> W: www.zchok.nl
>>>
>>
>
> Met vriendelijke groet,
>
> Willem Janssen
>
> T: 073 532 74 11
> F: 073 532 74 12
> M: 06 27 888 464
> E: [hidden email]
> W: www.zchok.nl
>
>
>
>
>
>

Met vriendelijke groet,

Willem Janssen
ZchokWeb

M: 06 27 888 464
E: [hidden email]
W: www.zchokweb.nl

ZchokWeb gaat geen verplichtingen aan via e-mail of naar individuele  
medewerkers. U kunt aan dit e-mail bericht dan ook geen rechten  
ontlenen. Formele beslissingen zijn voorzien van een handtekening en  
per post toegezonden.

Dit bericht is eigendom van ZchokWeb en bevat vertrouwelijke  
informatie die bestemd is voor de persoon aan wie het is gericht., U  
bent niet gemachtigd om dit bericht of een deel daarvan te lezen,  
printen, behouden, kopiëren of te verspreiden als u niet de  
geadresseerde bent. Heeft u dit bericht ten onrechte ontvangen, neem  
dan onmiddellijk contact op met de afzender en vervolgens verwijdert u  
alle kopieën van dit bericht.

[Jacques Le Roux]

Hi Willem,

Did you take Scott's comment into account?

Jacques


Willem Janssen wrote:

> Hi Scott, Jacques,
>
> It's been a while ago since the we talked about the issue of certain
> invoice item types not showing when creating an invoice (jira 3537).
>
> In a short while we want to upgrade our production environment of
> OFBiz and it would be nice if this issue is fixed. My question is if
> one of you (or somebody else?) can apply the patch provided in 3537?
>
> Thanks a lot.
>
> Willem
>
>
>
> Op 7 jun 2010, om 19:25 heeft Willem Janssen het volgende geschreven:
>
>> Hi Scott, Jacques,
>>
>> Thanks for looking into this and providing for a breakdown structure
>> of the invoice item types. It helps to get an overview of the topic.
>>
>> ...unwatching future issues from now :)
>>
>> Willem
>>
>>
>> Op 7 jun 2010, om 10:47 heeft Scott Gray het volgende geschreven:
>>
>>> I started to look at it a while ago but then ran out of time, I can
>>> however say that no type records are missing from the database some
>>> of them are just inconsistently named.
>>>
>>> As to types missing from the drop-down, yes I agree that it is an
>>> issue.
>>>
>>> Regards
>>> Scott
>>>
>>> On 7/06/2010, at 8:37 PM, Jacques Le Roux wrote:
>>>
>>>> Hi Willem,
>>>>
>>>> I can't see any reasons why they should not be there, committers?
>>>>
>>>> Willem, you don't need to watch a Jira issue when you are the
>>>> reporter, it's automatically done ;o)
>>>>
>>>> Without comments I will commit Willem's patch...
>>>>
>>>> Jacques
>>>>
>>>> Willem Janssen wrote:
>>>>> Hi,
>>>>> When creating an item for a sales invoice, it looks like some item
>>>>> types are missing (trunk version).
>>>>> A while ago I created a patch fot that (jira 3537), but because
>>>>> there
>>>>> is no response I'm doubting if this is an issue or a change in
>>>>> logic.
>>>>> At our company we use the item type 'invoice sales tax' which is
>>>>> one
>>>>> of the item types that don't show anymore.
>>>>> Can somebody please tell me if this is an issue?
>>>>> Regards,
>>>>> Willem Janssen
>>>>> T: 073 532 74 11
>>>>> F: 073 532 74 12
>>>>> M: 06 27 888 464
>>>>> E: [hidden email]
>>>>> W: www.zchok.nl
>>>>
>>>
>>
>> Met vriendelijke groet,
>>
>> Willem Janssen
>>
>> T: 073 532 74 11
>> F: 073 532 74 12
>> M: 06 27 888 464
>> E: [hidden email]
>> W: www.zchok.nl
>>
>>
>>
>>
>>
>>
>
> Met vriendelijke groet,
>
> Willem Janssen
> ZchokWeb
>
> M: 06 27 888 464
> E: [hidden email]
> W: www.zchokweb.nl
>
> ZchokWeb gaat geen verplichtingen aan via e-mail of naar individuele
> medewerkers. U kunt aan dit e-mail bericht dan ook geen rechten
> ontlenen. Formele beslissingen zijn voorzien van een handtekening en
> per post toegezonden.
>
> Dit bericht is eigendom van ZchokWeb en bevat vertrouwelijke
> informatie die bestemd is voor de persoon aan wie het is gericht., U
> bent niet gemachtigd om dit bericht of een deel daarvan te lezen,
> printen, behouden, kopiëren of te verspreiden als u niet de
> geadresseerde bent. Heeft u dit bericht ten onrechte ontvangen, neem
> dan onmiddellijk contact op met de afzender en vervolgens verwijdert u
> alle kopieën van dit bericht.