secondaryGeoId in orderitems.ftl: tax sometimes not displayed

[Sebastian Wachinger]

In applications/order/entitydef/entitymodel.xml the field secondaryGeoId is marked as deprecated (along with primaryGeoId), but in specialpurpose/ecommerce/webapp/ecommerce/order/orderitems.ftl and applications/ecommerce/webapp/ecommerce/order/orderitems.ftl both are still used, while in applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java the secondary Geo is mentioned twice in comments but not used.

Now I wonder where secondaryGeoId is defined to allow its usage in orderitems.ftl.

Maybe this issue causes the bug that I notice in the final listing on the checkout review page in the ecommerce component, where the line showing the tax for each item gets displayed (even when the tax is 0.00), or not displayed, or displayed twice, depending on the postal address currently selected by the customer.

[Jacques Le Roux]

Sebastian Wachinger wrote:
> In  applications/order/entitydef/entitymodel.xml
> <http://svn.apache.org/repos/asf/ofbiz/trunk/applications/order/entitydef/entitymodel.xml>
> the field /secondaryGeoId/ is marked as deprecated (along with
> /primaryGeoId/), but in
> specialpurpose/ecommerce/webapp/ecommerce/order/orderitems.ftl
> <http://svn.apache.org/repos/asf/ofbiz/trunk/specialpurpose/ecommerce/webapp/ecommerce/order/orderitems.ftl>
> and  applications/ecommerce/webapp/ecommerce/order/orderitems.ftl
> <http://svn.apache.org/repos/asf/ofbiz/trunk/applications/ecommerce/webapp/ecommerce/order/orderitems.ftl>

You get a 404 here, in trunk there is no longer an ecommerce component in applications, it's only in speciaclpurpose component.
I guess you meant http://svn.apache.org/repos/asf/ofbiz/trunk/applications/order/webapp/ordermgr/order/orderitems.ftl

> both are still used, while in
> applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java
> <http://svn.apache.org/repos/asf/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/tax/TaxAuthorityServices.java>
> the secondary Geo is mentioned twice in comments but not used.Now I wonder
> where /secondaryGeoId/ is defined to allow its usage in
> /orderitems.ftl/.Maybe this issue causes the bug that I notice in the final
> listing on the /checkout review page/ in the ecommerce component, where the
> line showing the tax for each item gets displayed (even when the tax is
> 0.00) or not displayed, depending on the postal address currently selected
> by the customer.

Those fields are deprecated. Which means they were used in the past but are no longer. They are kept because some customer might still use them.
But they should not have any effects if you follow the "new" (2008!) Tax Authority Data Model
https://cwiki.apache.org/confluence/display/OFBTECH/OFBiz's+Tax+Authority+Data+Model

The old data model did not support VAT

If you can reproduce a side effect, please recreate it on trunk demo and let us know before it's wiped off (everyday around 7h30, Continental European time)

Thanks

Jacques
PS: I suggested to use Chronon on demos http://markmail.org/message/pm57ponu76ipesii.
I believe it should allow us to reproduce without the data, since the complete flow is stored elsewhere they say (not tested yet).