shipment.fromPartyId not being set when shipment is created through Packing or Quick Ship process

[Pranay Pandey-2]

Hello All,

Here I am giving details of the issue:

1. What I did:
a. Created a Sales order.
b. Completed Packing process.
c. Got a shipment created.
d. Viewed Shipment details.

2. What did I expect:
Wanted to check "to" and "from" parties there.

3. What did I get:
Got "to" party but didn't see "from" party there.


I looked in to the process and code and can see that there is no  
OrderRole is being set for Company to "SHIP_FROM_VENDOR" for sales  
orders. We are not setting it in the cart to go there for further  
processing.
So at the time when createShipment service called it doesn't find this  
role for shipment.partyIdFrom in ShipmentServices.xml lines 437 to 447  
and leaves it without partyId and we don't have it in created shipment.

So now the main concern is that should we set a OrderRole for Company  
to SHIP_FROM_VENDOR for a sales order which is not done at this moment.



Thanks & Regards
--
Pranay Pandey