svn commit: r1001158 - /ofbiz/branches/jquery/framework/images/webapp/images/selectall.js

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1001158 - /ofbiz/branches/jquery/framework/images/webapp/images/selectall.js

jleroux@apache.org
Author: jleroux
Date: Sat Sep 25 07:49:48 2010
New Revision: 1001158

URL: http://svn.apache.org/viewvc?rev=1001158&view=rev
Log:
Better waitSpinnerShow/Hide (real jQuery), from Adam's remark on dev  ML

Modified:
    ofbiz/branches/jquery/framework/images/webapp/images/selectall.js

Modified: ofbiz/branches/jquery/framework/images/webapp/images/selectall.js
URL: http://svn.apache.org/viewvc/ofbiz/branches/jquery/framework/images/webapp/images/selectall.js?rev=1001158&r1=1001157&r2=1001158&view=diff
==============================================================================
--- ofbiz/branches/jquery/framework/images/webapp/images/selectall.js (original)
+++ ofbiz/branches/jquery/framework/images/webapp/images/selectall.js Sat Sep 25 07:49:48 2010
@@ -661,28 +661,21 @@ function toggleLeftColumn(){
 }
 
 function waitSpinnerShow() {
-    var spinner = document.getElementById("wait-spinner");
-    if (spinner == null) {
-        return;
-    }
-    spinner.style.display = 'block';
-    var bdy = document.body;
-    jSpinner = "#wait-spinner";
+    jSpinner = jQuery("#wait-spinner");
+    if (!jSpinner.length) return
 
-    var lookupLeft = (bdy.offsetWidth / 2) - (jQuery(jSpinner).width() / 2);
-    var scrollOffY = document.viewport.getScrollOffsets().top;
-    var winHeight = document.viewport.getHeight();
-    var lookupTop = (scrollOffY + winHeight / 2) - (jQuery(jSpinner).height() / 2);
+    bdy = document.body;
+    lookupLeft = (bdy.offsetWidth / 2) - (jSpinner.width() / 2);
+    scrollOffY = document.viewport.getScrollOffsets().top;
+    winHeight = document.viewport.getHeight();
+    lookupTop = (scrollOffY + winHeight / 2) - (jSpinner.height() / 2);
 
-    spinner.style.left = lookupLeft + "px";
-    spinner.style.top = lookupTop + "px";
-    jQuery(jSpinner).show();
+    jSpinner.css("display", "block");
+    jSpinner.css("left", lookupLeft + "px");
+    jSpinner.css("top", lookupTop + "px");
+    jSpinner.show();
 }
 
 function waitSpinnerHide() {
-    var spinner = document.getElementById("wait-spinner");
-    if (spinner != null) {
-        jQuery("#wait-spinner").fadeOut();
-        jQuery("#wait-spinner").hide();
-    }
+    jQuery("#wait-spinner").hide()
 }