svn commit: r1023860 - in /ofbiz/trunk/applications: product/script/org/ofbiz/product/storage/FacilityContactMechServices.xml workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1023860 - in /ofbiz/trunk/applications: product/script/org/ofbiz/product/storage/FacilityContactMechServices.xml workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml

jleroux@apache.org
Author: jleroux
Date: Mon Oct 18 15:45:21 2010
New Revision: 1023860

URL: http://svn.apache.org/viewvc?rev=1023860&view=rev
Log:
While working on https://issues.apache.org/jira/browse/OFBIZ-3995 I stumbled upon many hardcoded sentences in <default-message> tags.
Though it introduces dependencies from Party to Product and Workeffort, this fixes 2 of them. To be revisited if we want to remove the dependencies and fix the other hardcoded sentences. I have opened OFBIZ-3996 for that...

Modified:
    ofbiz/trunk/applications/product/script/org/ofbiz/product/storage/FacilityContactMechServices.xml
    ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml

Modified: ofbiz/trunk/applications/product/script/org/ofbiz/product/storage/FacilityContactMechServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/product/storage/FacilityContactMechServices.xml?rev=1023860&r1=1023859&r2=1023860&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/script/org/ofbiz/product/storage/FacilityContactMechServices.xml (original)
+++ ofbiz/trunk/applications/product/script/org/ofbiz/product/storage/FacilityContactMechServices.xml Mon Oct 18 15:45:21 2010
@@ -83,8 +83,7 @@ under the License.
             <set-service-fields service-name="updateContactMech" map="parameters" to-map="updateContactMechMap"/>
             <set field="updateContactMechMap.contactMechTypeId" from-field="parameters.contactMechTypeId"/>
             <call-service service-name="updateContactMech" in-map-name="updateContactMechMap">
-                <default-message>Contact Mechanism successfully updated.</default-message>
-
+                <default-message property="PartyContactMechanismSuccessfullyUpdated" resource="PartyUiLabels"/>
                 <result-to-field result-name="contactMechId" field="newFacilityContactMech.contactMechId"/>
             </call-service>
             <else>

Modified: ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml?rev=1023860&r1=1023859&r2=1023860&view=diff
==============================================================================
--- ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml (original)
+++ ofbiz/trunk/applications/workeffort/script/org/ofbiz/workeffort/workeffort/WorkEffortSimpleServices.xml Mon Oct 18 15:45:21 2010
@@ -370,7 +370,7 @@ under the License.
             <to-string field="context.contactMechId"/>
             <log level="info" message="Calling generic updateContactMech method"/>
             <call-service service-name="updateContactMech" in-map-name="context">
-                <default-message>Contact Mechanism successfully updated.</default-message>
+                <default-message property="PartyContactMechanismSuccessfullyUpdated" resource="PartyUiLabels"/>
                 <result-to-field result-name="contactMechId" field="newWorkEffortContactMech.contactMechId"/>
             </call-service>
             <else>