svn commit: r1056336 - /ofbiz/branches/release10.04/themes/bizznesstime/webapp/bizznesstime/js/application.js

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1056336 - /ofbiz/branches/release10.04/themes/bizznesstime/webapp/bizznesstime/js/application.js

jleroux@apache.org
Author: jleroux
Date: Fri Jan  7 14:30:47 2011
New Revision: 1056336

URL: http://svn.apache.org/viewvc?rev=1056336&view=rev
Log:
"Applied fix from trunk for revision: 1056305"
------------------------------------------------------------------------
r1056305 | jleroux | 2011-01-07 14:16:17 +0100 (ven., 07 janv. 2011) | 20 lines

A patch from "ScottA" "Bizzness Time Theme - Unable to use preference or application menu" (https://issues.apache.org/jira/browse/OFBIZ-4093) - OFBIZ-4093

I'm Using Win7 Pro, IE 8.0.7600 and when I log into current trunk, Business time theme, I am unable to use the applications or preferences menu.

The page is here; https://demo-trunk.ofbiz.apache.org/catalog/control/login/main?USERNAME=flexadmin&PASSWORD=ofbiz&JavaScriptEnabled=Y#

The dropdown menu will not open at all. Appears to work fine in Firefox. The only error I get is the following;

Webpage error details

User Agent: Mozilla/4.0 (compatible; MSIE 8.0; Windows NT 6.1; Trident/4.0; GTB6.6; SLCC2; .NET CLR 2.0.50727; .NET CLR 3.5.30729; .NET CLR 3.0.30729; Media Center PC 6.0; MDDS; InfoPath.2; .NET CLR 1.1.4322; Tablet PC 2.0; OfficeLiveConnector.1.5; OfficeLivePatch.1.3; .NET4.0C; .NAP 1.1)
Timestamp: Wed, 29 Dec 2010 14:40:44 UTC

Message: Can't move focus to the control because it is invisible, not enabled, or of a type that does not accept the focus.
Line: 85
Char: 7
Code: 0
URI: https://demo-trunk.ofbiz.apache.org/bizznesstime/js/application.js

JLR: I commit as CTR since I don't use Win7 (I use XP). The patch looks good and seems harmless
------------------------------------------------------------------------

JLR: actually I found a typo in the ScottA's patch, it's fixed here. I hope it's ok :/

Modified:
    ofbiz/branches/release10.04/themes/bizznesstime/webapp/bizznesstime/js/application.js

Modified: ofbiz/branches/release10.04/themes/bizznesstime/webapp/bizznesstime/js/application.js
URL: http://svn.apache.org/viewvc/ofbiz/branches/release10.04/themes/bizznesstime/webapp/bizznesstime/js/application.js?rev=1056336&r1=1056335&r2=1056336&view=diff
==============================================================================
--- ofbiz/branches/release10.04/themes/bizznesstime/webapp/bizznesstime/js/application.js (original)
+++ ofbiz/branches/release10.04/themes/bizznesstime/webapp/bizznesstime/js/application.js Fri Jan  7 14:30:47 2011
@@ -83,8 +83,10 @@ don't support input:focus (cough, cough,
 document.observe('dom:loaded', function() {
     var fields = $$("input, textarea");
     for (var i = 0; i < fields.length; i++) {
+     if (!fields[i].style.visibility == 'hidden') {
       fields[i].onfocus = function() {this.className += ' focused';}
       fields[i].onblur = function() {this.className = this.className.replace('focused', '');}
+     }
     }
 });