svn commit: r1065994 - /ofbiz/trunk/framework/images/webapp/images/fieldlookup.js

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1065994 - /ofbiz/trunk/framework/images/webapp/images/fieldlookup.js

jleroux@apache.org
Author: jleroux
Date: Tue Feb  1 11:15:10 2011
New Revision: 1065994

URL: http://svn.apache.org/viewvc?rev=1065994&view=rev
Log:
A patch from Sascha "The lookup popup window does not close when finished" (https://issues.apache.org/jira/browse/OFBIZ-4137) - OFBIZ-4137

For instance, when you select a product in the product popup lookup on the add product page of the order magager order creation wizard, the popup stays open.

Really a small fix, there was a useless variable in the set value function which caused the problem.

Modified:
    ofbiz/trunk/framework/images/webapp/images/fieldlookup.js

Modified: ofbiz/trunk/framework/images/webapp/images/fieldlookup.js
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/images/webapp/images/fieldlookup.js?rev=1065994&r1=1065993&r2=1065994&view=diff
==============================================================================
--- ofbiz/trunk/framework/images/webapp/images/fieldlookup.js (original)
+++ ofbiz/trunk/framework/images/webapp/images/fieldlookup.js Tue Feb  1 11:15:10 2011
@@ -655,7 +655,7 @@ function set_duration_value (value) {
     if(GLOBAL_LOOKUP_REF.getReference(ACTIVATED_LOOKUP)){
         obj_caller.target = GLOBAL_LOOKUP_REF.getReference(ACTIVATED_LOOKUP).target;
     }
-    else{
+    else {
         obj_caller.target = jQuery(obj_caller.targetW);
     }    
     var target = obj_caller.target;
@@ -668,14 +668,13 @@ function set_value (value) {
     if(GLOBAL_LOOKUP_REF.getReference(ACTIVATED_LOOKUP)){
         obj_caller.target = GLOBAL_LOOKUP_REF.getReference(ACTIVATED_LOOKUP).target;
     }
-    else{
+    else {
         obj_caller.target = jQuery(obj_caller.targetW);
-    }    
+    }
+    
     var target = obj_caller.target;
-
     write_value(value, target);
-    field = jQuery("#" + target.attr('id'));    
-    
+
     closeLookup();
 }
 // function passing selected value to calling window
@@ -684,7 +683,7 @@ function set_values (value, value2) {
         obj_caller.target = GLOBAL_LOOKUP_REF.getReference(ACTIVATED_LOOKUP).target;
         obj_caller.target2 = GLOBAL_LOOKUP_REF.getReference(ACTIVATED_LOOKUP).target2;
     }
-    else{
+    else {
         obj_caller.target = jQuery(obj_caller.targetW);        
     }
     var target = obj_caller.target;