svn commit: r1067097 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1067097 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java

jleroux@apache.org
Author: jleroux
Date: Fri Feb  4 06:45:00 2011
New Revision: 1067097

URL: http://svn.apache.org/viewvc?rev=1067097&view=rev
Log:
Fix a bug "Omission in the OrderService" reported by Sergei Biletnikov at (https://issues.apache.org/jira/browse/OFBIZ-4165) - OFBIZ-4165

I found a problem when I update an order items with more than 2 shipping groups, the result of the updating without any changes is the duplication of the shipping fee and Sales tax for all order items except of first order item.

Sergei's patch was wrongly formatted but accurate, applied by hand

Modified:
    ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java?rev=1067097&r1=1067096&r2=1067097&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/order/OrderServices.java Fri Feb  4 06:45:00 2011
@@ -3993,7 +3993,7 @@ public class OrderServices {
         String shipGroupSeqId = null;
         long groupIndex = cart.getShipInfoSize();
         for (long itr = 1; itr <= groupIndex; itr++) {
-            shipGroupSeqId = UtilFormatOut.formatPaddedNumber(1, 5);
+            shipGroupSeqId = UtilFormatOut.formatPaddedNumber(itr, 5);
             List<GenericValue> removeList = new ArrayList<GenericValue>();
             for (GenericValue stored: (List<GenericValue>)toStore) {
                 if ("OrderAdjustment".equals(stored.getEntityName())) {