svn commit: r1085774 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1085774 - /ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml

jleroux@apache.org
Author: jleroux
Date: Sat Mar 26 17:42:55 2011
New Revision: 1085774

URL: http://svn.apache.org/viewvc?rev=1085774&view=rev
Log:
Inspired by Paul Foxworthy's patch at "createAgreementItem doesn't set agreementId in result" https://issues.apache.org/jira/browse/OFBIZ-4224 - OFBIZ-4224

The createAgreementItem service in applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml doesn't set the agreementId in the result map properly.

Line 129 is
<field-to-result field="agreementId" result-name="agreementId"/>
and should be
<field-to-result field="parameters.agreementId" result-name="agreementId"/>

JLR: minor detail I rather used newEntity.agreementId like in the line below newEntity.agreementItemSeqId

Modified:
    ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml

Modified: ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml?rev=1085774&r1=1085773&r2=1085774&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml (original)
+++ ofbiz/trunk/applications/accounting/script/org/ofbiz/accounting/agreement/AgreementServices.xml Sat Mar 26 17:42:55 2011
@@ -126,7 +126,7 @@ under the License.
             <set from-field="parameters.agreementItemSeqId" field="newEntity.agreementItemSeqId"/>
         </else>
         </if-empty>
-        <field-to-result field="agreementId" result-name="agreementId"/>
+        <field-to-result field="newEntity.agreementId" result-name="agreementId"/>
         <field-to-result field="newEntity.agreementItemSeqId" result-name="agreementItemSeqId"/>
 
         <!-- finally create the record (should not exist already)-->