svn commit: r1095032 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java

[adrianc]

Author: adrianc
Date: Tue Apr 19 11:20:39 2011
New Revision: 1095032

URL: http://svn.apache.org/viewvc?rev=1095032&view=rev
Log:
Small fixup for ServiceDispatcher.java - truncate log messages longer than 10K. Some service results can be multiple MB in size, resulting in huge log entries (4 MB in entity reference page).

Modified:
    ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java

Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java?rev=1095032&r1=1095031&r2=1095032&view=diff
==============================================================================
--- ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java (original)
+++ ofbiz/trunk/framework/service/src/org/ofbiz/service/ServiceDispatcher.java Tue Apr 19 11:20:39 2011
@@ -596,9 +596,19 @@ public class ServiceDispatcher {
 
         long timeToRun = System.currentTimeMillis() - serviceStartTime;
         if (Debug.timingOn() && timeToRun > 50) {
-            Debug.logTiming("Sync service [" + localName + "/" + modelService.name + "] finished in [" + timeToRun + "] milliseconds with response [" + result.toString() + "]", module);
-        } else if (timeToRun > 200) {
-            Debug.logInfo("Sync service [" + localName + "/" + modelService.name + "] finished in [" + timeToRun + "] milliseconds with response [" + result.toString() + "]", module);
+            // Sanity check - some service results can be multiple MB in size. Limit message size to 10K.
+            String resultStr = result.toString();
+            if (resultStr.length() > 10240) {
+                resultStr = resultStr.substring(0, 10226) + "...[truncated]";
+            }
+            Debug.logTiming("Sync service [" + localName + "/" + modelService.name + "] finished in [" + timeToRun + "] milliseconds with response [" + resultStr + "]", module);
+        } else if (timeToRun > 200 && Debug.infoOn()) {
+            // Sanity check - some service results can be multiple MB in size. Limit message size to 10K.
+            String resultStr = result.toString();
+            if (resultStr.length() > 10240) {
+                resultStr = resultStr.substring(0, 10226) + "...[truncated]";
+            }
+            Debug.logInfo("Sync service [" + localName + "/" + modelService.name + "] finished in [" + timeToRun + "] milliseconds with response [" + resultStr + "]", module);
         }
 
         return result;