svn commit: r1210211 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1210211 - /ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java

jleroux@apache.org
Author: jleroux
Date: Sun Dec  4 20:51:44 2011
New Revision: 1210211

URL: http://svn.apache.org/viewvc?rev=1210211&view=rev
Log:
A patch from Sergei Biletnikov  https://issues.apache.org/jira/browse/OFBIZ-4608 "Shopping cart update problem for several shipping groups"


That is pretty simple bug, but causes a big problems during the order editing in case if you have more than 1 shipping group, please, just look at the patch, it is very simple. I found the similar bug in the system already before, which was fixed successfully.

Also, this bug exists in the version 10.04, could you fix it there?

Modified:
    ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java

Modified: ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java?rev=1210211&r1=1210210&r2=1210211&view=diff
==============================================================================
--- ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java (original)
+++ ofbiz/trunk/applications/order/src/org/ofbiz/order/shoppingcart/ShoppingCartEvents.java Sun Dec  4 20:51:44 2011
@@ -1411,7 +1411,7 @@ public class ShoppingCartEvents {
                 Debug.logError(e, module);
             }
             for (long itr = 1; itr <= groupIndex; itr++) {
-                shipGroupSeqId = UtilFormatOut.formatPaddedNumber(1, 5);
+                shipGroupSeqId = UtilFormatOut.formatPaddedNumber(itr, 5);
                 List<GenericValue> duplicateAdjustmentList = new ArrayList<GenericValue>();
                 for (GenericValue adjustment: orderAdjustmentList) {
                     if ("PROMOTION_ADJUSTMENT".equals(adjustment.get("orderAdjustmentTypeId"))) {