svn commit: r1231649 - /ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java

Author: jleroux
Date: Sun Jan 15 10:42:15 2012
New Revision: 1231649

URL: http://svn.apache.org/viewvc?rev=1231649&view=rev
Log:
After the discussion this morning, revert the 1st patch of https://issues.apache.org/jira/browse/OFBIZ-4629 "The Status of PicklistItem never changes from PICKITEM_PENDING to PICKITEM_COMPLETED."

We agreed the change in VerifyPickSession.complete method was useless since it exists also in PackingSessionLine.issueItemToShipment and VerifyPickSessionRow.issueItemToShipment methods

Modified:
    ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java

Modified: ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java?rev=1231649&r1=1231648&r2=1231649&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java (original)
+++ ofbiz/trunk/applications/product/src/org/ofbiz/shipment/verify/VerifyPickSession.java Sun Jan 15 10:42:15 2012
@@ -307,21 +307,6 @@ public class VerifyPickSession implement
         this.issueItemsToShipment(shipmentId, locale);
         this.updateProduct();
 
-        // Set PicklistItem to Complete
-        List<GenericValue> picklistItems = this.getDelegator().findByAnd("PicklistItem", UtilMisc.toMap("orderId", orderId));
-        for (GenericValue item : picklistItems) {
-            Map<String, Object> setPicklistItemToCompleteCtx = FastMap.newInstance();
-            setPicklistItemToCompleteCtx.put("picklistBinId", item.get("picklistBinId"));
-            setPicklistItemToCompleteCtx.put("orderId", orderId);
-            setPicklistItemToCompleteCtx.put("orderItemSeqId", item.get("orderItemSeqId"));
-            setPicklistItemToCompleteCtx.put("shipGroupSeqId", item.get("shipGroupSeqId"));
-            setPicklistItemToCompleteCtx.put("inventoryItemId", item.get("inventoryItemId"));
-            setPicklistItemToCompleteCtx.put("quantity", item.get("quantity"));
-            setPicklistItemToCompleteCtx.put("itemStatusId", "PICKITEM_COMPLETED");
-            setPicklistItemToCompleteCtx.put("userLogin", this.getUserLogin());
-            this.getDispatcher().runSync("setPicklistItemToComplete", setPicklistItemToCompleteCtx);
-        }
-
         // Update the shipment status to Picked, this will trigger createInvoicesFromShipment and finally a invoice will be created
         Map<String, Object> updateShipmentCtx = FastMap.newInstance();
         updateShipmentCtx.put("shipmentId", shipmentId);