svn commit: r1527754 - /ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java

[doogie-3]

Author: doogie
Date: Mon Sep 30 19:57:13 2013
New Revision: 1527754

URL: http://svn.apache.org/r1527754
Log:
There are some controller.xml entries that have a name of "none"; those
should be preferred as valid responses, instead of always assuming that
none means do nothing.

This fixes the issue reported in OFBIZ-5304.

Modified:
    ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java

Modified: ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java?rev=1527754&r1=1527753&r2=1527754&view=diff
==============================================================================
--- ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java (original)
+++ ofbiz/trunk/framework/webapp/src/org/ofbiz/webapp/control/RequestHandler.java Mon Sep 30 19:57:13 2013
@@ -451,10 +451,11 @@ public class RequestHandler {
         ConfigXMLReader.RequestResponse eventReturnBasedRequestResponse;
         if (eventReturn == null) {
             eventReturnBasedRequestResponse = null;
-        } else if (eventReturn.equals("none")) {
-            eventReturnBasedRequestResponse = ConfigXMLReader.emptyNoneRequestResponse;
         } else {
             eventReturnBasedRequestResponse = requestMap.requestResponseMap.get(eventReturn);
+            if (eventReturnBasedRequestResponse == null && eventReturn.equals("none")) {
+                eventReturnBasedRequestResponse = ConfigXMLReader.emptyNoneRequestResponse;
+            }
         }
         if (eventReturnBasedRequestResponse != null) {
             //String eventReturnBasedResponse = requestResponse.value;