svn commit: r1531030 - /ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml

Author: jleroux
Date: Thu Oct 10 15:43:42 2013
New Revision: 1531030

URL: http://svn.apache.org/r1531030
Log:
A patch from Christian Carlow for "Shipment cancellation doesn't revert inventory accounting quantity total" https://issues.apache.org/jira/browse/OFBIZ-5314

When order items are issued to a shipment, the accounting_quantity_total
for the corresponding inventory records are updated but afterwards when
the shipment is cancelled, the accounting_quantity_total is not reverted
back to the original values.  Is this a bug or is there a reason the
quantity is not reverted?

The problem is that when I try to create another shipment and issue the
same quantity, I receive the following error:

The following error occurs when I try to issue the same previously
cancelled quantity to a newly created shipment:

Error:<br/> ERROR: Could not complete the Issue OrderItemShipGrpInvRes
to Shipment
[file:/dev/apache-ofbiz-11.04.02/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml#issueOrderItemShipGrpInvResToShipment]
process [problem removing the orderItemShipGrpInvRes value: The current
transaction is marked for rollback, not beginning a new transaction and
aborting current operation; the rollbackOnly was caused by: Error in
simple-method [Create an accounting transactions for a sales shipment
issuance (D: INVENTORY_ACCOUNT, C: COGS_ACCOUNT)
[file:/home/stan/dev/apache-ofbiz-11.04.02/applications/accounting/script/org/ofbiz/accounting/ledger/GeneralLedgerServices.xml#createAcctgTransForSalesShipmentIssuance]]:
; {Could not find enough accounting inventory for product DOUGH;
remaining quantity: 1}] <br/> <br/>

The service is looking for inventory_item records with an
accounting_quantity_total > 0 but finds none because the quantity was
decremented to 0 from the cancelled shipment issuance.


Modified:
    ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml

Modified: ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml?rev=1531030&r1=1531029&r2=1531030&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml (original)
+++ ofbiz/trunk/applications/product/script/org/ofbiz/shipment/issuance/IssuanceServices.xml Thu Oct 10 15:43:42 2013
@@ -596,6 +596,7 @@ under the License.
         <set from-field="itemIssuance.itemIssuanceId" field="createDetailMap.itemIssuanceId"/>
         <set from-field="toCancelQuantity" field="createDetailMap.availableToPromiseDiff"/>
         <set from-field="toCancelQuantity" field="createDetailMap.quantityOnHandDiff"/>
+        <set from-field="toCancelQuantity" field="createDetailMap.accountingQuantityDiff"/>
         <call-service service-name="createInventoryItemDetail" in-map-name="createDetailMap"/>
 
         <!-- reassign inventory reservations  -->