Author: jleroux
Date: Mon Dec 22 09:15:03 2014 New Revision: 1647267 URL: http://svn.apache.org/r1647267 Log: "Applied fix from trunk for revision: 1647266" ------------------------------------------------------------------------ r1647266 | jleroux | 2014-12-22 10:13:12 +0100 (lun. 22 déc. 2014) | 5 lignes A patch from Deepak for "Incorrect use of if-has-permission tag" https://issues.apache.org/jira/browse/OFBIZ-5920 Deepak: here is the patch for this issue, found some more places where if-has-permission tag used in different way, will create a new ticket to fix the if-has-permission tags and will used the consistent pattern. jleroux: I wonder if this commit does not fix some other already reported issues, anyway it's good! ------------------------------------------------------------------------ Modified: ofbiz/branches/release13.07/ (props changed) ofbiz/branches/release13.07/applications/humanres/widget/PersonTrainingScreens.xml ofbiz/branches/release13.07/applications/workeffort/widget/CalendarScreens.xml ofbiz/branches/release13.07/specialpurpose/ecommerce/widget/ForumScreens.xml Propchange: ofbiz/branches/release13.07/ ------------------------------------------------------------------------------ --- svn:mergeinfo (original) +++ svn:mergeinfo Mon Dec 22 09:15:03 2014 @@ -5,4 +5,4 @@ /ofbiz/branches/jquery:952958-1044489 /ofbiz/branches/multitenant20100310:921280-927264 /ofbiz/branches/release12.04:1557118 -/ofbiz/trunk:1506269,1506499,1506504,1506828,1509164,1510042,1511279,1512376,1512573,1516094,1517629,1517702,1517780,1517947,1518336,1518950,1519245,1519999,1520319,1520321,1520326,1524361,1524676,1524704,1524769,1524835,1524950,1525523,1526276,1526387,1526463,1527212,1527254,1527609,1527626,1527810,1528144,1528146,1528149,1528298,1529412,1529418,1529588,1530273,1530634,1530876,1530972,1530976,1531848,1532342,1532366,1533542,1533839,1535961,1536170,1536656,1537023,1537086,1537179,1537996,1538096,1539147,1539156,1539781,1542264,1542388,1542442,1543744,1543766,1543781,1543994,1544444,1547548,1548143,1549015,1550255,1550258,1550515,1551585,1551744,1552149,1552290,1552500,1552901,1552908,1554064,1554242,1554265,1554290,1554373,1554536,1554681,1554685,1554706,1554764,1554787,1555142,1557409-1557410,1557427,1557440,1557443,1557447,1557456-1557457,1557462,1557593,1558145,1558241,1558373,1558774,1559814,1560048,1560056,1560176,1560203,1560205,1560699,1561286,1561290,1561305,1561311,1561327, 1561467,1562767,1563238,1563683,1563958,1564111,1564113,1564463,1564473,1564493,1566096,1566273,1569078,1569743,1570611,1570622,1570639-1570640,1571207,1571219,1571247,1573161,1573498,1573639,1574019,1574201,1574404,1575508,1576259,1576331,1576378,1576506,1576511,1576757,1576839,1577268,1577744,1579155,1579161,1579277,1579309,1580455,1580850,1581386,1581972,1581997,1582762,1583040,1583427-1583428,1583551,1583674,1583681,1583689,1583696,1584873,1585033,1585574,1585958-1585959,1586987,1587841,1587843,1588733,1589589,1589602,1589606,1589612,1589625,1589669,1592530,1592588,1592745,1592977,1593902,1593908,1593952,1597239,1597464,1598113,1598327,1598475,1598544,1598913,1603439,1603732,1603739,1604357,1604363,1604522,1604554,1605029,1605269,1605348,1605354,1605707,1607457,1608355,1608495,1608526,1608698,1609047,1609065,1609076,1609087,1609149,1609155,1609167,1609184,1609389,1609394,1609398,1609406,1609418,1609885,1609889,1610355,1610420,1610425,1610685,1610918,1610925,1611321,1612190,16122 02,1613121,1614019,1614025,1614280,1614355,1614366,1614556,1615296-1615297,1616272,1616684,1616940,1617229,1617473,1617480,1617936,1617938,1618395,1618397,1618570,1618831,1619087,1619098,1619300,1621335,1621363,1621413,1621436,1621438-1621439,1621442,1621599,1621683,1622050,1622170,1622672,1623370,1624538,1624767,1624809,1624817,1626797,1627230,1627763,1628096,1628130,1628937,1628940,1629382,1629391,1629426,1631203,1631299-1631300,1632764,1632793,1633100,1633188,1633550,1636864,1637883,1639606,1639835,1639840-1639841,1639846,1639863,1639887,1640288,1640299,1640515,1640717,1641066,1641131,1641165,1641548,1641804,1642423,1643341,1644904,1645950,1646204,1646935,1646977,1646984 +/ofbiz/trunk:1506269,1506499,1506504,1506828,1509164,1510042,1511279,1512376,1512573,1516094,1517629,1517702,1517780,1517947,1518336,1518950,1519245,1519999,1520319,1520321,1520326,1524361,1524676,1524704,1524769,1524835,1524950,1525523,1526276,1526387,1526463,1527212,1527254,1527609,1527626,1527810,1528144,1528146,1528149,1528298,1529412,1529418,1529588,1530273,1530634,1530876,1530972,1530976,1531848,1532342,1532366,1533542,1533839,1535961,1536170,1536656,1537023,1537086,1537179,1537996,1538096,1539147,1539156,1539781,1542264,1542388,1542442,1543744,1543766,1543781,1543994,1544444,1547548,1548143,1549015,1550255,1550258,1550515,1551585,1551744,1552149,1552290,1552500,1552901,1552908,1554064,1554242,1554265,1554290,1554373,1554536,1554681,1554685,1554706,1554764,1554787,1555142,1557409-1557410,1557427,1557440,1557443,1557447,1557456-1557457,1557462,1557593,1558145,1558241,1558373,1558774,1559814,1560048,1560056,1560176,1560203,1560205,1560699,1561286,1561290,1561305,1561311,1561327, 1561467,1562767,1563238,1563683,1563958,1564111,1564113,1564463,1564473,1564493,1566096,1566273,1569078,1569743,1570611,1570622,1570639-1570640,1571207,1571219,1571247,1573161,1573498,1573639,1574019,1574201,1574404,1575508,1576259,1576331,1576378,1576506,1576511,1576757,1576839,1577268,1577744,1579155,1579161,1579277,1579309,1580455,1580850,1581386,1581972,1581997,1582762,1583040,1583427-1583428,1583551,1583674,1583681,1583689,1583696,1584873,1585033,1585574,1585958-1585959,1586987,1587841,1587843,1588733,1589589,1589602,1589606,1589612,1589625,1589669,1592530,1592588,1592745,1592977,1593902,1593908,1593952,1597239,1597464,1598113,1598327,1598475,1598544,1598913,1603439,1603732,1603739,1604357,1604363,1604522,1604554,1605029,1605269,1605348,1605354,1605707,1607457,1608355,1608495,1608526,1608698,1609047,1609065,1609076,1609087,1609149,1609155,1609167,1609184,1609389,1609394,1609398,1609406,1609418,1609885,1609889,1610355,1610420,1610425,1610685,1610918,1610925,1611321,1612190,16122 02,1613121,1614019,1614025,1614280,1614355,1614366,1614556,1615296-1615297,1616272,1616684,1616940,1617229,1617473,1617480,1617936,1617938,1618395,1618397,1618570,1618831,1619087,1619098,1619300,1621335,1621363,1621413,1621436,1621438-1621439,1621442,1621599,1621683,1622050,1622170,1622672,1623370,1624538,1624767,1624809,1624817,1626797,1627230,1627763,1628096,1628130,1628937,1628940,1629382,1629391,1629426,1631203,1631299-1631300,1632764,1632793,1633100,1633188,1633550,1636864,1637883,1639606,1639835,1639840-1639841,1639846,1639863,1639887,1640288,1640299,1640515,1640717,1641066,1641131,1641165,1641548,1641804,1642423,1643341,1644904,1645950,1646204,1646935,1646977,1646984,1647266 Modified: ofbiz/branches/release13.07/applications/humanres/widget/PersonTrainingScreens.xml URL: http://svn.apache.org/viewvc/ofbiz/branches/release13.07/applications/humanres/widget/PersonTrainingScreens.xml?rev=1647267&r1=1647266&r2=1647267&view=diff ============================================================================== --- ofbiz/branches/release13.07/applications/humanres/widget/PersonTrainingScreens.xml (original) +++ ofbiz/branches/release13.07/applications/humanres/widget/PersonTrainingScreens.xml Mon Dec 22 09:15:03 2014 @@ -139,7 +139,7 @@ <if-compare field="workEffort.currentStatusId" operator="not-equals" value="CAL_CANCELLED"/> </and> <if-empty field="workEffort"/> - <if-has-permission permission="WORKEFFORTMGR" action="ADMIN"/> + <if-has-permission permission="WORKEFFORTMGR" action="_ADMIN"/> </or> <if-compare field="parameters.form" operator="equals" value="edit"/> </and> Modified: ofbiz/branches/release13.07/applications/workeffort/widget/CalendarScreens.xml URL: http://svn.apache.org/viewvc/ofbiz/branches/release13.07/applications/workeffort/widget/CalendarScreens.xml?rev=1647267&r1=1647266&r2=1647267&view=diff ============================================================================== --- ofbiz/branches/release13.07/applications/workeffort/widget/CalendarScreens.xml (original) +++ ofbiz/branches/release13.07/applications/workeffort/widget/CalendarScreens.xml Mon Dec 22 09:15:03 2014 @@ -167,7 +167,7 @@ under the License. <if-compare field="isCalOwner" operator="equals" value="true" type="Boolean" /> </and> <if-empty field="workEffort" /> - <if-has-permission permission="WORKEFFORTMGR" action="ADMIN" /> + <if-has-permission permission="WORKEFFORTMGR" action="_ADMIN" /> </or> </condition> <actions> Modified: ofbiz/branches/release13.07/specialpurpose/ecommerce/widget/ForumScreens.xml URL: http://svn.apache.org/viewvc/ofbiz/branches/release13.07/specialpurpose/ecommerce/widget/ForumScreens.xml?rev=1647267&r1=1647266&r2=1647267&view=diff ============================================================================== --- ofbiz/branches/release13.07/specialpurpose/ecommerce/widget/ForumScreens.xml (original) +++ ofbiz/branches/release13.07/specialpurpose/ecommerce/widget/ForumScreens.xml Mon Dec 22 09:15:03 2014 @@ -85,7 +85,7 @@ under the License. <label style="head1" text="${uiLabelMap.EcommerceMessageListForForum} ${forum.description}"/> <section> <condition> - <if-has-permission permission="CONTENTMGR" action="CREATE"/> + <if-has-permission permission="CONTENTMGR" action="_CREATE"/> </condition> <widgets> <!-- old link converted during URLs securing, seems busted... no time to look at detail...--> @@ -137,7 +137,7 @@ under the License. </container> <section> <condition> - <if-has-permission permission="CONTENTMGR" action="CREATE"/> + <if-has-permission permission="CONTENTMGR" action="_CREATE"/> </condition> <widgets> <label style="blogheader">${uiLabelMap.EcommerceBlogAddResponse}</label> |
Free forum by Nabble | Edit this page |