svn commit: r1662084 - /ofbiz/trunk/framework/service/src/org/ofbiz/service/group/ServiceGroupReader.java

[adrianc]

Author: adrianc
Date: Tue Feb 24 19:00:36 2015
New Revision: 1662084

URL: http://svn.apache.org/r1662084
Log:
Added null check to avoid intermittent NPE - https://issues.apache.org/jira/browse/OFBIZ-5879.

Modified:
    ofbiz/trunk/framework/service/src/org/ofbiz/service/group/ServiceGroupReader.java

Modified: ofbiz/trunk/framework/service/src/org/ofbiz/service/group/ServiceGroupReader.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/org/ofbiz/service/group/ServiceGroupReader.java?rev=1662084&r1=1662083&r2=1662084&view=diff
==============================================================================
--- ofbiz/trunk/framework/service/src/org/ofbiz/service/group/ServiceGroupReader.java (original)
+++ ofbiz/trunk/framework/service/src/org/ofbiz/service/group/ServiceGroupReader.java Tue Feb 24 19:00:36 2015
@@ -75,6 +75,10 @@ public class ServiceGroupReader {
 
         for (Element group: UtilXml.childElementList(rootElement, "group")) {
             String groupName = group.getAttribute("name");
+            if (groupName == null || groupName.isEmpty()) {
+                Debug.logError("XML Parsing error: <group> element 'name' attribute null or empty", module);
+                continue;
+            }
             groupsCache.put(groupName, new GroupModel(group));
             numDefs++;
         }