svn commit: r1676303 - /ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java

[doogie-3]

Author: doogie
Date: Mon Apr 27 15:25:00 2015
New Revision: 1676303

URL: http://svn.apache.org/r1676303
Log:
Fix dumb compile errors in this file; please, let's be careful.  Note
the EntityQuery import; this was due to this class being added, but not
imported, which is an obvious error.

Also, if you don't understand generics, please ask.  The changes listed
here are very basic compile errors.

The general problems discovered here are due to the class *not being
compiled* by default.  If you change something, at least attempt to see
if it has an effect.  Compile errors are just plain bad.

Modified:
    ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java

Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java?rev=1676303&r1=1676302&r2=1676303&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java (original)
+++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java Mon Apr 27 15:25:00 2015
@@ -39,6 +39,7 @@ import org.ofbiz.base.util.string.Flexib
 import org.ofbiz.entity.Delegator;
 import org.ofbiz.entity.GenericEntityException;
 import org.ofbiz.entity.GenericValue;
+import org.ofbiz.entity.util.EntityQuery;
 import org.ofbiz.entity.util.EntityUtilProperties;
 import org.ofbiz.order.order.OrderReadHelper;
 import org.ofbiz.order.shoppingcart.ShoppingCart;
@@ -89,7 +90,7 @@ public class PayflowPro {
             isPayPal = true;
         }
 
-        Map<String, String> data = new HashMap<String, Object>();
+        Map<String, String> data = new HashMap<String, String>();
 
         boolean isReAuth = false;
         if (isPayPal) {
@@ -432,7 +433,7 @@ public class PayflowPro {
                     "AccountingPayPalShoppingCartIsEmpty", locale));
         }
 
-        Map<String, String> data = new HashMap<String, Object>();
+        Map<String, String> data = new HashMap<String, String>();
 
         data.put("TRXTYPE", "O");
         data.put("TENDER", "P");
@@ -542,7 +543,7 @@ public class PayflowPro {
         String paymentGatewayConfigId = payPalPaymentSetting.getString("paymentGatewayConfigId");
         String configString = "payment.properties";
 
-        Map<String, String> data = new HashMap<String, Object>();
+        Map<String, String> data = new HashMap<String, String>();
         data.put("TRXTYPE", "O");
         data.put("TENDER", "P");
         data.put("ACTION", "G");
@@ -621,7 +622,7 @@ public class PayflowPro {
         }
         BigDecimal processAmount = paymentPref.getBigDecimal("maxAmount");
 
-        Map<String, String> data = new HashMap<String, Object>();
+        Map<String, String> data = new HashMap<String, String>();
         data.put("TRXTYPE", "O");
         data.put("TENDER", "P");
         data.put("PAYERID", payPalPaymentMethod.getString("payerId"));
@@ -669,7 +670,7 @@ public class PayflowPro {
 
     private static Map<String, String> parseResponse(String resp) {
         Debug.logInfo("Verisign response string: " + resp, module);
-        Map<String, String> parameters = new HashMap<String, Object>();
+        Map<String, String> parameters = new HashMap<String, String>();
         List<String> params = StringUtil.split(resp, "&");
         for (String str : params) {
             if (str.length() > 0) {

[Adam Heath-2]

Replying to my own commit; please, double check your changes.  The
problems I fixed below are just sad.

ps: I'm working on maven profiles, that detect optional jars.  I went
and fetched payflow.jar, and when I made it available, I got compile errors.

On 04/27/2015 10:25 AM, [hidden email] wrote:

> Author: doogie
> Date: Mon Apr 27 15:25:00 2015
> New Revision: 1676303
>
> URL: http://svn.apache.org/r1676303
> Log:
> Fix dumb compile errors in this file; please, let's be careful.  Note
> the EntityQuery import; this was due to this class being added, but not
> imported, which is an obvious error.
>
> Also, if you don't understand generics, please ask.  The changes listed
> here are very basic compile errors.
>
> The general problems discovered here are due to the class *not being
> compiled* by default.  If you change something, at least attempt to see
> if it has an effect.  Compile errors are just plain bad.
>
> Modified:
>      ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
>
> Modified: ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java
> URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java?rev=1676303&r1=1676302&r2=1676303&view=diff
> ==============================================================================
> --- ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java (original)
> +++ ofbiz/trunk/applications/accounting/src/org/ofbiz/accounting/thirdparty/verisign/PayflowPro.java Mon Apr 27 15:25:00 2015
> @@ -39,6 +39,7 @@ import org.ofbiz.base.util.string.Flexib
>   import org.ofbiz.entity.Delegator;
>   import org.ofbiz.entity.GenericEntityException;
>   import org.ofbiz.entity.GenericValue;
> +import org.ofbiz.entity.util.EntityQuery;
>   import org.ofbiz.entity.util.EntityUtilProperties;
>   import org.ofbiz.order.order.OrderReadHelper;
>   import org.ofbiz.order.shoppingcart.ShoppingCart;
> @@ -89,7 +90,7 @@ public class PayflowPro {
>               isPayPal = true;
>           }
>  
> -        Map<String, String> data = new HashMap<String, Object>();
> +        Map<String, String> data = new HashMap<String, String>();
>  
>           boolean isReAuth = false;
>           if (isPayPal) {
> @@ -432,7 +433,7 @@ public class PayflowPro {
>                       "AccountingPayPalShoppingCartIsEmpty", locale));
>           }
>  
> -        Map<String, String> data = new HashMap<String, Object>();
> +        Map<String, String> data = new HashMap<String, String>();
>  
>           data.put("TRXTYPE", "O");
>           data.put("TENDER", "P");
> @@ -542,7 +543,7 @@ public class PayflowPro {
>           String paymentGatewayConfigId = payPalPaymentSetting.getString("paymentGatewayConfigId");
>           String configString = "payment.properties";
>  
> -        Map<String, String> data = new HashMap<String, Object>();
> +        Map<String, String> data = new HashMap<String, String>();
>           data.put("TRXTYPE", "O");
>           data.put("TENDER", "P");
>           data.put("ACTION", "G");
> @@ -621,7 +622,7 @@ public class PayflowPro {
>           }
>           BigDecimal processAmount = paymentPref.getBigDecimal("maxAmount");
>  
> -        Map<String, String> data = new HashMap<String, Object>();
> +        Map<String, String> data = new HashMap<String, String>();
>           data.put("TRXTYPE", "O");
>           data.put("TENDER", "P");
>           data.put("PAYERID", payPalPaymentMethod.getString("payerId"));
> @@ -669,7 +670,7 @@ public class PayflowPro {
>  
>       private static Map<String, String> parseResponse(String resp) {
>           Debug.logInfo("Verisign response string: " + resp, module);
> -        Map<String, String> parameters = new HashMap<String, Object>();
> +        Map<String, String> parameters = new HashMap<String, String>();
>           List<String> params = StringUtil.split(resp, "&");
>           for (String str : params) {
>               if (str.length() > 0) {
>
>