svn commit: r1676953 - /ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Start.java

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1676953 - /ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Start.java

adrianc
Author: adrianc
Date: Thu Apr 30 10:32:40 2015
New Revision: 1676953

URL: http://svn.apache.org/r1676953
Log:
Optimization: move array creation outside loop so it is created only once.

Modified:
    ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Start.java

Modified: ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Start.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Start.java?rev=1676953&r1=1676952&r2=1676953&view=diff
==============================================================================
--- ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Start.java (original)
+++ ofbiz/trunk/framework/start/src/org/ofbiz/base/start/Start.java Thu Apr 30 10:32:40 2015
@@ -301,6 +301,7 @@ public final class Start {
             throw new StartupException("Couldn't create NativeLibClassLoader", e);
         }
         Thread.currentThread().setContextClassLoader(classloader);
+        String[] argsArray = loaderArgs.toArray(new String[loaderArgs.size()]);
         synchronized (this.loaders) {
             for (Map<String, String> loaderMap : config.loaders) {
                 if (this.serverState.get() == ServerState.STOPPING) {
@@ -311,7 +312,7 @@ public final class Start {
                     Class<?> loaderClass = classloader.loadClass(loaderClassName);
                     StartupLoader loader = (StartupLoader) loaderClass.newInstance();
                     loaders.add(loader); // add before loading, so unload can occur if error during loading
-                    loader.load(config, loaderArgs.toArray(new String[loaderArgs.size()]));
+                    loader.load(config, argsArray);
                 } catch (ClassNotFoundException e) {
                     throw new StartupException(e.getMessage(), e);
                 } catch (InstantiationException e) {