svn commit: r1706698 - in /ofbiz/branches/release12.04/applications/party/widget/partymgr: PartyForms.xml PartyScreens.xml

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1706698 - in /ofbiz/branches/release12.04/applications/party/widget/partymgr: PartyForms.xml PartyScreens.xml

mbrohl
Author: mbrohl
Date: Sun Oct  4 16:38:53 2015
New Revision: 1706698

URL: http://svn.apache.org/viewvc?rev=1706698&view=rev
Log:
Manually applied patch for OFBIZ-6662: PartyRelationship.securityGroupId not added when adding a PartyRelationship.

When adding a PartyRelationship the value selected for SecurityGroupId is ignored as createPartyRelationship service expects the parameter to be named securityGroupId. The AddOtherPartyRelationship form incorrectly names the field groupId causing the value to be missed in the set-nonpk-fields call in applications/party/script/org/ofbiz/party/party/PartyServices.xml.

Thanks Forrest Rae for spotting this and providing the patch.

Modified:
    ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyForms.xml
    ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyScreens.xml

Modified: ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyForms.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyForms.xml?rev=1706698&r1=1706697&r2=1706698&view=diff
==============================================================================
--- ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyForms.xml (original)
+++ ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyForms.xml Sun Oct  4 16:38:53 2015
@@ -867,9 +867,9 @@ under the License.
         </field>
         <field name="fromDate"><date-time/></field>
         <field name="thruDate"><date-time/></field>
-        <field name="groupId" title="${uiLabelMap.CommonSecurityGroupId}">
+        <field name="securityGroupId" title="${uiLabelMap.CommonSecurityGroupId}">
             <drop-down allow-empty="true" text-size="60">
-                <entity-options entity-name="SecurityGroup" description="${description}">
+                <entity-options entity-name="SecurityGroup" key-field-name="groupId">
                     <entity-order-by field-name="description"/>
                 </entity-options>
             </drop-down>

Modified: ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyScreens.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyScreens.xml?rev=1706698&r1=1706697&r2=1706698&view=diff
==============================================================================
--- ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyScreens.xml (original)
+++ ofbiz/branches/release12.04/applications/party/widget/partymgr/PartyScreens.xml Sun Oct  4 16:38:53 2015
@@ -275,7 +275,6 @@ under the License.
                     <order-by field-name="partyRelationshipTypeId"/>
                     <order-by field-name="-fromDate"/>
                 </entity-condition>
-                <entity-condition entity-name="SecurityGroup" list="securityGroups"/>
             </actions>
             <widgets>
                 <decorator-screen name="CommonPartyDecorator" location="${parameters.mainDecoratorLocation}">