svn commit: r1739968 - /ofbiz/trunk/framework/base/dtd/ofbiz-component.xsd

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1739968 - /ofbiz/trunk/framework/base/dtd/ofbiz-component.xsd

jleroux@apache.org
Author: jleroux
Date: Tue Apr 19 17:56:07 2016
New Revision: 1739968

URL: http://svn.apache.org/viewvc?rev=1739968&view=rev
Log:
A patch from Pierre Smits for "Remove limitation regarding menu-name in ofbiz-component.xsd" https://issues.apache.org/jira/browse/OFBIZ-6667

Currently the following is in the ofbiz-component.xsd:
        <xs:attribute name="menu-name" default="main">
            <xs:simpleType>
                <xs:restriction base="xs:token">
                    <xs:enumeration value="main"/>
                    <xs:enumeration value="secondary"/>
                </xs:restriction>
            </xs:simpleType>
        </xs:attribute>

However, this is limiting the options that can be applied generates unnecessary errors when developers opt for another methodology.

Modified:
    ofbiz/trunk/framework/base/dtd/ofbiz-component.xsd

Modified: ofbiz/trunk/framework/base/dtd/ofbiz-component.xsd
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/base/dtd/ofbiz-component.xsd?rev=1739968&r1=1739967&r2=1739968&view=diff
==============================================================================
--- ofbiz/trunk/framework/base/dtd/ofbiz-component.xsd (original)
+++ ofbiz/trunk/framework/base/dtd/ofbiz-component.xsd Tue Apr 19 17:56:07 2016
@@ -184,15 +184,22 @@ under the License.
     </xs:element>
     <xs:attributeGroup name="attlist.webapp">
         <xs:attribute type="xs:string" name="name" use="required"/>
-        <xs:attribute type="xs:string" name="title"/>
+        <xs:attribute type="xs:string" name="title">
+            <xs:annotation>
+                <xs:documentation>
+                    This value is shown in the application menu, when no uiLabelMap is available.
+                </xs:documentation>
+            </xs:annotation>
+        </xs:attribute>
         <xs:attribute type="xs:string" name="description"/>
-        <xs:attribute name="menu-name" default="main">
-            <xs:simpleType>
-                <xs:restriction base="xs:token">
-                    <xs:enumeration value="main"/>
-                    <xs:enumeration value="secondary"/>
-                </xs:restriction>
-            </xs:simpleType>
+        <xs:attribute name="menu-name" use="optional" default="main">
+            <xs:annotation>
+                <xs:documentation>
+                    This value determines in which application menu the application is shown.
+                    For instance "secondary" is used by specialpurpose and webtools webapps to put their menu-names in the second menu.
+                    Note that not all OOTB themes use this "secondary" option, for instance Flat-Grey does not.
+                </xs:documentation>
+            </xs:annotation>
         </xs:attribute>
         <xs:attribute type="xs:string" name="position"/>
         <xs:attribute type="xs:string" name="server" use="required"/>