svn commit: r1761176 - in /ofbiz/trunk/applications: accounting/src/main/java/org/a
Locked
svn commit: r1761176 - in /ofbiz/trunk/applications: accounting/src/main/java/org/a
 
|
Author: jacopoc
Date: Sat Sep 17 10:11:59 2016 New Revision: 1761176 URL: http://svn.apache.org/viewvc?rev=1761176&view=rev Log: Improved: removed unused fields from a series of Java classes. (OFBIZ-7698) Thanks: Deepak Nigam for the report and Pradhan Yash Sharma for the patches. Modified: ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/ideal/IdealEvents.java ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/PermissionRecorder.java ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutEvents.java ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutHelper.java ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartServices.java ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppinglist/ShoppingListEvents.java ofbiz/trunk/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalConverter.java Modified: ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java (original) +++ ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceServices.java Sat Sep 17 10:11:59 2016 @@ -112,7 +112,6 @@ public class InvoiceServices { private static final int ROUNDING = UtilNumber.getBigDecimalRoundingMode("invoice.rounding"); private static final int TAX_DECIMALS = UtilNumber.getBigDecimalScale("salestax.calc.decimals"); private static final int TAX_ROUNDING = UtilNumber.getBigDecimalRoundingMode("salestax.rounding"); - public static final int TAX_CALC_SCALE = UtilNumber.getBigDecimalScale("salestax.calc.decimals"); private static final int INVOICE_ITEM_SEQUENCE_ID_DIGITS = 5; // this is the number of digits used for invoiceItemSeqId: 00001, 00002... public static final String resource = "AccountingUiLabels"; Modified: ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java (original) +++ ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/authorizedotnet/AuthorizeResponse.java Sat Sep 17 10:11:59 2016 @@ -34,8 +34,6 @@ public class AuthorizeResponse { public static final int CP_RESPONSE = 2; // status constants - public static final String APPROVED = "Approved"; - public static final String DECLINED = "Declined"; public static final String ERROR = "Error"; // positions of the result Modified: ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/ideal/IdealEvents.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/ideal/IdealEvents.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/ideal/IdealEvents.java (original) +++ ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/ideal/IdealEvents.java Sat Sep 17 10:11:59 2016 @@ -64,7 +64,6 @@ public class IdealEvents { public static final String resource = "AccountingUiLabels"; public static final String resourceErr = "AccountingErrorUiLabels"; - public static final String commonResource = "CommonUiLabels"; public static final String module = IdealEvents.class.getName(); private static int decimals = UtilNumber.getBigDecimalScale("invoice.decimals"); private static int rounding = UtilNumber.getBigDecimalRoundingMode("invoice.rounding"); Modified: ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java (original) +++ ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/thirdparty/orbital/OrbitalPaymentServices.java Sat Sep 17 10:11:59 2016 @@ -56,8 +56,6 @@ public class OrbitalPaymentServices { private static int rounding = UtilNumber.getBigDecimalRoundingMode("invoice.rounding"); public final static String resource = "AccountingUiLabels"; - public static String APPROVED = "Approved"; - public static String DECLINED = "Declined"; public static String ERROR = "Error"; public static final String BIN_VALUE = "000002"; Modified: ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/PermissionRecorder.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/PermissionRecorder.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/PermissionRecorder.java (original) +++ ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/content/PermissionRecorder.java Sat Sep 17 10:11:59 2016 @@ -35,9 +35,6 @@ import org.apache.ofbiz.entity.GenericVa */ public class PermissionRecorder { - public static final int PRE_PURPOSE = 0; - public static final int PRE_ROLE = 1; - public static final int WITH_ROLES = 2; protected boolean isOn = false; protected GenericValue userLogin; Modified: ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java (original) +++ ofbiz/trunk/applications/content/src/main/java/org/apache/ofbiz/content/webapp/ftl/RenderSubContentCacheTransform.java Sat Sep 17 10:11:59 2016 @@ -53,7 +53,6 @@ public class RenderSubContentCacheTransf public static final String module = RenderSubContentCacheTransform.class.getName(); public static final String [] upSaveKeyNames = {"globalNodeTrail"}; - public static final String [] saveKeyNames = {"contentId", "subContentId", "subDataResourceTypeId", "mimeTypeId", "whenMap", "locale", "wrapTemplateId", "encloseWrapText", "nullThruDatesOnly", "globalNodeTrail"}; @SuppressWarnings("unchecked") public Writer getWriter(final Writer out, Map args) { Modified: ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java (original) +++ ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/finaccount/FinAccountHelper.java Sat Sep 17 10:11:59 2016 @@ -51,7 +51,6 @@ public class FinAccountHelper { public static final BigDecimal ZERO = BigDecimal.ZERO.setScale(decimals, rounding); public static final String giftCertFinAccountTypeId = "GIFTCERT_ACCOUNT"; - public static final boolean defaultPinRequired = false; // pool of available characters for account codes, here numbers plus uppercase characters static char[] char_pool = new char[10+26]; Modified: ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java (original) +++ ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/order/OrderServices.java Sat Sep 17 10:11:59 2016 @@ -93,7 +93,6 @@ public class OrderServices { public static final String resource = "OrderUiLabels"; public static final String resource_error = "OrderErrorUiLabels"; public static final String resourceProduct = "ProductUiLabels"; - public static final String resourceCommon = "CommonUiLabels"; public static Map<String, String> salesAttributeRoleMap = new HashMap<String, String>(); public static Map<String, String> purchaseAttributeRoleMap = new HashMap<String, String>(); Modified: ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutEvents.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutEvents.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutEvents.java (original) +++ ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutEvents.java Sat Sep 17 10:11:59 2016 @@ -59,7 +59,6 @@ import org.apache.ofbiz.webapp.website.W public class CheckOutEvents { public static final String module = CheckOutEvents.class.getName(); - public static final String resource = "OrderUiLabels"; public static final String resource_error = "OrderErrorUiLabels"; public static String cartNotEmpty(HttpServletRequest request, HttpServletResponse response) { Modified: ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutHelper.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutHelper.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutHelper.java (original) +++ ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/CheckOutHelper.java Sat Sep 17 10:11:59 2016 @@ -71,7 +71,6 @@ import org.apache.ofbiz.service.ServiceU public class CheckOutHelper { public static final String module = CheckOutHelper.class.getName(); - public static final String resource = "OrderUiLabels"; public static final String resource_error = "OrderErrorUiLabels"; public static final int scale = UtilNumber.getBigDecimalScale("order.decimals"); Modified: ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java (original) +++ ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCart.java Sat Sep 17 10:11:59 2016 @@ -92,7 +92,6 @@ public class ShoppingCart implements Ite public static final int taxFinalScale = UtilNumber.getBigDecimalScale("salestax.final.decimals"); public static final int taxRounding = UtilNumber.getBigDecimalRoundingMode("salestax.rounding"); public static final BigDecimal ZERO = BigDecimal.ZERO; - public static final BigDecimal percentage = new BigDecimal("0.01"); public static final MathContext generalRounding = new MathContext(10); Modified: ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartServices.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartServices.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartServices.java (original) +++ ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppingcart/ShoppingCartServices.java Sat Sep 17 10:11:59 2016 @@ -61,7 +61,6 @@ import org.apache.ofbiz.service.ServiceU public class ShoppingCartServices { public static final String module = ShoppingCartServices.class.getName(); - public static final String resource = "OrderUiLabels"; public static final String resource_error = "OrderErrorUiLabels"; public static final MathContext generalRounding = new MathContext(10); Modified: ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppinglist/ShoppingListEvents.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppinglist/ShoppingListEvents.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppinglist/ShoppingListEvents.java (original) +++ ofbiz/trunk/applications/order/src/main/java/org/apache/ofbiz/order/shoppinglist/ShoppingListEvents.java Sat Sep 17 10:11:59 2016 @@ -65,7 +65,6 @@ import org.apache.ofbiz.webapp.website.W public class ShoppingListEvents { public static final String module = ShoppingListEvents.class.getName(); - public static final String resource = "OrderUiLabels"; public static final String resource_error = "OrderErrorUiLabels"; public static final String PERSISTANT_LIST_NAME = "auto-save"; Modified: ofbiz/trunk/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalConverter.java URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalConverter.java?rev=1761176&r1=1761175&r2=1761176&view=diff ============================================================================== --- ofbiz/trunk/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalConverter.java (original) +++ ofbiz/trunk/applications/workeffort/src/main/java/org/apache/ofbiz/workeffort/workeffort/ICalConverter.java Sat Sep 17 10:11:59 2016 @@ -106,7 +106,6 @@ public class ICalConverter { protected static final String module = ICalConverter.class.getName(); protected static final String partyIdXParamName = "X-ORG-APACHE-OFBIZ-PARTY-ID"; protected static final ProdId prodId = new ProdId("-//Apache OFBiz//Work Effort Calendar//EN"); - protected static final String workEffortIdParamName = "X-ORG-APACHE-OFBIZ-WORKEFFORT-ID"; protected static final String uidPrefix = "ORG-APACHE-OFBIZ-WE-"; protected static final String workEffortIdXPropName = "X-ORG-APACHE-OFBIZ-WORKEFFORT-ID"; protected static final String reminderXPropName = "X-ORG-APACHE-OFBIZ-REMINDER-ID"; |
«
Return to OFBiz - Commits
|
1 view|%1 views
| Free forum by Nabble | Edit this page |