svn commit: r1761972 - in /ofbiz/trunk/framework/catalina: ofbiz-component.xml src/main/java/org/apache/ofbiz/catalina/container/SSLImpl.java

[jacopoc]

Author: jacopoc
Date: Thu Sep 22 15:35:05 2016
New Revision: 1761972

URL: http://svn.apache.org/viewvc?rev=1761972&view=rev
Log:
Improved: removed the OFBiz legacy class (SSLImpl) that extended the Tomcat
default implementation (JSSEImplementation) in order to override the
getServerFactory(...) method; changed the "catalina" container configuration to
use the default implementation:
org.apache.tomcat.util.net.jsse.JSSEImplementation

The getServerFactory(...) method is only used by the old Tomcat BIO connectors,
that have been deprecated and have been removed since Tomcat 8.5.x; even if
OFBiz is still using Tomcat 8.0.x, it is already using the new NIO connectors.

Thanks: Mark Thomas (@Tomcat) for the useful details about Tomcat internals:
https://lists.apache.org/thread.html/108ab57cd3b65e15aaf2631f2aeb015c3446d544c9d98d1631d16349@%3Cusers.tomcat.apache.org%3E


Removed:
    ofbiz/trunk/framework/catalina/src/main/java/org/apache/ofbiz/catalina/container/SSLImpl.java
Modified:
    ofbiz/trunk/framework/catalina/ofbiz-component.xml

Modified: ofbiz/trunk/framework/catalina/ofbiz-component.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/catalina/ofbiz-component.xml?rev=1761972&r1=1761971&r2=1761972&view=diff
==============================================================================
--- ofbiz/trunk/framework/catalina/ofbiz-component.xml (original)
+++ ofbiz/trunk/framework/catalina/ofbiz-component.xml Thu Sep 22 15:35:05 2016
@@ -135,7 +135,7 @@ under the License.
             <property name="compression" value="on"/>
             <property name="compressableMimeType" value="text/html,text/xml,text/plain,text/javascript,text/css,application/json"/>
             <!-- SSL connector attributes -->
-            <property name="sslImplementationName" value="org.apache.ofbiz.catalina.container.SSLImpl"/>
+            <property name="sslImplementationName" value="org.apache.tomcat.util.net.jsse.JSSEImplementation"/>
             <property name="algorithm" value="SunX509"/>
             <!-- the clientAuth to "want" in order to receive certs from the client;
                 note that this isn't set this way by default because with certain browsers
@@ -202,7 +202,7 @@ under the License.
             <property name="xpoweredBy" value="false"/>
             <property name="compression" value="on"/>
             <property name="compressableMimeType" value="text/html,text/xml,text/plain,text/javascript,text/css,application/json"/>
-            <property name="sslImplementationName" value="org.apache.ofbiz.catalina.container.SSLImpl"/>
+            <property name="sslImplementationName" value="org.apache.tomcat.util.net.jsse.JSSEImplementation"/>
             <property name="algorithm" value="SunX509"/>
             <property name="keystoreFile" value="framework/base/config/ofbizssl.jks"/>
             <property name="keystorePass" value="changeit"/>