OFBiz › OFBiz - Commits

svn commit: r1764179 - in /ofbiz/branches: release13.07/applications/order/webapp/ordermgr/WEB-INF/ release13.07/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/ release13.07/specialpurpose/ecommerce/webapp/ecommerce/customer/ release14.12/applicatio...

_‹ Previous Topic Next Topic _›

Classic

List

Threaded

1 message

jleroux@apache.org

svn commit: r1764179 - in /ofbiz/branches: release13.07/applications/order/webapp/ordermgr/WEB-INF/ release13.07/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/ release13.07/specialpurpose/ecommerce/webapp/ecommerce/customer/ release14.12/applicatio...

Author: jleroux
Date: Mon Oct 10 20:31:06 2016
New Revision: 1764179

URL: http://svn.apache.org/viewvc?rev=1764179&view=rev
Log:
"Applied fix from trunk for revision: 1764158 " (path conflict handled by hand)
------------------------------------------------------------------------
r1764158 | jleroux | 2016-10-10 19:57:38 +0200 (lun. 10 oct. 2016) | 22 lignes

Fixed: deleteCustomerTaxAuthInfo page called from /ecommerce/control/viewprofile
(OFBIZ-4106)

As explained on dev ML, I prefers to remove the possibility of creating "Tax
Identifications and Exemptions". Because users would actually need to have the
ACCOUNTING_CREATE or ACCOUNTING_ADMIN permissions to do so (or higher admin
permissions) and opening the accounting (or total) admin right to a customer
seems not secure to me.

Moreover the same exists in party and it needs admin rights in both places,
so does not make sense in ecommerce IMO.

Sharan : The only case I can think of is that a customer may want to manage
their own tax info. For example if I know my VAT number or Tax number
- do I add it to my profile, or do I have to wait for it be verified and
completed by the accounting administrator?
Generally I think companies would want an accounting administrator to take
control of this type of tax and exemption information (rather than leave it up
to the customer themselves) as they will need to be responsible for it
and report on it to their tax authorities so they need to make sure it is correct.

Thanks: Michal Cukierman for report and Sharan for functional confirmation
------------------------------------------------------------------------

Also backports:
* r1764176: moves deleteCustomerTaxAuthInfo request from ecommerce to order
where it's only used
* r1764178: removes createCustomerTaxAuthInfo and updateCustomerTaxAuthInfo requests
which are now useless

Modified:
ofbiz/branches/release13.07/applications/order/webapp/ordermgr/WEB-INF/controller.xml
ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl
ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml
ofbiz/branches/release14.12/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
ofbiz/branches/release14.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl
ofbiz/branches/release15.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml
ofbiz/branches/release15.12/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
ofbiz/branches/release15.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl

Modified: ofbiz/branches/release13.07/applications/order/webapp/ordermgr/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release13.07/applications/order/webapp/ordermgr/WEB-INF/controller.xml?rev=1764179&r1=1764178&r2=1764179&view=diff
==============================================================================
--- ofbiz/branches/release13.07/applications/order/webapp/ordermgr/WEB-INF/controller.xml (original)
+++ ofbiz/branches/release13.07/applications/order/webapp/ordermgr/WEB-INF/controller.xml Mon Oct 10 20:31:06 2016
@@ -1876,6 +1876,13 @@ under the License.
<security https="true" auth="true"/>
<response name="success" type="view" value="orderreportlist"/>
</request-map>
+
+ <request-map uri="deleteCustomerTaxAuthInfo">
+ <security https="true" auth="true"/>
+ <event type="service" invoke="deletePartyTaxAuthInfo"/>
+ <response name="success" type="view" value="viewprofile"/>
+ <response name="error" type="view" value="viewprofile"/>
+ </request-map>

<view-map name="orderreportlist" type="screen" page="component://order/widget/ordermgr/OrderReportScreens.xml#OrderReportList"/>

Modified: ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml?rev=1764179&r1=1764178&r2=1764179&view=diff
==============================================================================
--- ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml (original)
+++ ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/WEB-INF/controller.xml Mon Oct 10 20:31:06 2016
@@ -995,25 +995,6 @@ under the License.
<response name="success" type="view" value="viewprofile"/>
</request-map>

- <request-map uri="createCustomerTaxAuthInfo">
- <security https="true" auth="true"/>
- <event type="service" invoke="createCustomerTaxAuthInfo"/>
- <response name="success" type="view" value="viewprofile"/>
- <response name="error" type="view" value="viewprofile"/>
- </request-map>
- <request-map uri="updateCustomerTaxAuthInfo">
- <security https="true" auth="true"/>
- <event type="service" invoke="updatePartyTaxAuthInfo"/>
- <response name="success" type="view" value="viewprofile"/>
- <response name="error" type="view" value="viewprofile"/>
- </request-map>
- <request-map uri="deleteCustomerTaxAuthInfo">
- <security https="true" auth="true"/>
- <event type="service" invoke="deletePartyTaxAuthInfo"/>
- <response name="success" type="view" value="viewprofile"/>
- <response name="error" type="view" value="viewprofile"/>
- </request-map>
-

<request-map uri="editcontactmech"><security https="true" auth="true"/><response name="success" type="view" value="editcontactmech"/></request-map>
<request-map uri="editcontactmechnosave"><security https="true" auth="true"/><response name="success" type="view" value="editcontactmech"/></request-map>

Modified: ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl
URL: http://svn.apache.org/viewvc/ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl?rev=1764179&r1=1764178&r2=1764179&view=diff
==============================================================================
--- ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl (original)
+++ ofbiz/branches/release13.07/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl Mon Oct 10 20:31:06 2016
@@ -334,21 +334,6 @@ under the License.
</div>
</div>

-<#-- ============================================================= -->
-<div class="screenlet">
- <h3>${uiLabelMap.PartyTaxIdentification}</h3>
- <div class="screenlet-body">
- <form method="post" action="<@ofbizUrl>createCustomerTaxAuthInfo</@ofbizUrl>" name="createCustTaxAuthInfoForm">
- <div>
- <input type="hidden" name="partyId" value="${party.partyId}"/>
- ${screens.render("component://order/widget/ordermgr/OrderEntryOrderScreens.xml#customertaxinfo")}
- <input type="submit" value="${uiLabelMap.CommonAdd}" class="smallSubmit"/>
- </div>
- </form>
- </div>
-</div>
-
-<#-- ============================================================= -->
<div class="screenlet">
<div class="boxlink">
<a href="<@ofbizUrl>changepassword</@ofbizUrl>" class="submenutextright">${uiLabelMap.PartyChangePassword}</a>

Modified: ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml?rev=1764179&r1=1764178&r2=1764179&view=diff
==============================================================================
--- ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml (original)
+++ ofbiz/branches/release14.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml Mon Oct 10 20:31:06 2016
@@ -1889,6 +1889,13 @@ under the License.
<response name="success" type="view" value="orderview"/>
<response name="error" type="view" value="orderview"/>
</request-map>
+
+ <request-map uri="deleteCustomerTaxAuthInfo">
+ <security https="true" auth="true"/>
+ <event type="service" invoke="deletePartyTaxAuthInfo"/>
+ <response name="success" type="view" value="viewprofile"/>
+ <response name="error" type="view" value="viewprofile"/>
+ </request-map>


<request-map uri="editcontactmech"><security https="true" auth="true"/><response name="success" type="view" value="editcontactmech"/></request-map>
<request-map uri="editcontactmechnosave"><security https="true" auth="true"/><response name="success" type="view" value="editcontactmech"/></request-map>

Modified: ofbiz/branches/release14.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl
URL: http://svn.apache.org/viewvc/ofbiz/branches/release14.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl?rev=1764179&r1=1764178&r2=1764179&view=diff
==============================================================================
--- ofbiz/branches/release14.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl (original)
+++ ofbiz/branches/release14.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl Mon Oct 10 20:31:06 2016
@@ -336,20 +336,6 @@ under the License.

<#-- ============================================================= -->
<div class="screenlet">
- <h3>${uiLabelMap.PartyTaxIdentification}</h3>
- <div class="screenlet-body">
- <form method="post" action="<@ofbizUrl>createCustomerTaxAuthInfo</@ofbizUrl>" name="createCustTaxAuthInfoForm">
- <div>
- <input type="hidden" name="partyId" value="${party.partyId}"/>
- ${screens.render("component://order/widget/ordermgr/OrderEntryOrderScreens.xml#customertaxinfo")}
- <input type="submit" value="${uiLabelMap.CommonAdd}" class="smallSubmit"/>
- </div>
- </form>
- </div>
-</div>
-
-<#-- ============================================================= -->
-<div class="screenlet">
<div class="boxlink">
<a href="<@ofbizUrl>changepassword</@ofbizUrl>" class="submenutextright">${uiLabelMap.PartyChangePassword}</a>
</div>

Modified: ofbiz/branches/release15.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml?rev=1764179&r1=1764178&r2=1764179&view=diff
==============================================================================
--- ofbiz/branches/release15.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml (original)
+++ ofbiz/branches/release15.12/applications/order/webapp/ordermgr/WEB-INF/controller.xml Mon Oct 10 20:31:06 2016
@@ -1895,6 +1895,13 @@ under the License.
<response name="success" type="view" value="orderview"/>
<response name="error" type="view" value="orderview"/>
</request-map>
+
+ <request-map uri="deleteCustomerTaxAuthInfo">
+ <security https="true" auth="true"/>
+ <event type="service" invoke="deletePartyTaxAuthInfo"/>
+ <response name="success" type="view" value="viewprofile"/>
+ <response name="error" type="view" value="viewprofile"/>
+ </request-map>


<request-map uri="editcontactmech"><security https="true" auth="true"/><response name="success" type="view" value="editcontactmech"/></request-map>
<request-map uri="editcontactmechnosave"><security https="true" auth="true"/><response name="success" type="view" value="editcontactmech"/></request-map>

Modified: ofbiz/branches/release15.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl
URL: http://svn.apache.org/viewvc/ofbiz/branches/release15.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl?rev=1764179&r1=1764178&r2=1764179&view=diff
==============================================================================
--- ofbiz/branches/release15.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl (original)
+++ ofbiz/branches/release15.12/specialpurpose/ecommerce/webapp/ecommerce/customer/viewprofile.ftl Mon Oct 10 20:31:06 2016
@@ -336,20 +336,6 @@ under the License.

<#-- ============================================================= -->
<div class="screenlet">
- <h3>${uiLabelMap.PartyTaxIdentification}</h3>
- <div class="screenlet-body">
- <form method="post" action="<@ofbizUrl>createCustomerTaxAuthInfo</@ofbizUrl>" name="createCustTaxAuthInfoForm">
- <div>
- <input type="hidden" name="partyId" value="${party.partyId}"/>
- ${screens.render("component://order/widget/ordermgr/OrderEntryOrderScreens.xml#customertaxinfo")}
- <input type="submit" value="${uiLabelMap.CommonAdd}" class="smallSubmit"/>
- </div>
- </form>
- </div>
-</div>
-
-<#-- ============================================================= -->
-<div class="screenlet">
<div class="boxlink">
<a href="<@ofbizUrl>changepassword</@ofbizUrl>" class="submenutextright">${uiLabelMap.PartyChangePassword}</a>
</div>