svn commit: r1768157 - in /ofbiz/trunk/applications/product: minilang/shipment/shipment/ShipmentServices.xml servicedef/services_shipment.xml

[Deepak Dixit-5]

Author: deepak
Date: Sat Nov  5 08:07:55 2016
New Revision: 1768157

URL: http://svn.apache.org/viewvc?rev=1768157&view=rev
Log:
Improved: Convert ShipmentContactMech entity CRUD service to entity-auto, applied slightly modify patch from jira issue.
(OFBIZ-8895)

Thanks Pawan Verma for your contribution

Modified:
    ofbiz/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
    ofbiz/trunk/applications/product/servicedef/services_shipment.xml

Modified: ofbiz/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml?rev=1768157&r1=1768156&r2=1768157&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml (original)
+++ ofbiz/trunk/applications/product/minilang/shipment/shipment/ShipmentServices.xml Sat Nov  5 08:07:55 2016
@@ -1114,32 +1114,6 @@ under the License.
         <remove-value value-field="lookedUpValue"/>
     </simple-method>
 
-    <!-- ShipmentContactMech services -->
-    <simple-method method-name="createShipmentContactMech" short-description="Create ShipmentContactMech">
-        <make-value value-field="newEntity" entity-name="ShipmentContactMech"/>
-        <set-pk-fields map="parameters" value-field="newEntity"/>
-        <set-nonpk-fields map="parameters" value-field="newEntity"/>
-
-        <create-value value-field="newEntity"/>
-    </simple-method>
-    <simple-method method-name="updateShipmentContactMech" short-description="Update ShipmentContactMech">
-        <make-value value-field="lookupPKMap" entity-name="ShipmentContactMech"/>
-        <set-pk-fields map="parameters" value-field="lookupPKMap"/>
-        <find-by-primary-key entity-name="ShipmentContactMech" map="lookupPKMap" value-field="lookedUpValue"/>
-        <set-nonpk-fields map="parameters" value-field="lookedUpValue"/>
-        <store-value value-field="lookedUpValue"/>
-    </simple-method>
-    <simple-method method-name="deleteShipmentContactMech" short-description="Delete ShipmentContactMech">
-        <set value="Delete ShipmentContactMech" field="operationName"/>
-        <call-simple-method method-name="checkCanChangeShipmentStatusPacked"/>
-        <check-errors/>
-
-        <make-value value-field="lookupPKMap" entity-name="ShipmentContactMech"/>
-        <set-pk-fields map="parameters" value-field="lookupPKMap"/>
-        <find-by-primary-key entity-name="ShipmentContactMech" map="lookupPKMap" value-field="lookedUpValue"/>
-        <remove-value value-field="lookedUpValue"/>
-    </simple-method>
-
     <!-- ShipmentRouteSegment services -->
     <simple-method method-name="createShipmentRouteSegment" short-description="Create ShipmentRouteSegment">
         <set value="Create ShipmentRouteSegment" field="operationName"/>

Modified: ofbiz/trunk/applications/product/servicedef/services_shipment.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/product/servicedef/services_shipment.xml?rev=1768157&r1=1768156&r2=1768157&view=diff
==============================================================================
--- ofbiz/trunk/applications/product/servicedef/services_shipment.xml (original)
+++ ofbiz/trunk/applications/product/servicedef/services_shipment.xml Sat Nov  5 08:07:55 2016
@@ -336,22 +336,19 @@ under the License.
     </service>
 
     <!-- ShipmentContactMech Services -->
-    <service name="createShipmentContactMech" default-entity-name="ShipmentContactMech" engine="simple"
-            location="component://product/minilang/shipment/shipment/ShipmentServices.xml" invoke="createShipmentContactMech" auth="true">
+    <service name="createShipmentContactMech" default-entity-name="ShipmentContactMech" engine="entity-auto" invoke="create" auth="true">
         <description>Create ShipmentContactMech</description>
         <permission-service service-name="facilityGenericPermission" main-action="CREATE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>
         <auto-attributes include="nonpk" mode="IN" optional="true"/>
     </service>
-    <service name="updateShipmentContactMech" default-entity-name="ShipmentContactMech" engine="simple"
-            location="component://product/minilang/shipment/shipment/ShipmentServices.xml" invoke="updateShipmentContactMech" auth="true">
+    <service name="updateShipmentContactMech" default-entity-name="ShipmentContactMech" engine="entity-auto" invoke="update" auth="true">
         <description>Update ShipmentContactMech</description>
         <permission-service service-name="facilityGenericPermission" main-action="UPDATE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>
         <auto-attributes include="nonpk" mode="IN" optional="true"/>
     </service>
-    <service name="deleteShipmentContactMech" default-entity-name="ShipmentContactMech" engine="simple"
-            location="component://product/minilang/shipment/shipment/ShipmentServices.xml" invoke="deleteShipmentContactMech" auth="true">
+    <service name="deleteShipmentContactMech" default-entity-name="ShipmentContactMech" engine="entity-auto" invoke="delete" auth="true">
         <description>Delete ShipmentContactMech</description>
         <permission-service service-name="facilityGenericPermission" main-action="DELETE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>