Author: diveshdutta
Date: Sat Nov 5 16:18:54 2016 New Revision: 1768237 URL: http://svn.apache.org/viewvc?rev=1768237&view=rev Log: Improvement: Minilang code readability and consistency improvements. (OFBIZ-9109) Thanks: Ankush Upadhyay for the patch. Modified: ofbiz/trunk/applications/marketing/servicedef/secas.xml ofbiz/trunk/framework/service/servicedef/secas_test_se.xml ofbiz/trunk/specialpurpose/ebaystore/servicedef/secas.xml ofbiz/trunk/specialpurpose/scrum/servicedef/secas.xml Modified: ofbiz/trunk/applications/marketing/servicedef/secas.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/marketing/servicedef/secas.xml?rev=1768237&r1=1768236&r2=1768237&view=diff ============================================================================== --- ofbiz/trunk/applications/marketing/servicedef/secas.xml (original) +++ ofbiz/trunk/applications/marketing/servicedef/secas.xml Sat Nov 5 16:18:54 2016 @@ -47,7 +47,7 @@ under the License. <!-- update contact list communication status --> <eca service="updateCommunicationEvent" event="commit"> <condition-field field-name="statusId" operator="not-equals" to-field-name="oldStatusId"/> - <action mode="sync" service="updateCommStatusFromCommEvent"/> + <action service="updateCommStatusFromCommEvent" mode="sync"/> </eca> <!-- update contact list party for bounced messages --> Modified: ofbiz/trunk/framework/service/servicedef/secas_test_se.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/servicedef/secas_test_se.xml?rev=1768237&r1=1768236&r2=1768237&view=diff ============================================================================== --- ofbiz/trunk/framework/service/servicedef/secas_test_se.xml (original) +++ ofbiz/trunk/framework/service/servicedef/secas_test_se.xml Sat Nov 5 16:18:54 2016 @@ -31,6 +31,6 @@ under the License. complete before the xml assertion test is run --> <eca service="testServiceEcaGlobalEventExec" event="return"> <set field-name="duration" value="5000" format="long"/> - <action mode="sync" service="blockingTestScv"/> + <action service="blockingTestScv" mode="sync"/> </eca> </service-eca> Modified: ofbiz/trunk/specialpurpose/ebaystore/servicedef/secas.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/ebaystore/servicedef/secas.xml?rev=1768237&r1=1768236&r2=1768237&view=diff ============================================================================== --- ofbiz/trunk/specialpurpose/ebaystore/servicedef/secas.xml (original) +++ ofbiz/trunk/specialpurpose/ebaystore/servicedef/secas.xml Sat Nov 5 16:18:54 2016 @@ -23,20 +23,20 @@ under the License. <eca service="createEbayProductStorePref" event="commit"> <condition field-name="enabled" operator="equals" value="Y"/> <condition field-name="serviceName" operator="is-not-empty"/> - <action mode="sync" service="startEbayAutoPreference"/> + <action service="startEbayAutoPreference" mode="sync"/> </eca> <eca service="updateEbayProductStorePref" event="commit"> <condition field-name="enabled" operator="equals" value="Y"/> <condition field-name="serviceName" operator="is-not-empty"/> - <action mode="sync" service="startEbayAutoPreference"/> + <action service="startEbayAutoPreference" mode="sync"/> </eca> <eca service="createEbayProductStorePref" event="commit"> <condition field-name="enabled" operator="equals" value="N"/> <condition field-name="serviceName" operator="is-not-empty"/> - <action mode="sync" service="stopEbayAutoPreference"/> + <action service="stopEbayAutoPreference" mode="sync"/> </eca> <eca service="updateEbayProductStorePref" event="commit"> <condition field-name="enabled" operator="equals" value="N"/> - <action mode="sync" service="stopEbayAutoPreference"/> + <action service="stopEbayAutoPreference" mode="sync"/> </eca> </service-eca> Modified: ofbiz/trunk/specialpurpose/scrum/servicedef/secas.xml URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/scrum/servicedef/secas.xml?rev=1768237&r1=1768236&r2=1768237&view=diff ============================================================================== --- ofbiz/trunk/specialpurpose/scrum/servicedef/secas.xml (original) +++ ofbiz/trunk/specialpurpose/scrum/servicedef/secas.xml Sat Nov 5 16:18:54 2016 @@ -23,52 +23,52 @@ under the License. <eca service="updateWorkEffort" event="commit"> <condition field-name="currentStatusId" operator="equals" value="STS_COMPLETED"/> <set field-name="webSiteId" env-name="webSiteId"/> - <action mode="sync" service="autoCompleteBacklog"/> + <action service="autoCompleteBacklog" mode="sync"/> </eca> <eca service="createWorkEffort" event="commit"> <condition field-name="currentStatusId" operator="equals" value="SPRINT_ACTIVE"/> <set field-name="sprintId" env-name="workEffortId"/> <set field-name="sprintStatusId" env-name="currentStatusId"/> <set field-name="webSiteId" env-name="webSiteId"/> - <action mode="sync" service="autoScrumNotification"/> + <action service="autoScrumNotification" mode="sync"/> </eca> <eca service="updateWorkEffort" event="commit"> <condition field-name="currentStatusId" operator="equals" value="SPRINT_CLOSED"/> <set field-name="sprintId" env-name="workEffortId"/> <set field-name="sprintStatusId" env-name="currentStatusId"/> <set field-name="webSiteId" env-name="webSiteId"/> - <action mode="sync" service="autoScrumNotification"/> + <action service="autoScrumNotification" mode="sync"/> </eca> <eca service="createCustRequest" event="commit"> <condition field-name="statusId" operator="equals" value="CRQ_ACCEPTED"/> <set field-name="custRequestStatusId" value="CRQ_ACCEPTED"/> <set field-name="webSiteId" env-name="webSiteId"/> - <action mode="sync" service="autoScrumNotification"/> + <action service="autoScrumNotification" mode="sync"/> </eca> <eca service="setCustRequestStatus" event="commit"> <condition field-name="oldStatusId" operator="equals" value="CRQ_REVIEWED"/> <condition field-name="statusId" operator="equals" value="CRQ_ACCEPTED"/> <set field-name="custRequestStatusId" value="CRQ_ACCEPTED"/> <set field-name="webSiteId" env-name="webSiteId"/> - <action mode="sync" service="autoScrumNotification"/> + <action service="autoScrumNotification" mode="sync"/> </eca> <eca service="setCustRequestStatus" event="commit"> <condition field-name="statusId" operator="equals" value="CRQ_REVIEWED"/> <set field-name="custRequestStatusId" value="CRQ_REVIEWED"/> <set field-name="webSiteId" env-name="webSiteId"/> - <action mode="sync" service="autoScrumNotification"/> + <action service="autoScrumNotification" mode="sync"/> </eca> <eca service="setCustRequestStatus" event="commit"> <condition field-name="statusId" operator="equals" value="CRQ_COMPLETED"/> <set field-name="custRequestStatusId" value="CRQ_COMPLETED"/> <set field-name="webSiteId" env-name="webSiteId"/> - <action mode="sync" service="autoScrumNotification"/> + <action service="autoScrumNotification" mode="sync"/> </eca> <eca service="setCustRequestStatus" event="commit"> <condition field-name="statusId" operator="equals" value="CRQ_CANCELLED"/> <set field-name="custRequestStatusId" value="CRQ_CANCELLED"/> <set field-name="webSiteId" env-name="webSiteId"/> - <action mode="sync" service="autoScrumNotification"/> + <action service="autoScrumNotification" mode="sync"/> </eca> <!-- when a communication event is created check the subject for a PD# string, if found link the email to the certain product--> <eca service="createCommunicationEvent" event="commit"> |
Free forum by Nabble | Edit this page |