svn commit: r1769755 - in /ofbiz/trunk/applications/accounting: minilang/invoice/InvoiceServices.xml servicedef/services_invoice.xml

[Deepak Dixit-5]

Author: deepak
Date: Tue Nov 15 08:41:09 2016
New Revision: 1769755

URL: http://svn.apache.org/viewvc?rev=1769755&view=rev
Log:
Improved: Converted createInvoiceContactMech service from simple to entity auto, and fixed service definition for same, removed unused out parameter contactMechId from service definition, I don't understand purpose of this out parameter, and this service is used only in 3 places and not SECA rule define on it. So I think we can modify service definition.

Modified:
    ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml
    ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml

Modified: ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml?rev=1769755&r1=1769754&r2=1769755&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml (original)
+++ ofbiz/trunk/applications/accounting/minilang/invoice/InvoiceServices.xml Tue Nov 15 08:41:09 2016
@@ -1013,10 +1013,4 @@ under the License.
         </if-compare-field>
         <field-to-result field="isForeign"/>
     </simple-method>
-    <simple-method method-name="createInvoiceContactMech" short-description="Create a ContactMech for an invoice">
-        <make-value value-field="invoiceContactMech" entity-name="InvoiceContactMech"/>
-        <set-pk-fields map="parameters" value-field="invoiceContactMech"/>
-        <create-value value-field="invoiceContactMech"/>
-        <field-to-result field="contactMechId" result-name="invoiceContactMech"/>
-    </simple-method>
 </simple-methods>

Modified: ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml?rev=1769755&r1=1769754&r2=1769755&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml (original)
+++ ofbiz/trunk/applications/accounting/servicedef/services_invoice.xml Tue Nov 15 08:41:09 2016
@@ -301,12 +301,10 @@ under the License.
         <description>Checks to see if the payments applied to an invoice total up to the invoice total; if so sets to PAID</description>
         <attribute name="invoiceId" type="String" mode="IN" optional="false"/>
     </service>
-    <service name="createInvoiceContactMech" engine="simple" location="component://accounting/minilang/invoice/InvoiceServices.xml"
-             invoke="createInvoiceContactMech" default-entity-name="InvoiceContactMech">
+    <service name="createInvoiceContactMech" engine="entity-auto" invoke="create" default-entity-name="InvoiceContactMech">
         <description>Create a ContactMech for an invoice</description>
         <permission-service service-name="acctgInvoicePermissionCheck" main-action="CREATE"/>
         <auto-attributes include="pk" mode="IN" optional="false"/>
-        <attribute name="contactMechId" type="String" mode="OUT" optional="true"/>
     </service>
     <service name="deleteInvoiceContactMech" engine="entity-auto" invoke="delete" default-entity-name="InvoiceContactMech">
         <description>Delete a ContactMech for an invoice</description>