svn commit: r1770345 - in /ofbiz/trunk/applications: datamodel/entitydef/accounting-entitymodel.xml datamodel/entitydef/humanres-entitymodel.xml humanres/config/HumanResUiLabels.xml

Author: jleroux
Date: Fri Nov 18 09:11:52 2016
New Revision: 1770345

URL: http://svn.apache.org/viewvc?rev=1770345&view=rev
Log:
Improved: Document the rounting number fields in entities
(OFBIZ-7725)

Initially Swapnil Shah proposed to add a branchCode field in EftAccount and
Check entities. Pierre mentioned that branchCode is actually the same than the
existing rountingNumber field there.

This adds a description for the rountingNumber field (also in PayrollPreference
in humares) with a link to  https://en.wikipedia.org/wiki/Bank_code
where this field is explained for many countries.

As suggested by Paul Foxworthy I added the Bank-State-Branch label for
Australia. You might want to check the translation for you country or add it

Finally I removed the FormFieldTitle_routingNumber in in humanres, it's not used
anywhere and at least the French translation was wrong. Better to stick to
AccountingRoutingNumber

Thanks: Swapnil, Pierre and Paul for the helpful discussion

Modified:
    ofbiz/trunk/applications/datamodel/entitydef/accounting-entitymodel.xml
    ofbiz/trunk/applications/datamodel/entitydef/humanres-entitymodel.xml
    ofbiz/trunk/applications/humanres/config/HumanResUiLabels.xml

Modified: ofbiz/trunk/applications/datamodel/entitydef/accounting-entitymodel.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/datamodel/entitydef/accounting-entitymodel.xml?rev=1770345&r1=1770344&r2=1770345&view=diff
==============================================================================
--- ofbiz/trunk/applications/datamodel/entitydef/accounting-entitymodel.xml (original)
+++ ofbiz/trunk/applications/datamodel/entitydef/accounting-entitymodel.xml Fri Nov 18 09:11:52 2016
@@ -2799,7 +2799,7 @@ under the License.
             title="EFT Account Information Entity">
       <field name="paymentMethodId" type="id-ne"></field>
       <field name="bankName" type="name"></field>
-      <field name="routingNumber" type="short-varchar"></field>
+      <field name="routingNumber" type="short-varchar"><description>See https://en.wikipedia.org/wiki/Bank_code </description></field>
       <field name="accountType" type="short-varchar"></field>
       <field name="accountNumber" type="long-varchar"></field>
       <field name="nameOnAccount" type="name"></field>
@@ -2823,7 +2823,7 @@ under the License.
             title="Check Information Entity">
       <field name="paymentMethodId" type="id-ne"></field>
       <field name="bankName" type="name"></field>
-      <field name="routingNumber" type="short-varchar"></field>
+      <field name="routingNumber" type="short-varchar"><description>See https://en.wikipedia.org/wiki/Bank_code </description></field>
       <field name="accountType" type="short-varchar"></field>
       <field name="accountNumber" type="long-varchar"></field>
       <field name="nameOnAccount" type="name"></field>
@@ -3300,7 +3300,7 @@ under the License.
     <alias entity-alias="PM" name="fromDate"/>
     <alias entity-alias="PM" name="thruDate"/>
     <alias entity-alias="EA" name="bankName"/>
-    <alias entity-alias="EA" name="routingNumber"/><!-- also used for IBAN number -->
+    <alias entity-alias="EA" name="routingNumber"/><!-- also used for IBAN number, see https://en.wikipedia.org/wiki/Bank_code  -->
     <alias entity-alias="EA" name="accountType"/>
     <alias entity-alias="EA" name="accountNumber"/>
     <alias entity-alias="EA" name="nameOnAccount"/>

Modified: ofbiz/trunk/applications/datamodel/entitydef/humanres-entitymodel.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/datamodel/entitydef/humanres-entitymodel.xml?rev=1770345&r1=1770344&r2=1770345&view=diff
==============================================================================
--- ofbiz/trunk/applications/datamodel/entitydef/humanres-entitymodel.xml (original)
+++ ofbiz/trunk/applications/datamodel/entitydef/humanres-entitymodel.xml Fri Nov 18 09:11:52 2016
@@ -570,7 +570,7 @@ under the License.
       <field name="thruDate" type="date-time"></field>
       <field name="percentage" type="floating-point"></field>
       <field name="flatAmount" type="currency-amount"></field>
-      <field name="routingNumber" type="short-varchar"></field>
+      <field name="routingNumber" type="short-varchar"><description>See https://en.wikipedia.org/wiki/Bank_code </description></field>
       <field name="accountNumber" type="short-varchar"></field>
       <field name="bankName" type="name"></field>
       <prim-key field="partyId"/>

Modified: ofbiz/trunk/applications/humanres/config/HumanResUiLabels.xml
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/humanres/config/HumanResUiLabels.xml?rev=1770345&r1=1770344&r2=1770345&view=diff
==============================================================================
--- ofbiz/trunk/applications/humanres/config/HumanResUiLabels.xml (original)
+++ ofbiz/trunk/applications/humanres/config/HumanResUiLabels.xml Fri Nov 18 09:11:52 2016
@@ -694,17 +694,6 @@
         <value xml:lang="zh">简历正文</value>
         <value xml:lang="zh-TW">簡歷正文</value>
     </property>
-    <property key="FormFieldTitle_routingNumber">
-        <value xml:lang="en">Routing Number</value>
-        <value xml:lang="fr">N° de routage</value>
-        <value xml:lang="it">Numero Routing</value>
-        <value xml:lang="ja">ルーティング番号</value>
-        <value xml:lang="pt-BR">Número de rota</value>
-        <value xml:lang="th">หมายเลข Routing</value>
-        <value xml:lang="vi">Số phân công</value>
-        <value xml:lang="zh">汇款路线码</value>
-        <value xml:lang="zh-TW">匯款路線碼</value>
-    </property>
     <property key="FormFieldTitle_salary">
         <value xml:lang="en">Salary</value>
         <value xml:lang="it">Salario</value>