svn commit: r1774922 - in /ofbiz/trunk: applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/ applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/ applications/manufacturing/src/main/java/org/apache/ofbiz/manu...

Previous Topic Next Topic
 
classic Classic list List threaded Threaded
1 message Options
Reply | Threaded
Open this post in threaded view
|

svn commit: r1774922 - in /ofbiz/trunk: applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/ applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/ applications/manufacturing/src/main/java/org/apache/ofbiz/manu...

mbrohl
Author: mbrohl
Date: Sun Dec 18 18:12:21 2016
New Revision: 1774922

URL: http://svn.apache.org/viewvc?rev=1774922&view=rev
Log:
Improved: refactor javadocs in OFBiz to be standards compliant
(OFBIZ-9144)

Modified:
    ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java
    ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
    ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRun.java
    ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunHelper.java
    ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
    ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/techdata/TechDataServices.java
    ofbiz/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/SqlJdbcUtil.java
    ofbiz/trunk/framework/minilang/src/main/java/org/apache/ofbiz/minilang/SimpleMethod.java
    ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/LocalDispatcher.java
    ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/engine/ScriptEngine.java
    ofbiz/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/OfbizUrlTransform.java
    ofbiz/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java
    ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/GitHubAuthenticator.java
    ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/LinkedInAuthenticator.java

Modified: ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java (original)
+++ ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/invoice/InvoiceWorker.java Sun Dec 18 18:12:21 2016
@@ -369,7 +369,7 @@ public final class InvoiceWorker {
         return InvoiceWorker.getInvoiceTotal(invoice, actualCurrency).subtract(getInvoiceApplied(invoice, actualCurrency));
     }
     /**
-     * Returns amount not applied (i.e., still outstanding) of an invoice at an asOfDate, based on Payment.effectiveDate <= asOfDateTime
+     * Returns amount not applied (i.e., still outstanding) of an invoice at an asOfDate, based on Payment.effectiveDate &lt;= asOfDateTime
      *
      * @param invoice GenericValue object of the invoice
      * @param asOfDateTime the date to use
@@ -391,7 +391,7 @@ public final class InvoiceWorker {
     }
 
     /**
-     * Returns amount applied to invoice before an asOfDateTime, based on Payment.effectiveDate <= asOfDateTime
+     * Returns amount applied to invoice before an asOfDateTime, based on Payment.effectiveDate &lt;= asOfDateTime
      *
      * @param delegator the delegator
      * @param invoiceId the invoice id

Modified: ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java (original)
+++ ofbiz/trunk/applications/accounting/src/main/java/org/apache/ofbiz/accounting/payment/PaymentGatewayServices.java Sun Dec 18 18:12:21 2016
@@ -3333,7 +3333,7 @@ public class PaymentGatewayServices {
 
 
     /**
-     * Simple test processor; declines all orders < 100.00; approves all orders >= 100.00
+     * Simple test processor; declines all orders &lt; 100.00; approves all orders &gt;= 100.00
      */
     public static Map<String, Object> testProcessor(DispatchContext dctx, Map<String, ? extends Object> context) {
         Locale locale = (Locale) context.get("locale");
@@ -3363,7 +3363,7 @@ public class PaymentGatewayServices {
 
 
     /**
-     * Simple test processor; declines all orders < 100.00; approves all orders > 100.00
+     * Simple test processor; declines all orders &lt; 100.00; approves all orders &gt; 100.00
      */
     public static Map<String, Object> testProcessorWithCapture(DispatchContext dctx, Map<String, ? extends Object> context) {
         Locale locale = (Locale) context.get("locale");

Modified: ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRun.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRun.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRun.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRun.java Sun Dec 18 18:12:21 2016
@@ -113,11 +113,13 @@ public class ProductionRun {
         return productionRun;
     }
     /**
-     * store  the modified ProductionRun object in the database.
-     *     <li>store the the productionRun header
-     *     <li> the productProduced related data
-     *     <li> the listRoutingTask related data
-     *     <li> the productComponent list related data
+     * Store the modified ProductionRun object in the database.
+     * <ul>
+     *     <li>store the the productionRun header</li>
+     *     <li> the productProduced related data</li>
+     *     <li> the listRoutingTask related data</li>
+     *     <li> the productComponent list related data</li>
+     * </ul>
      * @return true if success false otherwise
      **/
     public boolean store() {
@@ -245,10 +247,10 @@ public class ProductionRun {
         this.estimatedCompletionDate = estimatedCompletionDate;
     }
     /**
-     * recalculated  the estimatedCompletionDate property.
-     *     Use the quantity and the estimatedStartDate properties as entries parameters.
-     *     <br/>read the listRoutingTask and for each recalculated and update the estimatedStart and endDate in the object.
-     *     <br/> no store in the database is done.
+     * Recalculate the estimatedCompletionDate property.
+     * Use the quantity and the estimatedStartDate properties as entries parameters.
+     * Read the listRoutingTask and for each recalculated and update the estimatedStart and endDate in the object.
+     * No store in the database is done.
      * @param priority give the routingTask start point to recalculated
      * @return the estimatedCompletionDate calculated
      **/

Modified: ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunHelper.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunHelper.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunHelper.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunHelper.java Sun Dec 18 18:12:21 2016
@@ -45,12 +45,11 @@ public final class ProductionRunHelper {
 
     /**
      * Get a Production Run.
-     *  <li> check if routing - product link exist
+     * Check if routing - product link exists.
+     *
      * @param delegator the delegator
      * @param productionRunId the production run id
      * @return Map with the result of the service, the output parameters are
-     * <li> the productionRun
-     * <li> the productionRunProduct
      */
     public static Map<String, Object> getProductionRun(Delegator delegator, String productionRunId) {
         Map<String, Object> result = new HashMap<String, Object>();

Modified: ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/jobshopmgt/ProductionRunServices.java Sun Dec 18 18:12:21 2016
@@ -174,14 +174,16 @@ public class ProductionRunServices {
 
     /**
      * Creates a Production Run.
-     *  <li> check if routing - product link exist
-     *  <li> check if product have a Bill Of Material
-     *  <li> check if routing have routingTask
-     *  <li> create the workEffort for ProductionRun
-     *  <li> create the WorkEffortGoodStandard for link between ProductionRun and the product it will produce
-     *  <li> for each valid routingTask of the routing create a workeffort-task
-     *  <li> for the first routingTask, create for all the valid productIdTo with no associateRoutingTask  a WorkEffortGoodStandard
-     *  <li> for each valid routingTask of the routing and valid productIdTo associate with this RoutingTask create a WorkEffortGoodStandard
+     * <ul>
+     *  <li> check if routing - product link exist</li>
+     *  <li> check if product have a Bill Of Material</li>
+     *  <li> check if routing have routingTask</li>
+     *  <li> create the workEffort for ProductionRun</li>
+     *  <li> create the WorkEffortGoodStandard for link between ProductionRun and the product it will produce</li>
+     *  <li> for each valid routingTask of the routing create a workeffort-task</li>
+     *  <li> for the first routingTask, create for all the valid productIdTo with no associateRoutingTask  a WorkEffortGoodStandard</li>
+     *  <li> for each valid routingTask of the routing and valid productIdTo associate with this RoutingTask create a WorkEffortGoodStandard</li>
+     * </ul>
      * @param ctx The DispatchContext that this service is operating in.
      * @param context Map containing the input parameters, productId, routingId, pRQuantity, startDate, workEffortName, description
      * @return Map with the result of the service, the output parameters.
@@ -481,11 +483,13 @@ public class ProductionRunServices {
 
     /**
      * Update a Production Run.
-     *  <li> update field and after recalculate the entire ProductionRun data (routingTask and productComponent)
-     *  <li> create the WorkEffortGoodStandard for link between ProductionRun and the product it will produce
-     *  <li> for each valid routingTask of the routing create a workeffort-task
-     *  <li> for the first routingTask, create for all the valid productIdTo with no associateRoutingTask  a WorkEffortGoodStandard
-     *  <li> for each valid routingTask of the routing and valid productIdTo associate with this RoutingTask create a WorkEffortGoodStandard
+     * <ul>
+     *  <li> update field and after recalculate the entire ProductionRun data (routingTask and productComponent)</li>
+     *  <li> create the WorkEffortGoodStandard for link between ProductionRun and the product it will produce</li>
+     *  <li> for each valid routingTask of the routing create a workeffort-task</li>
+     *  <li> for the first routingTask, create for all the valid productIdTo with no associateRoutingTask  a WorkEffortGoodStandard</li>
+     *  <li> for each valid routingTask of the routing and valid productIdTo associate with this RoutingTask create a WorkEffortGoodStandard</li>
+     * </ul>
      * @param ctx The DispatchContext that this service is operating in.
      * @param context Map containing the input parameters, productId, routingId, quantity, estimatedStartDate, workEffortName, description
      * @return Map with the result of the service, the output parameters.
@@ -1198,12 +1202,14 @@ public class ProductionRunServices {
     }
 
     /**
-     * check if field for routingTask update are correct and if need recalculated data in Production Run.
-     *  Check<ul>
-     *  <li> if estimatedStartDate is not before Production Run estimatedStartDate.</ul>
-     *  <li> if there is not a another routingTask with the same priority
-     *  If priority or estimatedStartDate has changed recalculated data for routingTask after that one.
-     * <br/> update the productionRun
+     * Check if field for routingTask update are correct and if need recalculated data in Production Run.
+     * Check
+     * <ul>
+     *  <li> if estimatedStartDate is not before Production Run estimatedStartDate.</li>
+     *  <li> if there is not a another routingTask with the same priority</li>
+     *  <li>If priority or estimatedStartDate has changed recalculated data for routingTask after that one.</li>
+     * </ul>
+     * Update the productionRun
      * @param ctx The DispatchContext that this service is operating in.
      * @param context Map containing the input parameters, productId, routingId, priority, estimatedStartDate, estimatedSetupMillis, estimatedMilliSeconds
      * @return Map with the result of the service, the output parameters, estimatedCompletionDate.

Modified: ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/techdata/TechDataServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/techdata/TechDataServices.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/techdata/TechDataServices.java (original)
+++ ofbiz/trunk/applications/manufacturing/src/main/java/org/apache/ofbiz/manufacturing/techdata/TechDataServices.java Sun Dec 18 18:12:21 2016
@@ -59,7 +59,7 @@ public class TechDataServices {
      *
      * @param ctx the dispatch context
      * @param context a map containing workEffortName (routingTaskName) and fixedAssetId (MachineGroup or ANY)
-     * @return result a map containing lookupResult (list of RoutingTask <=> workEffortId with currentStatusId = "ROU_ACTIVE" and workEffortTypeId = "ROU_TASK"
+     * @return result a map containing lookupResult (list of RoutingTask &lt;=&gt; workEffortId with currentStatusId = "ROU_ACTIVE" and workEffortTypeId = "ROU_TASK"
      */
     public static Map<String, Object> lookupRoutingTask(DispatchContext ctx, Map<String, ? extends Object> context) {
         Delegator delegator = ctx.getDelegator();

Modified: ofbiz/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/SqlJdbcUtil.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/SqlJdbcUtil.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/SqlJdbcUtil.java (original)
+++ ofbiz/trunk/framework/entity/src/main/java/org/apache/ofbiz/entity/jdbc/SqlJdbcUtil.java Sun Dec 18 18:12:21 2016
@@ -280,7 +280,7 @@ public final class SqlJdbcUtil {
         return sql.toString();
     }
 
-    /** Makes a WHERE clause String with "<col name>=?" if not null or "<col name> IS null" if null, all AND separated */
+    /** Makes a WHERE clause String with "&lt;col name&gt;=?" if not null or "&lt;col name&gt; IS null" if null, all AND separated */
     @Deprecated
     public static String makeWhereStringFromFields(List<ModelField> modelFields, Map<String, Object> fields, String operator) {
         return makeWhereStringFromFields(new StringBuilder(), modelFields, fields, operator, null).toString();
@@ -290,13 +290,13 @@ public final class SqlJdbcUtil {
         return makeWhereStringFromFields(sb, modelFields, fields, operator, null);
     }
 
-    /** Makes a WHERE clause String with "<col name>=?" if not null or "<col name> IS null" if null, all AND separated */
+    /** Makes a WHERE clause String with "&lt;col name&gt;=?" if not null or "&lt;col name&gt; IS null" if null, all AND separated */
     @Deprecated
     public static String makeWhereStringFromFields(List<ModelField> modelFields, Map<String, Object> fields, String operator, List<EntityConditionParam> entityConditionParams) {
         return makeWhereStringFromFields(new StringBuilder(), modelFields, fields, operator, entityConditionParams).toString();
     }
 
-    /** Makes a WHERE clause String with "<col name>=?" if not null or "<col name> IS null" if null, all AND separated */
+    /** Makes a WHERE clause String with "&lt;col name&gt;=?" if not null or "&lt;col name&gt; IS null" if null, all AND separated */
     public static StringBuilder makeWhereStringFromFields(StringBuilder sb, List<ModelField> modelFields, Map<String, Object> fields, String operator, List<EntityConditionParam> entityConditionParams) {
         if (modelFields.size() < 1) {
             return sb;

Modified: ofbiz/trunk/framework/minilang/src/main/java/org/apache/ofbiz/minilang/SimpleMethod.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/minilang/src/main/java/org/apache/ofbiz/minilang/SimpleMethod.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/framework/minilang/src/main/java/org/apache/ofbiz/minilang/SimpleMethod.java (original)
+++ ofbiz/trunk/framework/minilang/src/main/java/org/apache/ofbiz/minilang/SimpleMethod.java Sun Dec 18 18:12:21 2016
@@ -67,7 +67,7 @@ import org.w3c.dom.Element;
  * has a model class, and each model class has its own factory.
  * </p>
  * <p>
- * Mini-language can be extended by:<br />
+ * Mini-language can be extended by:</p>
  * <ul>
  * <li>Creating model classes that extend {@link org.apache.ofbiz.minilang.method.MethodOperation}</li>
  * <li>Creating factories for the model classes that implement {@link org.apache.ofbiz.minilang.method.MethodOperation.Factory}</li>
@@ -75,7 +75,7 @@ import org.w3c.dom.Element;
  * (see <a href="http://docs.oracle.com/javase/6/docs/api/java/util/ServiceLoader.html" target="_blank">ServiceLoader</a>)
  * </li>
  * </ul>
- * </p>
+ *
  * @see <a href="https://cwiki.apache.org/confluence/display/OFBADMIN/Mini+Language+-+minilang+-+simple-method+-+Reference">Mini-language Reference</a>
  */
 public final class SimpleMethod extends MiniLangElement {

Modified: ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/LocalDispatcher.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/LocalDispatcher.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/LocalDispatcher.java (original)
+++ ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/LocalDispatcher.java Sun Dec 18 18:12:21 2016
@@ -36,20 +36,17 @@ public interface LocalDispatcher {
 
     /**
      * Disables running of Service Engine Condition Actions (SECAs).  Intended to be turned off temporarily.
-     * @throws GenericServiceException
      */
     void disableEcas();
 
     /**
      * Reenables running of Service Engine Condition Actions (SECAs).
-     * @throws GenericServiceException
      */
     void enableEcas();
 
     /**
      * Returns whether Service Engine Condition Actions (SECAs) are disabled or not.
      * @return returns whether Service Engine Condition Actions (SECAs) are disabled or not.
-     * @throws GenericServiceException
      */
     boolean isEcasDisabled();
 

Modified: ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/engine/ScriptEngine.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/engine/ScriptEngine.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/engine/ScriptEngine.java (original)
+++ ofbiz/trunk/framework/service/src/main/java/org/apache/ofbiz/service/engine/ScriptEngine.java Sun Dec 18 18:12:21 2016
@@ -40,13 +40,13 @@ import org.apache.ofbiz.service.ServiceU
 
 /**
  * Generic Script Service Engine. This service engine uses the javax.script package (JSR-223) to invoke scripts or script functions.
- * <p>The script service engine will put the following artifacts in the script engine's bindings:<br />
+ * <p>The script service engine will put the following artifacts in the script engine's bindings:</p>
  * <ul>
  *   <li><code>parameters</code> - the service attributes <code>Map</code></li>
  *   <li><code>dctx</code> - a <code>DispatchContext</code> instance</li>
  *   <li><code>dispatcher</code> - a <code>LocalDispatcher</code> instance</li>
  *   <li><code>delegator</code> - a <code>Delegator</code> instance</li>
- * </ul></p>
+ * </ul>
  * <p>If the service definition includes an invoke attribute, then the matching script function/method will be called
  * with a single argument - the bindings <code>Map</code>.</p>
  */

Modified: ofbiz/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/OfbizUrlTransform.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/OfbizUrlTransform.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/OfbizUrlTransform.java (original)
+++ ofbiz/trunk/framework/webapp/src/main/java/org/apache/ofbiz/webapp/ftl/OfbizUrlTransform.java Sun Dec 18 18:12:21 2016
@@ -43,14 +43,14 @@ import freemarker.template.TemplateTrans
 
 /**
  * Freemarker Transform for creating OFBiz URLs (links).
- * <p>This transform accepts several arguments:<br>
+ * <p>This transform accepts several arguments:</p>
  * <ul>
  * <li><b>fullPath</b> (true/false) - generate a full URL including scheme and host, defaults to false.</li>
  * <li><b>secure</b> (true/false) - generate a secure (https) URL, defaults to false. Server settings will
  * override this argument.</li>
  * <li><b>encode</b> (true/false) - encode the URL, defaults to true. Encoding is UTF-8.</li>
  * <li><b>webSiteId</b> - generate a full URL using the web site settings found in the WebSite entity.</li>
- * </ul></p>
+ * </ul>
  * <p>In addition, this transform accepts an environment variable - <b>urlPrefix</b>. If the variable
  * exists, it is prepended to the contents of the transform (the part between
  * <code>&lt;@ofbizUrl&gt;</code> and <code>&lt;/@ofbizUrl&gt;</code>), and all transform arguments are

Modified: ofbiz/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java (original)
+++ ofbiz/trunk/framework/webtools/src/main/java/org/apache/ofbiz/webtools/WebToolsServices.java Sun Dec 18 18:12:21 2016
@@ -563,7 +563,8 @@ public class WebToolsServices {
 
     /** Get entity reference data. Returns the number of entities in
      * <code>numberOfEntities</code> and a List of Maps -
-     * <code>packagesList</code>.<br/> Each Map contains:<br/>
+     * <code>packagesList</code>.
+     * Each Map contains:<br>
      * <ul><li><code>packageName</code> - the entity package name</li>
      * <li><code>entitiesList</code> - a list of Maps:
        <ul>

Modified: ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/GitHubAuthenticator.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/GitHubAuthenticator.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/GitHubAuthenticator.java (original)
+++ ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/GitHubAuthenticator.java Sun Dec 18 18:12:21 2016
@@ -90,7 +90,7 @@ public class GitHubAuthenticator impleme
      * externalAuthId, and the externalAuthId has a valid accessToken in
      * GitHubUser entity.
      *
-     * @param username      User's username
+     * @param userLoginId   User's login id
      * @param password      User's password
      * @param isServiceAuth true if authentication is for a service call
      * @return true if the user is authenticated

Modified: ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/LinkedInAuthenticator.java
URL: http://svn.apache.org/viewvc/ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/LinkedInAuthenticator.java?rev=1774922&r1=1774921&r2=1774922&view=diff
==============================================================================
--- ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/LinkedInAuthenticator.java (original)
+++ ofbiz/trunk/specialpurpose/passport/src/main/java/org/apache/ofbiz/passport/user/LinkedInAuthenticator.java Sun Dec 18 18:12:21 2016
@@ -91,7 +91,7 @@ public class LinkedInAuthenticator imple
      * externalAuthId, and the externalAuthId has a valid accessToken in
      * LinkedInUser entity.
      *
-     * @param username      User's username
+     * @param userLoginId   User's login id
      * @param password      User's password
      * @param isServiceAuth true if authentication is for a service call
      * @return true if the user is authenticated