Author: deepak
Date: Mon Mar 20 17:39:21 2017
New Revision: 1787818
URL:
http://svn.apache.org/viewvc?rev=1787818&view=revLog:
Improved: Convert QuoteTerm entity CRUD service to entity-auto (OFBIZ-8903)
Thanks Pawan Verma for reporting.
Modified:
ofbiz/ofbiz-framework/trunk/applications/order/minilang/quote/QuoteServices.xml
ofbiz/ofbiz-framework/trunk/applications/order/servicedef/services.xml
Modified: ofbiz/ofbiz-framework/trunk/applications/order/minilang/quote/QuoteServices.xml
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/minilang/quote/QuoteServices.xml?rev=1787818&r1=1787817&r2=1787818&view=diff==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/order/minilang/quote/QuoteServices.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/order/minilang/quote/QuoteServices.xml Mon Mar 20 17:39:21 2017
@@ -982,20 +982,6 @@ under the License.
<remove-value value-field="quoteWorkEffort"/>
</if-not-empty>
</simple-method>
- <simple-method method-name="createQuoteTerm" short-description="Create a QuoteTerm">
- <make-value value-field="newEntity" entity-name="QuoteTerm"/>
- <if-empty field="parameters.quoteItemSeqId">
- <set field="parameters.quoteItemSeqId" value="_NA_"/>
- </if-empty>
- <set-pk-fields map="parameters" value-field="newEntity"/>
- <set-nonpk-fields map="parameters" value-field="newEntity"/>
- <create-value value-field="newEntity"/>
- </simple-method>
- <simple-method method-name="deleteQuoteTerm" short-description="Delete a QuoteTerm">
- <make-value value-field="newEntity" entity-name="QuoteTerm"/>
- <set-pk-fields map="parameters" value-field="newEntity"/>
- <remove-value value-field="newEntity"/>
- </simple-method>
<simple-method method-name="createQuoteNote" short-description="Create a new Note associated with a Quote">
<set-service-fields service-name="createNote" map="parameters" to-map="createNoteMap"/>
<!-- passed in field will be noteInfo, which matches entity, but service expects field called note -->
Modified: ofbiz/ofbiz-framework/trunk/applications/order/servicedef/services.xml
URL:
http://svn.apache.org/viewvc/ofbiz/ofbiz-framework/trunk/applications/order/servicedef/services.xml?rev=1787818&r1=1787817&r2=1787818&view=diff==============================================================================
--- ofbiz/ofbiz-framework/trunk/applications/order/servicedef/services.xml (original)
+++ ofbiz/ofbiz-framework/trunk/applications/order/servicedef/services.xml Mon Mar 20 17:39:21 2017
@@ -1103,14 +1103,13 @@ under the License.
<auto-attributes include="pk" mode="IN" optional="false"/>
</service>
- <service name="createQuoteTerm" engine="simple" default-entity-name="QuoteTerm"
- location="component://order/minilang/quote/QuoteServices.xml" invoke="createQuoteTerm">
+ <service name="createQuoteTerm" engine="entity-auto" default-entity-name="QuoteTerm" invoke="create">
<description>
Create a new Quate term.
</description>
<auto-attributes mode="IN" include="pk" optional="false"/>
<auto-attributes mode="IN" include="nonpk" optional="true"/>
- <override name="quoteItemSeqId" type="String" mode="IN" optional="true"/>
+ <override name="quoteItemSeqId" type="String" mode="IN" default-value="_NA_"/>
</service>
<service name="updateQuoteTerm" engine="entity-auto" default-entity-name="QuoteTerm" invoke="update">
<description>
@@ -1119,8 +1118,7 @@ under the License.
<auto-attributes mode="IN" include="pk" optional="false"/>
<auto-attributes mode="IN" include="nonpk" optional="true"/>
</service>
- <service name="deleteQuoteTerm" engine="simple" default-entity-name="QuoteTerm"
- location="component://order/minilang/quote/QuoteServices.xml" invoke="deleteQuoteTerm">
+ <service name="deleteQuoteTerm" engine="entity-auto" default-entity-name="QuoteTerm" invoke="delete">
<description>
delete the Quate term.
</description>
Locked
